From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: ozzloy Newsgroups: gmane.emacs.bugs Subject: bug#63941: [PATCH] ; always CRLF before non-first boundary in multipart form Date: Fri, 23 Jun 2023 01:22:20 -0700 Message-ID: References: <837csf4fp8.fsf@gnu.org> <83jzwe32pj.fsf@gnu.org> <83sfazzm8x.fsf@gnu.org> <83bkhb8m6i.fsf@gnu.org> <83bkh72vve.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000001c941905fec7b471" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2518"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63941@debbugs.gnu.org To: Eli Zaretskii , Kenjiro Nakayama , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 23 10:23:39 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qCc4w-0000QT-OC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Jun 2023 10:23:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCc4m-0005Fg-68; Fri, 23 Jun 2023 04:23:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCc4N-0004xc-47 for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 04:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qCc4M-0003x5-PJ for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 04:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qCc4M-0003zj-K4 for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 04:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: ozzloy Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jun 2023 08:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63941 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63941-submit@debbugs.gnu.org id=B63941.168750856615295 (code B ref 63941); Fri, 23 Jun 2023 08:23:02 +0000 Original-Received: (at 63941) by debbugs.gnu.org; 23 Jun 2023 08:22:46 +0000 Original-Received: from localhost ([127.0.0.1]:37596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCc45-0003yW-D6 for submit@debbugs.gnu.org; Fri, 23 Jun 2023 04:22:45 -0400 Original-Received: from mail-oo1-f47.google.com ([209.85.161.47]:49394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCc43-0003xh-Mb for 63941@debbugs.gnu.org; Fri, 23 Jun 2023 04:22:44 -0400 Original-Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-55e4d40794cso254275eaf.2 for <63941@debbugs.gnu.org>; Fri, 23 Jun 2023 01:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687508558; x=1690100558; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=P2HfJkVZUoSL7gTMK0ahVkyqYmP3ttyY1hMiyluZI+8=; b=BQ7nybFJUCVSUltfDeD+GyqgMu0Q4EBRBQsXchyohh4Jj3J3+jlDMPCHMyAoXo74kG WuW2u5ntrJUfcsdvQV2QxVcURO/hGJFN7KntX+LogjVEj954peHQp4BiNzdwOHQCwN0I pOt4ixzEbwS1qqkNBRvwWds9Ykv6Xqjj+X8o1zD2O1m5PNxxQ8KZkSbZYbKvrXxmFBZ9 VzgFYfCiIVW/66fNWB9QTXQ9fZservuLvoQzDstV5y89jKfAWj4kRK43KhhKpLeYu3C8 zk7yNuM2HWMiK1tiQigUbn5orBBW1ep7yEY1+3RllBpvHvGnkjDiTztHKlSHkEFv2aQF bGOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687508558; x=1690100558; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P2HfJkVZUoSL7gTMK0ahVkyqYmP3ttyY1hMiyluZI+8=; b=IV3jH741qtgrXSiu/FPjLWoYnZDmIkQnKhH/WpBL6LJYvFbRFJQXL8Lnr7LmOEWwn4 5Q73S4cgNV9l0B+psqW1jxqHz81HJIAfK3PSr88wW4K1/rNbnQi1GVojaFeqIzTXjqg/ 1VwLg/5koL8H1MQ0ZLwDtE6Tnvkf21MSePUCoSijWw41m1psvLJknvAVzWsjHq6U9ms2 veUNzNij2qTMEXE22PvP6Tk1NEg3tM3sD1zQhCfMAFgJyeg6FpwxFc4dR2CkhXYWooog 8usIS78ZqU9Em6l23G1elG2A0n/SJ1x7ZAP81Nd/2u1b8KoHUaCsiwJStEIaoJ9vCbQt xQ5A== X-Gm-Message-State: AC+VfDzv2GyKUq6rNnPIZ4VYAewgJY+HHQy7KRvbhxpmoko4O5fr8N26 2yjIBcVbaJhPSrdmPQA5s3sjXybZCVxO9HMVZSA= X-Google-Smtp-Source: ACHHUZ6CTOVsH8XR1ynAeth6j6kWlUUVfow31rAAGrxEWvi3TjjEhsSvYLXhWDUmbzBTrYCb/30JU+Pv/CnS4bXYRPE= X-Received: by 2002:a4a:b984:0:b0:563:5dc:471d with SMTP id e4-20020a4ab984000000b0056305dc471dmr448541oop.7.1687508557270; Fri, 23 Jun 2023 01:22:37 -0700 (PDT) In-Reply-To: <83bkh72vve.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263937 Archived-At: --0000000000001c941905fec7b471 Content-Type: text/plain; charset="UTF-8" >> From: ozzloy >> Date: Thu, 22 Jun 2023 11:25:05 -0700 >> Cc: 63941@debbugs.gnu.org >> >>> I really need some Gnus/eww expert to look into this and review the patch. >> >> Just checking, is this something I should do? Perhaps by reaching out to Lars >> and/or Kenjiro, the two most recent authors on that function? > > You could try, yes. oh, wow, i'm glad i asked. i thought maybe you were doing that and i should just wait until you were done. Hi Lars and Kenjiro! Could you review this patch? Or suggest someone who would be good to ask? https://git.sr.ht/~ozzloy/emacs/commit/c73ccda90623519434f8ec2c700adf70ac1d6a00 It fixes a problem where files uploaded through EWW have a newline at EOF chomped. Here's a set of instructions to reproduce the problem https://git.sr.ht/~ozzloy/emacs-bug-63941/tree/reproduce/item/readme.org and a bunch of tests showing the http messages generated by different clients and characterizing the behavior of prior versions of =mm-url-encode-multipart-form-data= https://git.sr.ht/~ozzloy/emacs-bug-63941/tree/reproduce/item/mm-url-tests.el thanks! --0000000000001c941905fec7b471 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

>> From: ozzloy <ozzloy@gmail.com>
>> Date: Thu, 22 Jun 2023 11:25:0= 5 -0700
>> Cc: 63941@debb= ugs.gnu.org
>>
>>> I really need some Gnus/eww exp= ert to look into this and review the patch.
>>
>> Just ch= ecking, is this something I should do? Perhaps by reaching out to Lars
&= gt;> and/or Kenjiro, the two most recent authors on that function?
&g= t;
> You could try, yes.

oh, wow, i'm glad i asked.=C2=A0 = i thought maybe you were doing that and i
should just wait until you wer= e done.

Hi Lars and Kenjiro!

Could you review this patch?=C2= =A0 Or suggest someone who would be good to ask?


It fixes a problem where files uploaded through EWW ha= ve a newline at EOF
chomped.


Here's a set of instructions= to reproduce the problem

https://git.sr.ht/~ozzloy/emacs-= bug-63941/tree/reproduce/item/readme.org


and a bunch of test= s showing the http messages generated by different clients
and character= izing the behavior of prior versions of
=3Dmm-url-encode-multipart-form-= data=3D

https://git.sr.ht/~ozzloy/emacs-bug-63941/tre= e/reproduce/item/mm-url-tests.el


= thanks!

--0000000000001c941905fec7b471--