From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: David Hull Newsgroups: gmane.emacs.bugs Subject: bug#33619: 26.1.90; Tramp "simplified" syntax completion problem Date: Wed, 5 Dec 2018 09:13:38 -0800 Message-ID: References: <877ego49am.fsf@igel.home> <875zw86yx9.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000074df5b057c4981b9" X-Trace: blaine.gmane.org 1544029932 16443 195.159.176.226 (5 Dec 2018 17:12:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 5 Dec 2018 17:12:12 +0000 (UTC) Cc: schwab@linux-m68k.org, 33619@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 05 18:12:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUaiV-00047T-IJ for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Dec 2018 18:12:07 +0100 Original-Received: from localhost ([::1]:35775 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUakZ-0006X3-CB for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Dec 2018 12:14:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUakQ-0006Wu-W6 for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2018 12:14:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUakM-0000Vd-UO for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2018 12:14:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58438) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gUakM-0000Ts-LS for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2018 12:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gUakM-0001uD-BH for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2018 12:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: David Hull Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Dec 2018 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33619-submit@debbugs.gnu.org id=B33619.15440300387309 (code B ref 33619); Wed, 05 Dec 2018 17:14:02 +0000 Original-Received: (at 33619) by debbugs.gnu.org; 5 Dec 2018 17:13:58 +0000 Original-Received: from localhost ([127.0.0.1]:34463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUakH-0001to-FC for submit@debbugs.gnu.org; Wed, 05 Dec 2018 12:13:58 -0500 Original-Received: from mail-io1-f47.google.com ([209.85.166.47]:35119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUakF-0001tc-Ko for 33619@debbugs.gnu.org; Wed, 05 Dec 2018 12:13:56 -0500 Original-Received: by mail-io1-f47.google.com with SMTP id n9so9250185ioo.2 for <33619@debbugs.gnu.org>; Wed, 05 Dec 2018 09:13:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openx.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HecNxoYikhFXjhb/9kfLRHtxA4XFDQ/iY1KHp+KNylg=; b=FjuRa2Kuauvlv2Ilr8c77MB9Fo30dYVNue+Vw8K8UxN99nFgTsQthfe3JUplhfFCAX 21Kg7zS325j/z/Dsl9sYBgTAoYsD9bIImgXwqgyRezsTQaXwdBF/wG23LABM/rGI0no0 RlLyLRbNgUIkum9Cr/aev1KgJ0PVp/h86VCi9CM6ud//P01K9uz4f+1wzpKj1e4xe1YS zWjXQ+C4T1DPn3tXn7Ye4UIqE0j1IF9ES4kqQgxw9qdGouIeNYD1S3DIUePKL1dZ4hco NnzlRj3mHT8DyCDEXaaCDe6f/XgbeRrRBvW4VgRDid9LSDB9xi9z57lhG//v+phwA7R2 2qPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HecNxoYikhFXjhb/9kfLRHtxA4XFDQ/iY1KHp+KNylg=; b=JfLiC5dNIIZFjfFLZ2FbInSV7CCPCwOg+nJz5uKhO6NV9tMTkee0m/1Ny2mCgCxSP9 bckYwNCYSEMxWiKB6p07dhj7GFNZJ6IxKwzeZo4G1fcgQCwjH/nPRDlc/MQen174OJ10 onxcQwxwCpgDNNv3Numgp6082wAqLoSrSkBAS+en+own5GEh1bgod3MlIjewtyWjF356 LNJ0GQRTr62Zl14SOtUVmqxAlrS6qv/D45lfD7sgjbSB56Fyn9kfEzAbbyJKVWZd8ugr q8ZXnib4OU9W19l40QGUWUM8elVxIKExtcRzmDQLSPakap8milmzP9ywQk46synHKejr ae/w== X-Gm-Message-State: AA+aEWZa80eEyjelrGfTxbwWUMHZwz1m7qllglxQmP1kGkpdz3VI5J2d ChTnIoBpMAXmKp+hRPieezmU/SaBwCtHErniBFpjPA== X-Google-Smtp-Source: AFSGD/UMg5e/WqbZic0fEuHxxhYdtqcqEqyk76UGIK4NwXr0UCZeXfS7zSqhANserU2/4PiMX0PKWOayAQF4OmHrMsg= X-Received: by 2002:a6b:4106:: with SMTP id n6mr21446133ioa.171.1544030029922; Wed, 05 Dec 2018 09:13:49 -0800 (PST) In-Reply-To: <875zw86yx9.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153116 Archived-At: --00000000000074df5b057c4981b9 Content-Type: text/plain; charset="UTF-8" My emacs was built from a tarball I downloaded from http://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-26.1.90.tar.gz. I believe this is commit 7851ae8b443c62a41ea4f4440512aa56cc87b9b7. It looks like this does not have the change made in commit 8d7e58ce9f389d77323e0237c22c4e. Here is the backtrace from my current build as requested. I will also try applying the fix from 8d7e58ce9f389d77323e0237c22c4e and test again. I ran "emacs -Q -l tramp", then in the *scratch* buffer: (emacs-version) "GNU Emacs 26.1.90 (build 1, x86_64-apple-darwin18.2.0, NS appkit-1671.10 Version 10.14.1 (Build 18B75))\n of 2018-12-03" (tramp-change-syntax 'simplified) simplified (setq debug-on-error t) t Then when I typed (from "view-lossage"): C-x C-f [find-file] / [self-insert-command] c [self-insert-command] o [self-insert-command] s [self-insert-command] 6 [self-insert-command] : [self-insert-command] s [self-insert-command] r [self-insert-command] c [self-insert-command] / [self-insert-command] s [self-insert-command] s [self-insert-command] [minibuffer-complete] I got the error: Debugger entered--Lisp error: (wrong-type-argument stringp "") signal(wrong-type-argument (stringp "")) completion--some(#f(compiled-function (style) #) (basic partial-completion emacs22)) completion--nth-completion(1 "~//cos6:src/ss" read-file-name-internal file-exists-p 14 (metadata (category . file) (completion--unquote-requote . t))) completion-try-completion("~//cos6:src/ss" read-file-name-internal file-exists-p 14 (metadata (category . file) (completion--unquote-requote . t))) completion--do-completion(12 26) completion--in-region-1(12 26) #f(compiled-function (start end collection predicate) #)(12 26 read-file-name-internal file-exists-p) apply(#f(compiled-function (start end collection predicate) #) (12 26 read-file-name-internal file-exists-p)) #f(compiled-function (funs global args) #)(nil nil (12 26 read-file-name-internal file-exists-p)) completion--in-region(12 26 read-file-name-internal file-exists-p) completion-in-region(12 26 read-file-name-internal file-exists-p) minibuffer-complete() funcall-interactively(minibuffer-complete) call-interactively(minibuffer-complete nil nil) command-execute(minibuffer-complete) read-from-minibuffer("Find file: " "~/" (keymap (keymap (32)) keymap (10 . minibuffer-complete-and-exit) (13 . minibuffer-complete-and-exit) keymap (menu-bar keymap (minibuf "Minibuf" keymap (tab menu-item "Complete" minibuffer-complete :help "Complete as far as possible") (space menu-item "Complete Word" minibuffer-complete-word :help "Complete at most one word") (63 menu-item "List Completions" minibuffer-completion-help :help "Display all possible completions") "Minibuf")) (27 keymap (118 . switch-to-completions)) (prior . switch-to-completions) (63 . minibuffer-completion-help) (32 . minibuffer-complete-word) (9 . minibuffer-complete) keymap (menu-bar keymap (minibuf "Minibuf" keymap (previous menu-item "Previous History Item" previous-history-element :help "Put previous minibuffer history element in the minibuffer") (next menu-item "Next History Item" next-history-element :help "Put next minibuffer history element in the minibuffer") (isearch-backward menu-item "Isearch History Backward" isearch-backward :help "Incrementally search minibuffer history backward") (isearch-forward menu-item "Isearch History Forward" isearch-forward :help "Incrementally search minibuffer history forward") (return menu-item "Enter" exit-minibuffer :key-sequence "\015" :help "Terminate input and exit minibuffer") (quit menu-item "Quit" abort-recursive-edit :help "Abort input and exit minibuffer") "Minibuf")) (10 . exit-minibuffer) (13 . exit-minibuffer) (7 . abort-recursive-edit) (C-tab . file-cache-minibuffer-complete) (9 . self-insert-command) (XF86Back . previous-history-element) (up . previous-line-or-history-element) (prior . previous-history-element) (XF86Forward . next-history-element) (down . next-line-or-history-element) (next . next-history-element) (27 keymap (114 . previous-matching-history-element) (115 . next-matching-history-element) (112 . previous-history-element) (110 . next-history-element))) nil file-name-history "~/" nil) completing-read-default("Find file: " read-file-name-internal file-exists-p confirm-after-completion "~/" file-name-history "~/" nil) completing-read("Find file: " read-file-name-internal file-exists-p confirm-after-completion "~/" file-name-history "~/") read-file-name-default("Find file: " nil "~/" confirm-after-completion nil nil) read-file-name("Find file: " nil "~/" confirm-after-completion) find-file-read-args("Find file: " confirm-after-completion) byte-code("\300\301\302 \"\207" [find-file-read-args "Find file: " confirm-nonexistent-file-or-buffer] 3) call-interactively(find-file nil nil) command-execute(find-file) On Wed, Dec 5, 2018 at 2:38 AM Michael Albinus wrote: > Andreas Schwab writes: > > > On Dez 04 2018, David Hull wrote: > > > >> Filename completion does not work with tramp's "simplified" syntax. > >> > >> (load-library "tramp") > >> (tramp-change syntax 'simplified) > >> > >> Now if I run find-file and type "//cos6:src/ss" and then TAB I get the > >> error: > >> > >> completion--some: Wrong type argument: stringp, "" > > > > This is fixed by commit b8b42c2315. > > Indeed, you've backported this fix to the emacs-26 branch. The bug > report tells us > > --8<---------------cut here---------------start------------->8--- > In GNU Emacs 26.1.90 (build 1, x86_64-apple-darwin18.2.0, NS > appkit-1671.10 Version 10.14.1 (Build 18B75)) > of 2018-12-03 built on mbp-109-op-04 > Repository revision: 8d7e58ce9f389d77323e0237c22c4e13cb68b8e7 > --8<---------------cut here---------------end--------------->8--- > > Hmm, a git commit 8d7e58ce9f389d77323e0237c22c4e13cb68b8e7 does not > exist in emacs-26 or master branches. > > > Andreas. > > Best regards, Michael. > -- David Hull --00000000000074df5b057c4981b9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
My emacs was built from a tarball I downloa= ded from http://git.savannah.gnu.org/cgit/emacs.git/snapshot/emac= s-26.1.90.tar.gz. I believe this is commit 7851ae8b443c62a41ea4f4440512= aa56cc87b9b7. It looks like this does not have the change made in commit 8d= 7e58ce9f389d77323e0237c22c4e.
Here is the backtrace fr= om my current build as requested. I will also try applying the fix from 8d7= e58ce9f389d77323e0237c22c4e and test again.

I ran "emacs -Q -l tramp", then in the *scratch* buffer= :

(emacs-version)
"GNU Emacs 26.1.90 (build 1= , x86_64-apple-darwin18.2.0, NS appkit-1671.10 Version 10.14.1 (Build 18B75= ))\n of 2018-12-03"
(tramp-change-syntax 'simplified)
simpli= fied
(setq debug-on-error t)
t

<= /div>
Then when I typed (from "view-lossage"):

=
=C2=A0C-x C-f [f= ind-file]
=C2=A0/ [self-insert-command]
=C2=A0c [self-insert-command]=
=C2=A0o [self-insert-command]
=C2=A0s [self-insert-command]
=C2= =A06 [self-insert-command]
=C2=A0: [self-insert-command]
=C2=A0s [sel= f-insert-command]
=C2=A0r [self-insert-command]
=C2=A0c [self-insert-= command]
=C2=A0/ [self-insert-command]
=C2=A0s [self-insert-command]<= br>=C2=A0s [self-insert-command]
=C2=A0<tab> [minibuffer-complete]=

I got the error:

Debugger entere= d--Lisp error: (wrong-type-argument stringp "")
=C2=A0 signal(= wrong-type-argument (stringp ""))
=C2=A0 completion--some(#f(c= ompiled-function (style) #<bytecode 0x40e7eafd>) (basic partial-compl= etion emacs22))
=C2=A0 completion--nth-completion(1 "~//cos6:src/ss= " read-file-name-internal file-exists-p 14 (metadata (category . file)= (completion--unquote-requote . t)))
=C2=A0 completion-try-completion(&q= uot;~//cos6:src/ss" read-file-name-internal file-exists-p 14 (metadata= (category . file) (completion--unquote-requote . t)))
=C2=A0 completion= --do-completion(12 26)
=C2=A0 completion--in-region-1(12 26)
=C2=A0 #= f(compiled-function (start end collection predicate) #<bytecode 0x400c2e= 6b>)(12 26 read-file-name-internal file-exists-p)
=C2=A0 apply(#f(com= piled-function (start end collection predicate) #<bytecode 0x400c2e6b>= ;) (12 26 read-file-name-internal file-exists-p))
=C2=A0 #f(compiled-fun= ction (funs global args) #<bytecode 0x40e6bd1d>)(nil nil (12 26 read-= file-name-internal file-exists-p))
=C2=A0 completion--in-region(12 26 re= ad-file-name-internal file-exists-p)
=C2=A0 completion-in-region(12 26 r= ead-file-name-internal file-exists-p)
=C2=A0 minibuffer-complete()
= =C2=A0 funcall-interactively(minibuffer-complete)
=C2=A0 call-interactiv= ely(minibuffer-complete nil nil)
=C2=A0 command-execute(minibuffer-compl= ete)
=C2=A0 read-from-minibuffer("Find file: " "~/" = (keymap (keymap (32)) keymap (10 . minibuffer-complete-and-exit) (13 . mini= buffer-complete-and-exit) keymap (menu-bar keymap (minibuf "Minibuf&qu= ot; keymap (tab menu-item "Complete" minibuffer-complete :help &q= uot;Complete as far as possible") (space menu-item "Complete Word= " minibuffer-complete-word :help "Complete at most one word"= ) (63 menu-item "List Completions" minibuffer-completion-help :he= lp "Display all possible completions") "Minibuf")) (27 = keymap (118 . switch-to-completions)) (prior . switch-to-completions) (63 .= minibuffer-completion-help) (32 . minibuffer-complete-word) (9 . minibuffe= r-complete) keymap (menu-bar keymap (minibuf "Minibuf" keymap (pr= evious menu-item "Previous History Item" previous-history-element= :help "Put previous minibuffer history element in the minibuffer"= ;) (next menu-item "Next History Item" next-history-element :help= "Put next minibuffer history element in the minibuffer") (isearc= h-backward menu-item "Isearch History Backward" isearch-backward = :help "Incrementally search minibuffer history backward") (isearc= h-forward menu-item "Isearch History Forward" isearch-forward :he= lp "Incrementally search minibuffer history forward") (return men= u-item "Enter" exit-minibuffer :key-sequence "\015" :he= lp "Terminate input and exit minibuffer") (quit menu-item "Q= uit" abort-recursive-edit :help "Abort input and exit minibuffer&= quot;) "Minibuf")) (10 . exit-minibuffer) (13 . exit-minibuffer) = (7 . abort-recursive-edit) (C-tab . file-cache-minibuffer-complete) (9 . se= lf-insert-command) (XF86Back . previous-history-element) (up . previous-lin= e-or-history-element) (prior . previous-history-element) (XF86Forward . nex= t-history-element) (down . next-line-or-history-element) (next . next-histo= ry-element) (27 keymap (114 . previous-matching-history-element) (115 . nex= t-matching-history-element) (112 . previous-history-element) (110 . next-hi= story-element))) nil file-name-history "~/" nil)
=C2=A0 comple= ting-read-default("Find file: " read-file-name-internal file-exis= ts-p confirm-after-completion "~/" file-name-history "~/&quo= t; nil)
=C2=A0 completing-read("Find file: " read-file-name-in= ternal file-exists-p confirm-after-completion "~/" file-name-hist= ory "~/")
=C2=A0 read-file-name-default("Find file: "= ; nil "~/" confirm-after-completion nil nil)
=C2=A0 read-file-= name("Find file: " nil "~/" confirm-after-completion)=C2=A0 find-file-read-args("Find file: " confirm-after-completi= on)
=C2=A0 byte-code("\300\301\302 \"\207" [find-file-rea= d-args "Find file: " confirm-nonexistent-file-or-buffer] 3)
= =C2=A0 call-interactively(find-file nil nil)
=C2=A0 command-execute(find= -file)


On Wed, Dec 5, 2018 at 2:38 AM Michael = Albinus <michael.albinus@gmx.d= e> wrote:
Andreas Schwab <= ;schwab@linux-m6= 8k.org> writes:

> On Dez 04 2018, David Hull <david.hull@openx.com> wrote:
>
>> Filename completion does not work with tramp's "simplifie= d" syntax.
>>
>>=C2=A0 =C2=A0(load-library "tramp")
>>=C2=A0 =C2=A0(tramp-change syntax 'simplified)
>>
>> Now if I run find-file and type "//cos6:src/ss" and then= TAB I get the
>> error:
>>
>>=C2=A0 =C2=A0completion--some: Wrong type argument: stringp, "= "
>
> This is fixed by commit b8b42c2315.

Indeed, you've backported this fix to the emacs-26 branch. The bug
report tells us

--8<---------------cut here---------------start------------->8---
In GNU Emacs 26.1.90 (build 1, x86_64-apple-darwin18.2.0, NS
appkit-1671.10 Version 10.14.1 (Build 18B75))
=C2=A0of 2018-12-03 built on mbp-109-op-04
Repository revision: 8d7e58ce9f389d77323e0237c22c4e13cb68b8e7
--8<---------------cut here---------------end--------------->8---

Hmm, a git commit 8d7e58ce9f389d77323e0237c22c4e13cb68b8e7 does not
exist in emacs-26 or master branches.

> Andreas.

Best regards, Michael.


--
David Hull
--00000000000074df5b057c4981b9--