unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: dalanicolai <dalanicolai@gmail.com>
To: Roland Winkler <winkler@gnu.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 42824@debbugs.gnu.org
Subject: bug#42824: 26.3; Feature request: implement 'smooth scroll' in djvu.el package
Date: Mon, 16 Nov 2020 14:08:08 +0100	[thread overview]
Message-ID: <CACJP=3kPO2j-gNWwxbjEgR1ogvFkW1Oc9juAx0oLa2e_cFCE1Q@mail.gmail.com> (raw)
In-Reply-To: <39733.23957.97016.24497@gargle.gargle.HOWL>

[-- Attachment #1: Type: text/plain, Size: 3077 bytes --]

The scrolling functionality looks great now. Indeed setting the
djvu-continuous to t provides the functionality that I requested/proposed.

Regarding the annotation features, I have implemented more in djvu2.el than
just highlighting rectangles. It also shows free text, line and arrow
annotations. I think those things can not be implemented via
`djvu-image-rect`. The djvu2.el page contains a demo screencast
<https://github.com/dalanicolai/djvu2.el#usage>. Just to remind you,
djvu2.el also implements djvu-occur and imenu functionality.

Regarding tooltips based on pixel coordinates, this can be achieved (as it
has been done in pdf-tools) via the `:map` and `:pointer` keywords in the image
descriptor
<https://www.gnu.org/software/emacs/manual/html_node/elisp/Image-Descriptors.html>.
However instead of implementing this separately, I think it would be great
if as much as possible of the pdf-tools code could be reused (I mean that
djvu and pdf share as much code as possible for similar functionality).
Although it would be great if it got implemented, so that Emacs also
becomes the best document reader, for me personally the invested time would
not be worth the gain (Although I might have a look at it some time as some
kind of exercise. djvu2.el for me was also just an exercise/study).
<https://www.gnu.org/software/emacs/manual/html_node/elisp/Image-Descriptors.html>

On Sun, 15 Nov 2020 at 22:18, Roland Winkler <winkler@gnu.org> wrote:

> On Sat Nov 7 2020 dalanicolai wrote:
> > I do not fully understand what you are referring to with 'more
> > complete and consistent, but  the functions I've sent in the
> > request are really small, only 5 lines, and I think they implement
> > the essence of doc-view its scrolling feature. It was really meant
> > as just a small extra convenient addition to solve the small, but
> > inconvenient problem, as explained in the original request.
>
> I have updated djvu.el on GNU Elpa, please take a look.
> I implemented commands for scrolling for the `Read' buffer both in
> regular (text) mode and image minor mode.  Also, I adopted the
> keybindings from doc-view and added a user option djvu-continuous
> similar to doc-view-continuous.  So likely you may want to customize
> djvu-continuous.
>
> Please, let me know if this works for you, then I can close this bug
> report.
>
> > Well, in the djvu2.el package, I use the info in the annotation
> > buffer to draw the annotations (using imagemagick its convert
> > command). Of course as just a plain reader (without annotation
> > features), doc-view is already a fine reader for djvu documents.
>
> You do not need imagemagick convert for this.  For the ppm images
> used by djvu.el, emacs can do that, too, see `djvu-image-rect'.
> Maybe I'll do that one day.
>
> However, adding just the color of the annotations I find less
> important than also displaying tooltips.  These tooltips are
> displayed in the regular text mode of the Read buffers.  I do not
> know how to generate tooltips based on the pixel coordinates of the
> mouse pointer over an image.
>

[-- Attachment #2: Type: text/html, Size: 3623 bytes --]

  reply	other threads:[~2020-11-16 13:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-12  8:38 bug#42824: 26.3; Feature request: implement 'smooth scroll' in djvu.el package dalanicolai
2020-10-26 21:42 ` Lars Ingebrigtsen
2020-10-27  1:32   ` dalanicolai
2020-10-28 19:45     ` Roland Winkler
2020-10-29 14:53       ` dalanicolai
2020-10-29 14:54         ` dalanicolai
2020-11-06 18:51         ` Roland Winkler
2020-11-07 19:16           ` dalanicolai
2020-11-15 21:18             ` Roland Winkler
2020-11-16 13:08               ` dalanicolai [this message]
2020-11-16 16:50                 ` Roland Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACJP=3kPO2j-gNWwxbjEgR1ogvFkW1Oc9juAx0oLa2e_cFCE1Q@mail.gmail.com' \
    --to=dalanicolai@gmail.com \
    --cc=42824@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=winkler@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).