From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: yyoncho Newsgroups: gmane.emacs.bugs Subject: bug#31138: Native json slower than json.el Date: Sun, 24 Mar 2019 13:37:23 +0200 Message-ID: References: <87sh806xwa.fsf@chapu.is> <834lkf7ely.fsf@gnu.org> <878t9own1p.fsf@chapu.is> <838t9o4hvl.fsf@gnu.org> <83r2ayovkx.fsf@gnu.org> <83pnqiormy.fsf@gnu.org> <83lg15pvzr.fsf@gnu.org> <83k1gppu73.fsf@gnu.org> <83ftrdprmj.fsf@gnu.org> <83d0mhpn99.fsf@gnu.org> <83zhplo25s.fsf@gnu.org> <83va09nwg3.fsf@gnu.org> <83tvftne0j.fsf@gnu.org> <40DA9396-044E-4D00-946E-42B776B51BFA@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a747af0584d58366" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="78624"; mail-complaints-to="usenet@blaine.gmane.org" Cc: =?UTF-8?Q?S=C3=A9bastien?= Chapuis , 31138@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 24 12:38:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h81S7-000KLq-Dj for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 12:38:11 +0100 Original-Received: from localhost ([127.0.0.1]:55104 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h81S6-0000Ff-Ba for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 07:38:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h81Rz-0000FL-M7 for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 07:38:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h81Ry-0003yA-94 for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 07:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42534) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h81Ry-0003xi-4o for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 07:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h81Rx-0004on-O2 for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 07:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: yyoncho Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Mar 2019 11:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31138 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 31138-submit@debbugs.gnu.org id=B31138.155342746318492 (code B ref 31138); Sun, 24 Mar 2019 11:38:01 +0000 Original-Received: (at 31138) by debbugs.gnu.org; 24 Mar 2019 11:37:43 +0000 Original-Received: from localhost ([127.0.0.1]:56078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h81Re-0004oC-Qt for submit@debbugs.gnu.org; Sun, 24 Mar 2019 07:37:43 -0400 Original-Received: from mail-qt1-f181.google.com ([209.85.160.181]:40945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h81Rc-0004nw-Tb for 31138@debbugs.gnu.org; Sun, 24 Mar 2019 07:37:41 -0400 Original-Received: by mail-qt1-f181.google.com with SMTP id x12so7307444qts.7 for <31138@debbugs.gnu.org>; Sun, 24 Mar 2019 04:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AmV5wVFzkC+GYyWFiQ2rZXgsl8MmKWpGKQo9cGWvHns=; b=PQPsrU8QZThln1cTRDkMgDUtowgQXE+QoG1yZvQlaK15OXLs7gLzj+jqeyeUeSD/yt NyCoOmQ/ZYVHOaOTSG5QA+ltTmpsRmtqqiQA+op5bG9Ce0Cv7jw77BVEgceODvW8/gjw wiLgMYlexShUY2hKI0n8UEv7oNW9fs3PqjiRv9cA2c4/ENldaPDfMA0ZHkImZFwujaV4 uDregl2YlnI5coUGYm9AjxoxrJ+RJT/lgs42zyPGlAoUw+h010419798dvwjZeRRK6M1 Ik0sqep7YAa1yxV8AJajtAkp8NEx64VmFmvxb12veEaA9p64HRMVfQa7OwIsT+CwSz21 iwdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AmV5wVFzkC+GYyWFiQ2rZXgsl8MmKWpGKQo9cGWvHns=; b=rx/WYE3JTCuPtB/TY1pYZo+cKPn1l1BH2qOryAROG00VfyiUrdLlWPxf/oiC3+UC3d jJM6c+t47aLK42mgnKrrP1uY0R+N7y5W2LJ+o+0CjqEkESfaFZr419V8SwvXc189EbYH 5eWO9eg5WInDhNCargIiM8X94J/2WYS0I1H3ocTORVzfjeCSvV2s0BbKrmQghyBjuJNk U7p9tNIU5QvUisaeUzaSGxLVxsefhrEdsyoqK3sxY1SKW16ejE4EMwEGtY7qE/zXbGPO htQ5s0gFLORQE3lMgzwEFclDjwMMgWeyqSX27EuUxjUxIX0OJ5vXuwGVkpiEwvlWeWLX I3ng== X-Gm-Message-State: APjAAAXGQZiY+KK9JMt3jhnzetnSPyjT+sBbokUMVhjaMRZ8BjvoEXfI A7vTcAQzTW2ulHH9Cqkwue1OgNOMzNfnDp3UhgE= X-Google-Smtp-Source: APXvYqz80kjwhQKZsXUBsyh9HYIsJNxrOdzQy3MgK0aj76QeZdZp9OfMewP6hAivCC64AhoXqpjHqKKvx2Xy0HBTQHg= X-Received: by 2002:a0c:bd2d:: with SMTP id m45mr10715733qvg.229.1553427455230; Sun, 24 Mar 2019 04:37:35 -0700 (PDT) In-Reply-To: <40DA9396-044E-4D00-946E-42B776B51BFA@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156690 Archived-At: --000000000000a747af0584d58366 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable After code_convert_string_norecord the callstack is the same as the callstack of the JSON parsing (it uses the same method to convert/validate the string). On Sun, 24 Mar 2019, 13:20 Eli Zaretskii, wrote: > On March 24, 2019 11:35:25 AM GMT+02:00, yyoncho > wrote: > > Hi Eli, > > > > The callstack is pretty much the same, here are the relevant parts: > > > > [-] code_convert_string_norecord@0x000055555565e30d (coding.c:9488) > > [-] module_make_string@0x00005555557d8f0d (emacs-module.c:597) > > [-] emacs::convert:: for &=E2=80= =99a > > T>::into_lisp@0x00007fffdeafe8c1 (Unknown source) > > [-] emacs_json_lsp::json_to_lisp@0x00007fffdeb0117e (Unknown source) > > [-] emacs_json_lsp::json_to_lisp@0x00007fffdeb0169f (Unknown source) > > [-] emacs_json_lsp::json_to_lisp@0x00007fffdeb012b3 (Unknown source) > > [-] emacs_json_lsp::json_to_lisp@0x00007fffdeb0169f (Unknown source) > > [-] emacs_json_lsp::json_to_lisp@0x00007fffdeb0169f (Unknown source) > > [-] emacs_json_lsp::parse_string@0x00007fffdeb019a9 (Unknown source) > > [-] std::panicking::try::do_call@0x00007fffdeb02a9f (Unknown source) > > [-] __rust_maybe_catch_panic@0x00007fffdeb2f26a (src/libpanic_unwind/ > > lib.rs:102) > > [-] > emacs::func::HandleCall>::handle_call@0x00007fffdeb0277a (Unknown > > source) > > [-] emacs_json_lsp::init::extern_lambda@0x00007fffdeb01cc4 (Unknown > > source) > > > > Thanks, > > Ivan > > > > On Sun, Mar 24, 2019 at 5:32 AM Eli Zaretskii wrote: > > > > > > From: yyoncho > > > > Date: Sat, 23 Mar 2019 23:04:18 +0200 > > > > Cc: S=C3=A9bastien Chapuis , > > > > 31138@debbugs.gnu.org > > > > > > > > I will try with run-hooks =3D nil. (I still cannot reproduce the > > issue > > > consistently). As a side note, I think that similar > > > > issue affects emacs dynamic modules based on my limited testing. > > Please > > > reply back if you need a callstack. > > > > > > Yes, a callstack in the case of modules would be helpful (although I > > > think I can guess where it will point). > > > > > > Thanks. > > > > > Thanks, but where is the call to the hook which iscthe source of the > problem? I don't even see Fkill_buffer in the backtrace. What am I > missing? > --000000000000a747af0584d58366 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
After=C2=A0co= de_convert_string_norecord=C2=A0the callstack is the same as the cal= lstack of the JSON parsing (it uses the same method to convert/validate the= string).=C2=A0=C2=A0



On Sun, 24 Mar 2019, 13:20 E= li Zaretskii, <eliz@gnu.org> wrote:
On March 24, 2019 11:35:25 AM GMT+02:00, yyoncho <yyoncho= @gmail.com> wrote:
> Hi Eli,
>
> The callstack is pretty much the same, here are the relevant parts: >
>=C2=A0 =C2=A0 [-] code_convert_string_norecord@0x000055555565e30d (codi= ng.c:9488)
>=C2=A0 =C2=A0 =C2=A0[-] module_make_string@0x00005555557d8f0d (emacs-mo= dule.c:597)
>=C2=A0 =C2=A0 =C2=A0[-] emacs::convert::<impl emacs::IntoLisp<=E2= =80=99e> for &=E2=80=99a
> T>::into_lisp@0x00007fffdeafe8c1 (Unknown source)
>=C2=A0 =C2=A0[-] emacs_json_lsp::json_to_lisp@0x00007fffdeb0117e (Unkno= wn source)
>=C2=A0 =C2=A0[-] emacs_json_lsp::json_to_lisp@0x00007fffdeb0169f (Unkno= wn source)
>=C2=A0 =C2=A0[-] emacs_json_lsp::json_to_lisp@0x00007fffdeb012b3 (Unkno= wn source)
>=C2=A0 =C2=A0[-] emacs_json_lsp::json_to_lisp@0x00007fffdeb0169f (Unkno= wn source)
>=C2=A0 =C2=A0[-] emacs_json_lsp::json_to_lisp@0x00007fffdeb0169f (Unkno= wn source)
>=C2=A0 =C2=A0[-] emacs_json_lsp::parse_string@0x00007fffdeb019a9 (Unkno= wn source)
>=C2=A0 =C2=A0[-] std::panicking::try::do_call@0x00007fffdeb02a9f (Unkno= wn source)
>=C2=A0 [-] __rust_maybe_catch_panic@0x00007fffdeb2f26a (src/libpanic_un= wind/
> lib.rs:102)
>=C2=A0 =C2=A0 =C2=A0[-] <emacs::CallEnv as
> emacs::func::HandleCall>::handle_call@0x00007fffdeb0277a (Unknown > source)
>=C2=A0 =C2=A0 [-] emacs_json_lsp::init::extern_lambda@0x00007fffdeb01cc= 4 (Unknown
> source)
>
> Thanks,
> Ivan
>
> On Sun, Mar 24, 2019 at 5:32 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > > From: yyoncho <yyoncho@gmail.com>
> > > Date: Sat, 23 Mar 2019 23:04:18 +0200
> > > Cc: S=C3=A9bastien Chapuis <sebastien@chapu.is= >,
> > >=C2=A0 =C2=A0 =C2=A0 =C2=A031138@debbugs.gnu.or= g
> > >
> > > I will try with run-hooks =3D nil. (I still cannot reproduce= the
> issue
> > consistently). As a side note, I think that similar
> > > issue affects emacs dynamic modules based on my limited test= ing.
> Please
> > reply back if you need a callstack.
> >
> > Yes, a callstack in the case of modules would be helpful (althoug= h I
> > think I can guess where it will point).
> >
> > Thanks.
> >

Thanks, but where is the call to the hook which iscthe source of the proble= m?=C2=A0 I don't even see Fkill_buffer in the backtrace.=C2=A0 What am = I missing?
--000000000000a747af0584d58366--