From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jan =?UTF-8?Q?Syn=C3=A1=C4=8Dek?= Newsgroups: gmane.emacs.bugs Subject: bug#51262: [PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry' Date: Tue, 19 Oct 2021 10:15:25 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8353"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51262@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 19 10:16:31 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mckIQ-0001wn-IS for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 10:16:30 +0200 Original-Received: from localhost ([::1]:45504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mckIP-0000Y1-5x for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 04:16:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mckHy-0000WX-4t for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 04:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37782) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mckHx-0003sZ-Rb for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 04:16:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mckHx-00025U-Ki for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 04:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jan =?UTF-8?Q?Syn=C3=A1=C4=8Dek?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2021 08:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51262 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51262-submit@debbugs.gnu.org id=B51262.16346313437997 (code B ref 51262); Tue, 19 Oct 2021 08:16:01 +0000 Original-Received: (at 51262) by debbugs.gnu.org; 19 Oct 2021 08:15:43 +0000 Original-Received: from localhost ([127.0.0.1]:49328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mckHf-00024u-J5 for submit@debbugs.gnu.org; Tue, 19 Oct 2021 04:15:43 -0400 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:39934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mckHd-00024e-Vj for 51262@debbugs.gnu.org; Tue, 19 Oct 2021 04:15:42 -0400 Original-Received: by mail-wr1-f41.google.com with SMTP id r18so46157147wrg.6 for <51262@debbugs.gnu.org>; Tue, 19 Oct 2021 01:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9KrQ3XDtBbseaGJ6in3aDZuxBUuWtKJVA5mz+zMU2bI=; b=jwYjEJz+bU+cHHh9/y6gnnRpA6wvI7Xw9F/yBwqsKUfKxuargn0si97KKLi//bT7GR DJVKccjttN4wp0pJ1Mn2cBnanZmk8cfGUnwY6gS2KPPnz+DjP6DadcrRSehQU80n/g1z qPcJgJSl3eZdYYqDwcf0O+Eixa8EvtyMVrF7B8jcEUgoAIKOhLY79L7Si3qyURNRAiuQ EKspWMyjeNPZF0IeNPh4OPYbqJj0JhkkmT/3kDG4swcMfwZTS6fOwtUitX8KjhZRBVzN UlwBS7CpB6ZI0+W+BkVNVFflqSHAJH2NML35I1pg7K3Vov3PKVXWRtdEYvtR7jyPvVzc vUpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9KrQ3XDtBbseaGJ6in3aDZuxBUuWtKJVA5mz+zMU2bI=; b=MwxdXcQ0F7ToDCR6MOa9tzI3IdglUIkUcYGDUX/qcNtjvmCmkbNqo4TBscrEp+wM50 QyhjGSH58TzUyB6e9rkHDtE22A5JYDevcB89CYOKYoM6fybsdK16ikSrVhKjKjZmvBK4 KeI+5CzoLLvf+ZLcjYeNmci0ZGYFfPJWPmfdZiIi/MoD2uL+oQbyYuPDychDbAIWVAEI 6Yl519nSxXQ/RUuQOCWYxNQLfrMkbFSxgAHjbbohU35UXpxwMBZsc5zHZZO2PTpRFGFt q7zJVPPtr/wTYADX8FL08vLFNgs6SvnPWpptcLTINXShxDzYgQr0Was4e9/OhCcXneq/ g1SA== X-Gm-Message-State: AOAM532btCbw8te/lh+Fi5hx08u1zOzRvXaDEaOFw8IF3Pg28Gy0JbZM WMbgp6Cl57r6/RbSvDff3iRktyU0bHrti/oCQ1M= X-Google-Smtp-Source: ABdhPJwR+A2BiVJlHlbNQ86vtDoKqsLt+IxBVA9gzTw87jpMt61ysJElmfS9N7yfRpMlgoYo6tnypystL92IX/V+964= X-Received: by 2002:a5d:6484:: with SMTP id o4mr43757033wri.337.1634631336027; Tue, 19 Oct 2021 01:15:36 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217552 Archived-At: On Tue, Oct 19, 2021 at 7:16 AM Stefan Kangas wrote: > ... > > Could you add some details here, such as what problem it is supposed to > fix? How can I reproduce the issue here, starting from emacs -Q? Sure. Sorry for not doing it earlier. For some reason, I assumed that this = was obvious. Here's the reproducer (built from the latest commit on the emacs-28 branch)= : 1) mkdir /tmp/test 2) cd /tmp/test/ 3) git init 4) echo data > file.txt 5) git add file.txt 6) git commit -m "first commit" 7) emacs -Q 8) 9) 10) This is what I see on my system (I hope that gmail doesn't remove the escap= es): * (HEAD -> master)520684e..: Jan Synacek 2021-10-19 first commit ^[[33mcommit 520684e773918234874a35738b094ca39b63a822^[ [m Author: Jan Synacek Date: Tue Oct 19 10:04:02 2021 +0200 first commit It might be dependent on git configuration, but I think it's safe to assume= that there might be escape sequences and simply use --no-color. And that's what my patch does. Regards, --=20 Jan Syn=C3=A1=C4=8Dek