From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jan =?UTF-8?Q?Syn=C3=A1=C4=8Dek?= Newsgroups: gmane.emacs.bugs Subject: bug#51262: [PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry' Date: Tue, 19 Oct 2021 10:53:41 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4516"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51262@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 19 10:55:56 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mckuZ-0000yy-TB for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 10:55:56 +0200 Original-Received: from localhost ([::1]:43598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mckuW-0003N9-3E for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 04:55:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mckti-0003Ld-9O for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 04:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mckth-0006wZ-W5 for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 04:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mckth-00039P-R9 for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 04:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jan =?UTF-8?Q?Syn=C3=A1=C4=8Dek?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2021 08:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51262 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51262-submit@debbugs.gnu.org id=B51262.163463364312036 (code B ref 51262); Tue, 19 Oct 2021 08:55:01 +0000 Original-Received: (at 51262) by debbugs.gnu.org; 19 Oct 2021 08:54:03 +0000 Original-Received: from localhost ([127.0.0.1]:49386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcksl-000384-0L for submit@debbugs.gnu.org; Tue, 19 Oct 2021 04:54:03 -0400 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:42534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcksg-00037W-Bs for 51262@debbugs.gnu.org; Tue, 19 Oct 2021 04:54:02 -0400 Original-Received: by mail-wr1-f52.google.com with SMTP id v17so46297002wrv.9 for <51262@debbugs.gnu.org>; Tue, 19 Oct 2021 01:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=45qez4I9YxaZKlawLyZwMIgs/qQBMi0JM1rOQXenSIQ=; b=POobRIGJtnJ0KzhJc6wQ++o+i1yU4u59RcwmDUxUZGSyhbadrI6J0MiXx+FArfisv0 scSuN+N5t4bMogHdsQVCjP6hOwv83gB0deJ8gWwu95FFoal/auhj9t1VDXeVcKJF7Xea 2R72nT1rxpeiM0xM9b9ZcG6LO0+lf8v0tZ3a7CRvlgINE4/NYHjUiZR6g3OoTitDaLaS X0eCs3LFaRZF2yJyNzT6e/LOCbRopya3z/pxIwfjakcslRNln21+taVbyMXZRtD8On5s Nd1T3b//34H8AYimzFg+tVZ2JxKWd5bsm392GUaVoNVw/5D1LP3lZXnDU2gC5UlbyNrH +krA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=45qez4I9YxaZKlawLyZwMIgs/qQBMi0JM1rOQXenSIQ=; b=ZN6FPGVkj0KMusJ+d7oIZvOS86uN9IkMZy1XcA8MDQN89ijxXRwp5jlAwQJ6AyAma0 cau8lgivOxef16Q52wy+xWdlGRGEWRWja5TX4+iwgSzmyCJJ7YMsdt1EdkB2zLT2Phfz PuVQILQiJ7fqb+NoF2n0dq2eqLiaUyR+plnyfYKXx/+R0VuqAre/drFL6rU3x1woYz50 TvoVdI/n6ofJCikPgTSVDV7Ss3f2QtruFRP4/Y0Hs97g66uUQfDTEKDQQFL0Rs8pfUSK WU3ZkLYkNJUEi8W78lSayz76/Iik9wv0TC8m5M0KOeu33PyXmqfru560b/Nz87LC09dl K3BQ== X-Gm-Message-State: AOAM533zoDLoDrUtFhRWtzHxoNNib444+FXEo/Xt9mXhL674orS3VUA/ RfwT6lKbfvWWp4JGz5+NV6UmPVxVaKJG8N5/QHk= X-Google-Smtp-Source: ABdhPJwisxeqUb5r3PaiiU+/c/KWvr1OWLrmwvZ5j+3fCgFHb7OGPKEFDMBMBnlfP9NxlBskQiZ+5EiE/hC+2VOh6FE= X-Received: by 2002:a5d:6484:: with SMTP id o4mr43958273wri.337.1634633632513; Tue, 19 Oct 2021 01:53:52 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217554 Archived-At: On Tue, Oct 19, 2021 at 10:33 AM Stefan Kangas wrote: > > ... > > This is what I see on my system (I hope that gmail doesn't remove the escapes): > > > > * (HEAD -> master)520684e..: Jan Synacek 2021-10-19 first commit > > ^[[33mcommit 520684e773918234874a35738b094ca39b63a822^[ [m > > Author: Jan Synacek > > Date: Tue Oct 19 10:04:02 2021 +0200 > > > > first commit > > Here, I actually see the colours, and no escape sequences. Colors as in interpreted escape sequences? > The question is what is different in our setups. Could you post the > output of M-x report-emacs-bug? Is there anything in your ~/.gitconfig > that could be causing this? > > > It might be dependent on git configuration, but I think it's safe to assume that > > there might be escape sequences and simply use --no-color. And that's what > > my patch does. > > I agree that you shouldn't need to see those escape sequences, but it > would be better if we could narrow it down so we don't have to remove > colours for everyone. The first step is to try to figure out what it is > that makes you see control sequences where I get colours. It looks like the following part of my ~/.gitconfig triggers the issue: ... [color] ui = always ... Here's the outupt of report-emacs-bug: In GNU Emacs 28.0.60 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4) of 2021-10-19 built on jsynacek-home Repository revision: 66fbd5527335cb3136b65ed3644e5a8b151add32 Repository branch: emacs-28 Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: Arch Linux Configured using: 'configure --with-native-compilation' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source eieio eieio-core eieio-loaddefs password-cache json map text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail comp comp-cstr warnings subr-x rx cl-seq cl-macs rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils add-log log-view pcvs-util cl-extra help-mode seq byte-opt gv bytecomp byte-compile cconv vc-mtn vc-hg vc-git diff-mode easy-mmode vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc vc-dispatcher dired-aux cl-loaddefs cl-lib dired dired-loaddefs iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 109429 5832) (symbols 48 9402 1) (strings 32 28203 1960) (string-bytes 1 908834) (vectors 16 19670) (vector-slots 8 345815 11442) (floats 8 30 53) (intervals 56 354 0) (buffers 992 14))