From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Erik Charlebois Newsgroups: gmane.emacs.bugs Subject: bug#14180: PATCH Better fullscreen frame support on Windows Date: Fri, 12 Apr 2013 15:32:08 -0400 Message-ID: References: <5167D3CE.90105@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e0111be2a7750ea04da2ef53c X-Trace: ger.gmane.org 1365795203 17454 80.91.229.3 (12 Apr 2013 19:33:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 12 Apr 2013 19:33:23 +0000 (UTC) Cc: 14180@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 12 21:33:23 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UQjip-00019H-Mu for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Apr 2013 21:33:19 +0200 Original-Received: from localhost ([::1]:38547 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQjip-0001QN-An for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Apr 2013 15:33:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQjih-0001Q1-55 for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2013 15:33:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQjic-0006Rt-Fp for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2013 15:33:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQjic-0006Rm-D8 for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2013 15:33:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UQjmQ-0001dz-7J for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2013 15:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Erik Charlebois Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Apr 2013 19:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14180 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: patch Original-Received: via spool by 14180-submit@debbugs.gnu.org id=B14180.13657953696028 (code B ref 14180); Fri, 12 Apr 2013 19:37:02 +0000 Original-Received: (at 14180) by debbugs.gnu.org; 12 Apr 2013 19:36:09 +0000 Original-Received: from localhost ([127.0.0.1]:47810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQjlY-0001Z8-BN for submit@debbugs.gnu.org; Fri, 12 Apr 2013 15:36:08 -0400 Original-Received: from mail-ie0-f178.google.com ([209.85.223.178]:46564) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQjlV-0001Yh-Ex for 14180@debbugs.gnu.org; Fri, 12 Apr 2013 15:36:06 -0400 Original-Received: by mail-ie0-f178.google.com with SMTP id bn7so3868941ieb.9 for <14180@debbugs.gnu.org>; Fri, 12 Apr 2013 12:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=vbuovK1milBlF9xlzmy15R0FK8ic3SeqqbLTeCQmS5c=; b=adzPnJ/8F6/7elS7Zsf5caL+Mkdu7iMQ8JTGOu9oy9q83YaxZJzYRor5eXoJtDr0z7 PMipxU6VlAwhDMGD15dvnm5v/fM8T7VgvC+T9vC7eqRT+xOkR3zemTEonSpQViWpcsb0 fdLytpS5ceYCUnz0OTiYng3McF3lAJkUHj/wdtvDbAoosarnvH0ZEGgHumubaODVm2kr VNKB+nCIBevh7tQuxjUWtAnmBjp++yLOwNFsVMjNMDyOEzeLYFBQdVEdR7xt0sof3/o5 HdnuS8J6f6Y96VK+voFoi8qxw6yI6hpCxDE1vOkckogAYEFc1+eqsNVknhB0mhDFOeeU 4XrQ== X-Received: by 10.50.7.69 with SMTP id h5mr2636521iga.69.1365795128313; Fri, 12 Apr 2013 12:32:08 -0700 (PDT) Original-Received: by 10.64.27.3 with HTTP; Fri, 12 Apr 2013 12:32:08 -0700 (PDT) In-Reply-To: <5167D3CE.90105@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73369 Archived-At: --089e0111be2a7750ea04da2ef53c Content-Type: text/plain; charset=UTF-8 That's correct. The modeline scrollbar is slightly clipped. I just doubled checked toggling scrollbars, menubar and toolbar on and off while in fullscreen and it all works as expected. Thanks for the reminder since I usually run with all those elements off :). On Fri, Apr 12, 2013 at 5:28 AM, martin rudalics wrote: > > I've modified the response to WM_WINDOWPOSCHANGED to do nothing when the > > frame is fullscreen. Otherwise, the size gets tuned to a multiple of the > > character cells and > > the fullscreen isn't perfectly matching the screen. When this happens, > > Windows' special > > behavior to hide the taskbar doesn't kick in. > > I suppose that any remaining pixels go to the mode line which will have > a slightly shorter scrollbar if the pixel height of your monitor is not > a multiple of FRAME_LINE_HEIGHT. Can you observe that? > > martin > --089e0111be2a7750ea04da2ef53c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
That's correct. The modeline scrollbar is slightly cli= pped.

I just doubled checked toggling scrollbars, = menubar and toolbar on and off while in fullscreen and it all works as expe= cted.

Thanks for the reminder since I usually run= with all those elements off :).

=
On Fri, Apr 12, 2013 at 5:28 AM, martin ruda= lics <rudalics@gmx.at> wrote:
> I've modified the= response to WM_WINDOWPOSCHANGED to do nothing when the
> frame is fullscreen. Otherwise, the size gets tuned to a multiple of t= he
> character cells and
> the fullscreen isn't perfectly matching the screen. When this happ= ens,
> Windows' special
> behavior to hide the taskbar doesn't kick in.

I suppose that any remaining pixels go to the mode line which will have
a slightly shorter scrollbar if the pixel height of your monitor is not
a multiple of FRAME_LINE_HEIGHT. =C2=A0Can you observe that?

martin

--089e0111be2a7750ea04da2ef53c--