From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Troy Brown Newsgroups: gmane.emacs.bugs Subject: bug#70958: 30.0.50; eglot-managed-mode hooks not called on shutdown Date: Wed, 15 May 2024 08:38:28 -0400 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30529"; mail-complaints-to="usenet@ciao.gmane.io" To: 70958@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 15 14:39:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s7Dum-0007pb-PJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 May 2024 14:39:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7DuP-0007zp-Tm; Wed, 15 May 2024 08:39:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7DuO-0007za-RR for bug-gnu-emacs@gnu.org; Wed, 15 May 2024 08:39:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s7DuO-0005GG-Iv for bug-gnu-emacs@gnu.org; Wed, 15 May 2024 08:39:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s7DuQ-0000ZL-19 for bug-gnu-emacs@gnu.org; Wed, 15 May 2024 08:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Troy Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 May 2024 12:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 70958 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17157767322179 (code B ref -1); Wed, 15 May 2024 12:39:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 May 2024 12:38:52 +0000 Original-Received: from localhost ([127.0.0.1]:42190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7DuG-0000Z5-Bh for submit@debbugs.gnu.org; Wed, 15 May 2024 08:38:52 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:57612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7DuE-0000Yy-Cg for submit@debbugs.gnu.org; Wed, 15 May 2024 08:38:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7DuC-0007yP-BN for bug-gnu-emacs@gnu.org; Wed, 15 May 2024 08:38:48 -0400 Original-Received: from mail-ej1-f53.google.com ([209.85.218.53]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s7Du9-0005BH-Jc for bug-gnu-emacs@gnu.org; Wed, 15 May 2024 08:38:47 -0400 Original-Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a59b58fe083so153834366b.0 for ; Wed, 15 May 2024 05:38:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715776720; x=1716381520; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ip3dyGhLdcG1NRSbNt4mEYS7ZL87/pepRfUn5Dlpzsg=; b=UzOdSkvECVl1oMft8A1UxH0oTz//EoIBEi+SazBsaF+CkLzW984K+vIZ60hPM1lR8v vkD3n7iCozaFuD0KIXluqg+kVgtksnZaHoL6h/3qYmSrd1z0d8tydAATDQlFaU1pL1h4 Q3Fzg4V7N9oTTA1wVo4Zwp8U+VqajOzMPDHv3q6LsSn3Fz8WDg9+7qtQWS3axzQfTN/s e7iWvlDD87kBcOL0bFEIl0jTlf/Pn3ba7I17cEldn4ZCKVU5/php2WOIl3Jlkw+mNRHu pQbzFlEaKAR5v/dpsyF7eN4lXinl7Tr+OupMVos3t74YTDShlyBmju9b8dZRn7NxxPaA 6Cug== X-Gm-Message-State: AOJu0YyomBb/mwC1rou4tk+Q92O7F8KLUAalHSFMZKDOLwHwb6TmwgL5 h6bdM3JZRRl1YboMo/vafEMmWGv2t+rTo6KrcI2lzQLDcaIkuyVKI4Dv16nHSxo= X-Google-Smtp-Source: AGHT+IGrn/auehJZSTu0fWu5Nf32dVN63UOCKNMHhiSIiOYEbAP56iLvuDLHxvZUiPdidOnnflmgVQ== X-Received: by 2002:a17:906:289b:b0:a5a:8bc4:f503 with SMTP id a640c23a62f3a-a5a8bc4f988mr216040566b.25.1715776720141; Wed, 15 May 2024 05:38:40 -0700 (PDT) Original-Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com. [209.85.218.41]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a1781ce4esm870215666b.13.2024.05.15.05.38.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 May 2024 05:38:39 -0700 (PDT) Original-Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a5a8cd78701so183876066b.2 for ; Wed, 15 May 2024 05:38:39 -0700 (PDT) X-Received: by 2002:a17:906:b1d3:b0:a59:9db2:d988 with SMTP id a640c23a62f3a-a5a2d65f404mr1009865766b.50.1715776719320; Wed, 15 May 2024 05:38:39 -0700 (PDT) X-Gmail-Original-Message-ID: Received-SPF: pass client-ip=209.85.218.53; envelope-from=troy.s.brown@gmail.com; helo=mail-ej1-f53.google.com X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285079 Archived-At: The documentation for eglot-managed-mode-hook indicates that the hook is run after Eglot has started/stopped managing a buffer. I was trying to use this to perform setup/teardown of functionality when this happened, but it appears the registered hooks are never called on shutdown. The following is a little test that can be run in a buffer which has LSP support, to demonstrate the problem. My expectation is that "Buffer not managed" is output and the my-eglot-hook-var is changed to 'not-managed when a shutdown occurs. --8<---------------cut here---------------start------------->8--- (defun my-eglot-test () (defun my-eglot-hook () (message "my-eglot-hook invoked") (if (eglot-managed-p) (progn (message "Buffer is managed") (setq-local my-eglot-hook-var 'managed)) (message "Buffer not managed") (setq-local my-eglot-hook-var 'not-managed))) (add-hook 'eglot-managed-mode-hook #'my-eglot-hook) (setq-local my-eglot-hook-var 'initial) (cl-assert (not (eglot-managed-p))) (cl-assert (eq my-eglot-hook-var 'initial)) (call-interactively #'eglot) (cl-assert (eglot-managed-p)) (cl-assert (eq my-eglot-hook-var 'managed)) (sleep-for 3) ; wait for server connection (call-interactively #'eglot-shutdown) (cl-assert (not (eglot-managed-p))) (cl-assert (eq my-eglot-hook-var 'not-managed))) --8<---------------cut here---------------end--------------->8---