From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Troy Brown Newsgroups: gmane.emacs.bugs Subject: bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp Date: Sat, 4 Jan 2025 21:20:42 -0500 Message-ID: References: <53ccf716-7ca6-476f-af39-36300f0a7f1e@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26559"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Felician Nemeth , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 74914@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 05 03:21:24 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tUGGa-0006mP-Fl for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jan 2025 03:21:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tUGGG-0003qn-09; Sat, 04 Jan 2025 21:21:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUGGE-0003qZ-Id for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 21:21:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tUGGE-0000Gz-9u for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 21:21:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=A/bHMk9Ca7T/QitOe30Er9VhOdKZeAnnhWNbFgjDFSM=; b=pjNBn/+ljsNBcVPuR8FryeScb+DOvRfekx9IeLIniaGsA3QflMDOP3Ijdt9wbk+Xp9kGjjJhKFMmBfE70o5xh/BU+7BZNx4YVUoTkfqpWc+gU/Y3wzO1yyG1wlDV0jupXD/fw75pVb4QfBa7ULw6eQn0smpRCjI+uQwT5tcRDa/nW5mBN0aVDIr9XP0L6pFVo8hGtV/JD83agUmT4hUNVj2uYtsHAFQagk7jSObdALiiCtUuJWqrryCJ/cMwrtrm4goyHCeOPeA1yuJojTv9mwyKr1Tg/pbHOv5PK1BZyyTfCuCLdXe3wLEFiA+z/EmMtwEBTjFM3v/oK+wnKqGKGg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tUGGE-0002NI-4K for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 21:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Troy Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jan 2025 02:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74914-submit@debbugs.gnu.org id=B74914.17360436579112 (code B ref 74914); Sun, 05 Jan 2025 02:21:02 +0000 Original-Received: (at 74914) by debbugs.gnu.org; 5 Jan 2025 02:20:57 +0000 Original-Received: from localhost ([127.0.0.1]:58165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUGG9-0002Mt-C5 for submit@debbugs.gnu.org; Sat, 04 Jan 2025 21:20:57 -0500 Original-Received: from mail-ej1-f43.google.com ([209.85.218.43]:46394) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUGG7-0002Ml-Cf for 74914@debbugs.gnu.org; Sat, 04 Jan 2025 21:20:56 -0500 Original-Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a9e44654ae3so2212192666b.1 for <74914@debbugs.gnu.org>; Sat, 04 Jan 2025 18:20:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736043654; x=1736648454; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A/bHMk9Ca7T/QitOe30Er9VhOdKZeAnnhWNbFgjDFSM=; b=odKXfiCFVcZvgBKAb333TOCyQ2ZCoGCCp53Xusi5WiWuDD+mbJWuwlzPjnbDoUkGUH oPaEFvJK0S6OsH1pjDsQOxeB5MkV2NF/WbPVu9zkH1FI2w8QibPbAH/91N7vXAsl6Ta1 97XUWlxTcmRnFq4F9yBmXWekLVVEeoBiRKCPv5+MKanPZjL1q/OwCVLjGLXKfY5ApQZH LzhqNIMaJShltdhyCMxU4igvq+2iCWuybkL1cfzxI7tI+bzbpOPQYcf+Aas8TLbywzaS TALUTAYde9G1+HN0ypuE6sGw1Snc1RyUYN3htdCufrm7eqzc7T9b8CB7jcvNt4UWl/lo BQTw== X-Gm-Message-State: AOJu0Yw8DC2Kh2TR3uzi9+2MnkxfkGKL+GLBhESe1OBvISGs33hABh1I 8hS1jVlDCARdM+/11trJpIPZtvtZ/2zA+/iy+1cOghg8bLCEAOnIy/xXgr6c X-Gm-Gg: ASbGnct2lplY6Vd3urYU+JPHw1TsqmvFfx/e9EbEbCAEC2HmYDSws+vqmqTJwumiVw1 fl5Qz0mOpU26L7sDZpW4qrFgawz9Q8no8N4kQ1fnvkrbq4FLrsciikrtLA4DLQ9VOMgm/NeHHBx LUpuV2P5lzXqhpLRhjLoTB3Agh6i5Aze9nE2SNookrEomzJYACYmvyPqeTkXcIyUFIeapVaezF5 ivpcSDdm8ArMwQAUbYS6AIE6fEsBpbvPTOIJ9ItuYGgaYS+iPzyFM0ufHqe665EDWv3uEv2yeO0 ZRqwMGdO+AAdyyKw75nA X-Google-Smtp-Source: AGHT+IFUJMLwtXxeKks1rk2ozQviKLidqk81Y7PQGKcertniiPgfp8Ux8tvp5U/Ud0+tFShAiDw8CA== X-Received: by 2002:a17:907:3f12:b0:aa6:7220:f12f with SMTP id a640c23a62f3a-aac2ad8abccmr5778351366b.18.1736043653710; Sat, 04 Jan 2025 18:20:53 -0800 (PST) Original-Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com. [209.85.218.49]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0eae71desm2064079566b.89.2025.01.04.18.20.53 for <74914@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Jan 2025 18:20:53 -0800 (PST) Original-Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-aaeec07b705so1419483766b.2 for <74914@debbugs.gnu.org>; Sat, 04 Jan 2025 18:20:53 -0800 (PST) X-Received: by 2002:a17:907:7e8c:b0:aac:2128:c89e with SMTP id a640c23a62f3a-aac334f31fbmr5548708466b.43.1736043653102; Sat, 04 Jan 2025 18:20:53 -0800 (PST) In-Reply-To: <53ccf716-7ca6-476f-af39-36300f0a7f1e@gutov.dev> X-Gmail-Original-Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298490 Archived-At: On Sat, Dec 28, 2024 at 10:22=E2=80=AFPM Dmitry Gutov wr= ote: > > So, does this fix the problem for you? > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index 816a1e67eca..51c19d5681a 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -3416,7 +3416,7 @@ eglot--sig-info > 'font-lock-function-name-face)))= ) > ;; Now to the parameters > (cl-loop > - with active-param =3D (or sig-active activeParameter) > + with active-param =3D (or activeParameter sig-active) > for i from 0 for parameter across parameters do > (eglot--dbind ((ParameterInformation) > ((:label parlabel)) > I'm not sure how the diff was created, as I couldn't get it to apply cleanly, but yes, this change does fix the issue.