unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Troy Brown <brownts@troybrown.dev>
To: "Daniel Martín" <mardani29@yahoo.es>
Cc: 68664@debbugs.gnu.org
Subject: bug#68664: 29.1.50; treesit defun commands broken with nested functions
Date: Tue, 23 Jan 2024 09:30:49 -0500	[thread overview]
Message-ID: <CABvCZ42LyZaFMx8CJBMpPyrN1gkW5dUJFvwm3DqC0OGzVxHYCA@mail.gmail.com> (raw)
In-Reply-To: <m1y1cgubxw.fsf@yahoo.es>

On Mon, Jan 22, 2024 at 7:32 PM Daniel Martín <mardani29@yahoo.es> wrote:
>
> Troy Brown <brownts@troybrown.dev> writes:
>
> > I've noticed that "defun" related treesit commands do not appear to work
> > correctly when nested functions are involved.  I've seen this behavior
> > in multiple languages and believe the problem is an issue in the
> > treesit.el library.
>
> Customize the treesit-defun-tactic variable to 'top-level to ignore
> nested defuns in navigation commands.

But I don't want it to just go to the top-level, I want it to respect
the current
nesting level.  If I insert yet another level in the example, and
point is within
the second level of nesting, I want it to move to the beginning and end of that
nested function (i.e., "secondLevel" in the sample below when point is on the
call to innerFunction).  As mentioned in my original email, python-mode does
respect the nesting level correctly, but python-ts-mode, and other "ts" modes
that support nesting, don't respect it.

--8<---------------cut here---------------start------------->8---
# -*- mode: python-ts -*-

def outerFunction(text):
    text = text

    def secondLevel(text):
        print(text)

        def innerFunction(text):
            print(text)

        innerFunction()

        def innerFunction2(text):
            print(text)

        innerFunction2()

    secondLevel()

--8<---------------cut here---------------end--------------->8---





  reply	other threads:[~2024-01-23 14:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 23:10 bug#68664: 29.1.50; treesit defun commands broken with nested functions Troy Brown
2024-01-23  0:32 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-23 14:30   ` Troy Brown [this message]
2024-01-24  6:29     ` Yuan Fu
2024-01-24 14:13       ` Troy Brown
2024-01-24 17:25         ` Troy Brown
2024-01-27  4:26           ` Yuan Fu
2024-01-27  7:32             ` Eli Zaretskii
2024-01-28  4:03               ` Yuan Fu
2024-01-28  6:53                 ` Eli Zaretskii
2024-01-28  7:29                   ` Yuan Fu
2024-01-28  7:43                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABvCZ42LyZaFMx8CJBMpPyrN1gkW5dUJFvwm3DqC0OGzVxHYCA@mail.gmail.com \
    --to=brownts@troybrown.dev \
    --cc=68664@debbugs.gnu.org \
    --cc=mardani29@yahoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).