unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Troy Brown <brownts@troybrown.dev>
To: "João Távora" <joaotavora@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	72597@debbugs.gnu.org,
	Felician Nemeth <felician.nemeth@gmail.com>
Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return
Date: Tue, 13 Aug 2024 17:35:57 -0400	[thread overview]
Message-ID: <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@mail.gmail.com> (raw)
In-Reply-To: <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@mail.gmail.com>

On Tue, Aug 13, 2024 at 2:45 PM João Távora <joaotavora@gmail.com> wrote:
>
> On Tue, Aug 13, 2024 at 7:32 PM Felician Nemeth
> <felician.nemeth@gmail.com> wrote:
>
> > The way I understand it, Eglot calls gfm-view-mode to format this text.
> > So even if the observed behavior is not in line with the LSP
> > specification, it is the fault of gfm-view-mode and not directly
> > Eglot's.
> >
> > gfm-view-mode is part of the markdown-mode package, which is NonGNU
> > ELPA.
>
> Very correct.  Worth noting, though, that markdown-mode is an _optional_
> dependency of Eglot. It doesn't need it (but it will use it if it finds it).
>

I don't think it's gfm-view-mode's fault.  I can get the same
problematic behavior with MarkupContent of "plaintext" (which uses
text-mode), as follows:

(eglot--format-markup '(:value "foo\rbar" :kind "plaintext"))





  reply	other threads:[~2024-08-13 21:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13  1:16 bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Troy Brown
2024-08-13 11:18 ` Eli Zaretskii
2024-08-13 18:32   ` Felician Nemeth
2024-08-13 18:45     ` João Távora
2024-08-13 21:35       ` Troy Brown [this message]
2024-08-14  4:37         ` Eli Zaretskii
2024-08-14  5:54           ` Felician Nemeth
2024-08-14  6:37             ` Eli Zaretskii
2024-08-14 11:41               ` Troy Brown
2024-08-31  7:55                 ` Eli Zaretskii
2024-09-01 20:49                   ` Troy Brown
2024-09-02 11:24                     ` Eli Zaretskii
2024-09-02 12:31                       ` João Távora
2024-09-05 21:32                         ` Daniel Pettersson
2024-09-05 21:58                           ` João Távora
2024-09-06  5:44                           ` Eli Zaretskii
2024-09-06 16:00                             ` Daniel Pettersson
2024-09-06 19:31                             ` João Távora
2024-09-09  0:31                               ` Troy Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@mail.gmail.com' \
    --to=brownts@troybrown.dev \
    --cc=72597@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=felician.nemeth@gmail.com \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).