From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Troy Brown Newsgroups: gmane.emacs.bugs Subject: bug#73117: 30.0.90; Imenu missing entries when flattening by group Date: Sun, 8 Sep 2024 15:25:45 -0400 Message-ID: References: <86v7z6skkj.fsf@mail.linkov.net> <86y142p0hu.fsf@mail.linkov.net> <8734mac85k.fsf@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27789"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73117@debbugs.gnu.org, Juri Linkov To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 08 21:27:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1snNZ8-00075H-VD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Sep 2024 21:27:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1snNYs-0001UO-MF; Sun, 08 Sep 2024 15:27:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1snNYq-0001U6-OD for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2024 15:27:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1snNYq-0006pp-EB for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2024 15:27:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=H1XFNasPIMnS18UmGcloxkb0BoQHKuDk5vS4ZdWZNXk=; b=rvO6zOLzSa3n64qP4ZAB6EpqOb2ybE78xk3nz8uwB6kJygPFgxfpywX4m7rfYApKskd5fJ2Q4eUq7NDO87AVc18EGz7TBkK2AwG6rCfZ2Sq4rx8ysX9eYkKwLZF/qB0OAM9/mDd4keE21ZZZhHu09/YwxqeElk1inbXOCSs6o5emAdGThHecnVCi7nQ3hLb9IYL994K5UfsQf8O1voz9RuqJ3sHIsB7KfSgMC8B6PydjST2awBsbgz3NjHwprVDRnITTZOkmGAhazsEXF3XBITRapmlYAi2gfPV9stB1+W/MPXzyQeEhj9hgdUa+n5hDzVD/+98XCB0HXmNtuBVE5Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1snNYr-0006zA-Qe for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2024 15:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Troy Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Sep 2024 19:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73117 X-GNU-PR-Package: emacs Original-Received: via spool by 73117-submit@debbugs.gnu.org id=B73117.172582357426784 (code B ref 73117); Sun, 08 Sep 2024 19:27:01 +0000 Original-Received: (at 73117) by debbugs.gnu.org; 8 Sep 2024 19:26:14 +0000 Original-Received: from localhost ([127.0.0.1]:60065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snNY3-0006xs-HG for submit@debbugs.gnu.org; Sun, 08 Sep 2024 15:26:14 -0400 Original-Received: from mail-ej1-f49.google.com ([209.85.218.49]:57495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snNXy-0006xQ-UK for 73117@debbugs.gnu.org; Sun, 08 Sep 2024 15:26:10 -0400 Original-Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a8d13b83511so197821366b.2 for <73117@debbugs.gnu.org>; Sun, 08 Sep 2024 12:26:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823558; x=1726428358; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H1XFNasPIMnS18UmGcloxkb0BoQHKuDk5vS4ZdWZNXk=; b=MkKdA83UQiCJb+WbjNjtmum2T1KHhVJCRgp2fYTzAaxoa1Qjwj8tmpreR3cOb+JBA9 EqcvcF8YCdiXxzmeJDiLcAPcNhoaLOxusEd8IkF2SXRiA5TZ0ZFIdta3q5Hr/GVYvM4/ 3i4lpwVfQligsfyPlAEQsLEBktMbLZUDZTul5QWdqMf3tHaI3A042lQbP2dy1BbEisG+ MF9gIoDrWRVfjGkX245N6dsjjWM7PfljYsvYWArlI3Ludo+Paf7UzNka0FmryvhwQtQB ZO9HOpbNpcoGN8JE8NPJsA+Ca1ZntPKCR3p4js9TkvPIA9u/KNzElWhpzgD9aBqFSVpu jGWA== X-Forwarded-Encrypted: i=1; AJvYcCWIoAzXBhf7mAz+OgCJKBXht8Z7N5MbixGgDe5TDnZZ2VjubefknH0CSnzS7Mv3UPOVFJB9aw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyU6UB020fRy00AsknPKvAzTGNgyDxovAAlnrGFafp9jYiu7PCZ IoXxRluq0arWCwrQgKTxaXt3xrqpQrnSTarlx+aZqqAQtSa/WQqepS3hX0tD00I= X-Google-Smtp-Source: AGHT+IF9hdiB58rEoQRdjsS0PefuUmUIN0eLGn0XWWat1b3yQ+4AGMCyf9Yh41oBQalfNC7ah6nM8A== X-Received: by 2002:a17:907:36c7:b0:a8a:572c:1bae with SMTP id a640c23a62f3a-a8a885bff77mr712154666b.2.1725823557543; Sun, 08 Sep 2024 12:25:57 -0700 (PDT) Original-Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com. [209.85.218.45]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d25952c01sm240851266b.64.2024.09.08.12.25.57 for <73117@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Sep 2024 12:25:57 -0700 (PDT) Original-Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a8a7929fd64so426075366b.0 for <73117@debbugs.gnu.org>; Sun, 08 Sep 2024 12:25:57 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVuBGYsDhYku3cN/Naea8PLMjH/iIKZ4WJXuAeR7SuU0m7WPuAB0fuFFFYSkv62t+te2zjRsA==@debbugs.gnu.org X-Received: by 2002:a17:907:9303:b0:a86:817e:d27a with SMTP id a640c23a62f3a-a8a88870e4dmr715000766b.61.1725823556947; Sun, 08 Sep 2024 12:25:56 -0700 (PDT) In-Reply-To: <8734mac85k.fsf@daniel-mendler.de> X-Gmail-Original-Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291479 Archived-At: On Sun, Sep 8, 2024 at 2:28=E2=80=AFPM Daniel Mendler wrote: > > Juri Linkov writes: > > > Maybe Daniel (Cc:ed) could help us understand > > why 'completion--insert-horizontal' doesn't display groups. > > If I remember correctly, I didn't add group titles to the horizontal > formatting in order to keep the display more dense, with the goal of > fitting as many candidates on the screen as possible. In my Vertico > package, I am using a similar strategy, where group titles are not shown > for the flat and grid display modes. In any case, there shouldn't be a > technical reason which prevents us from showing the titles also for the > horizontal display. It appears to be this line in `completion--insert-horizontal` which is causing all the trouble. When I comment that out, I get the output I'm expecting. Looking at the difference between `completion--insert-horizontal` and `completion--insert-vertical`, that check happens after the check for `group-fun`. Maybe `completion--insert-horizontal` should be restructured similarly? ```elisp (unless (equal last-string str) ; Remove (consecutive) duplicates. ```