From: Troy Brown <brownts@troybrown.dev>
To: Daniel Mendler <mail@daniel-mendler.de>
Cc: 73117@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#73117: 30.0.90; Imenu missing entries when flattening by group
Date: Sun, 8 Sep 2024 15:25:45 -0400 [thread overview]
Message-ID: <CABvCZ41Sg+evwvN2jB-NdXuCmeK1kkzVDx4rBX-qh7EX+s=bQw@mail.gmail.com> (raw)
In-Reply-To: <8734mac85k.fsf@daniel-mendler.de>
On Sun, Sep 8, 2024 at 2:28 PM Daniel Mendler <mail@daniel-mendler.de> wrote:
>
> Juri Linkov <juri@linkov.net> writes:
>
> > Maybe Daniel (Cc:ed) could help us understand
> > why 'completion--insert-horizontal' doesn't display groups.
>
> If I remember correctly, I didn't add group titles to the horizontal
> formatting in order to keep the display more dense, with the goal of
> fitting as many candidates on the screen as possible. In my Vertico
> package, I am using a similar strategy, where group titles are not shown
> for the flat and grid display modes. In any case, there shouldn't be a
> technical reason which prevents us from showing the titles also for the
> horizontal display.
It appears to be this line in `completion--insert-horizontal` which is
causing all the trouble. When I comment that out, I get the output
I'm expecting. Looking at the difference between
`completion--insert-horizontal` and `completion--insert-vertical`,
that check happens after the check for `group-fun`. Maybe
`completion--insert-horizontal` should be restructured similarly?
```elisp
(unless (equal last-string str) ; Remove (consecutive) duplicates.
```
next prev parent reply other threads:[~2024-09-08 19:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 1:41 bug#73117: 30.0.90; Imenu missing entries when flattening by group Troy Brown
2024-09-08 6:53 ` Juri Linkov
2024-09-08 14:19 ` Troy Brown
2024-09-08 16:35 ` Juri Linkov
2024-09-08 17:31 ` Troy Brown
2024-09-20 6:58 ` Juri Linkov
2024-09-28 9:20 ` Eli Zaretskii
2024-09-08 18:28 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-08 19:25 ` Troy Brown [this message]
2024-09-15 15:58 ` Troy Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABvCZ41Sg+evwvN2jB-NdXuCmeK1kkzVDx4rBX-qh7EX+s=bQw@mail.gmail.com' \
--to=brownts@troybrown.dev \
--cc=73117@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=mail@daniel-mendler.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).