unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Troy Brown <brownts@troybrown.dev>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 73280@debbugs.gnu.org, joaotavora@gmail.com, monnier@iro.umontreal.ca
Subject: bug#73280: 30.0.90; Eglot: eglot-workspace-configuration might not be found in .dir-locals.el
Date: Mon, 16 Sep 2024 14:53:53 -0400	[thread overview]
Message-ID: <CABvCZ416iSqrm53LUNth3bLn42EXvKZCrhAvX_DM4=wLSV75og@mail.gmail.com> (raw)
In-Reply-To: <86a5g7cvnx.fsf@gnu.org>

On Mon, Sep 16, 2024 at 2:15 PM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > I would say the major downside is that it is not intuitive at all.
>
> With the emergence of the *-ts-mode modes, we need to adjust our
> intuition.  We decided that having foo-mode settings cover foo-ts-mode
> as well as much as possible is an advantage, not a disadvantage.  So
> our intuition needs to follow suit.
>

That would be fine if this was isolated to only "ts" vs "non-ts"
modes.  Another example is "typescript-mode".  In order to configure
the server, you have to use "js-mode" in .dir-locals.el.  Why?
Because it's the first one in the list.

> > It's not consistent with how directory-local variables behave.
>
> I disagree.  Certain settings in .dir-locals are completely global,
> which is even more radical than this case.  Having to specify a
> setting once for several related modes is a Good Thing, IMO.
>

I proposed in my last response a mechanism where you could specify a
configuration for any of the modes associated with a server and have
it applied, rather than ignoring a configuration if it wasn't
explicitly specified for the first one in the list.  The way it
currently exists, you'll never be able to change the first mode in the
list or you will likely break someone's .dir-locals.el which had to
rely on this ordering in order to properly configure their server.

> > I don't think I'd agree with the first mode being representative, it
> > seems somewhat arbitrary.  For instance, in order to change
> > eglot-workspace-configuration for "sh-mode", you have to set the
> > configuration in .dir-locals.el for "bash-ts-mode"...who would've
> > guessed this?
>
> I'd like to think that in a not-so-distant future, _everyone_ will
> guess that.  Why not? it makes perfect sense to me.

What is that?  It's not consistent with the "foo-mode settings cover
foo-ts-mode", it's actually the other way around.  You have to set the
"ts" version in order to have it apply to the "non-ts" version.  YAML
is another one where the "ts" version is listed first in the list.
These are inconsistent.  Some lists specify the "non-ts" version
before the "ts" version, others swap those.  And furthermore, some
lists contain multiple "non-ts" modes, so it's arbitrary which one is
listed first.





  parent reply	other threads:[~2024-09-16 18:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-15 19:54 bug#73280: 30.0.90; Eglot: eglot-workspace-configuration might not be found in .dir-locals.el Troy Brown
2024-09-16 11:38 ` Eli Zaretskii
2024-09-16 13:48   ` João Távora
2024-09-16 17:07     ` Troy Brown
2024-09-16 18:15       ` Eli Zaretskii
2024-09-16 18:39         ` João Távora
2024-09-16 18:43           ` Eli Zaretskii
2024-09-16 18:53         ` Troy Brown [this message]
2024-09-16 19:07           ` João Távora
2024-09-16 21:34             ` Troy Brown
2024-09-16 19:17           ` Eli Zaretskii
2024-09-16 21:34   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABvCZ416iSqrm53LUNth3bLn42EXvKZCrhAvX_DM4=wLSV75og@mail.gmail.com' \
    --to=brownts@troybrown.dev \
    --cc=73280@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).