* bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp
@ 2024-12-16 15:19 Troy Brown
[not found] ` <handler.74914.B.173436237328655.ack@debbugs.gnu.org>
0 siblings, 1 reply; 2+ messages in thread
From: Troy Brown @ 2024-12-16 15:19 UTC (permalink / raw)
To: 74914; +Cc: Felician Nemeth, João Távora
I'm working with a language server that provides an `activeParameter`
field both in SignatureHelp (set to 0) as well as in
SignatureInformation (set to 1). Under this condition, for the
signature output in the echo area, Eglot always displays the first
parameter (i.e., index 0). According to the LSP specification, when
an `activeParameter` field is specified in SignatureInformation "this
is used in place of `SignatureHelp.activeParameter`". The following
is a partial log covering this transaction:
[jsonrpc] e[09:50:52.423] --> textDocument/signatureHelp[97]
{"jsonrpc":"2.0","id":97,"method":"textDocument/signatureHelp","params":{"textDocument":{"uri":"file:///home/troy/junk/gtkada_24.0.0_80c56171/src/glib.adb"},"position":{"line":102,"character":38}}}
[jsonrpc] e[09:50:52.444] <-- textDocument/publishDiagnostics
{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///home/troy/junk/gtkada_24.0.0_80c56171/src/glib.adb","diagnostics":[{"range":{"start":{"line":102,"character":38},"end":{"line":102,"character":39}},"source":"libadalang","message":"Missing
';'"},{"range":{"start":{"line":102,"character":38},"end":{"line":102,"character":39}},"source":"libadalang","message":"Skipped
token )"},{"range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}},"severity":4,"source":"ada.project","message":""}]}}
[jsonrpc] e[09:50:52.445] <-- textDocument/hover[95]
{"jsonrpc":"2.0","id":95,"result":null}
[jsonrpc] e[09:50:52.454] <-- textDocument/documentHighlight[96]
{"jsonrpc":"2.0","id":96,"result":null}
[jsonrpc] e[09:50:52.454] <-- textDocument/signatureHelp[97]
{"jsonrpc":"2.0","id":97,"result":{"signatures":[{"label":"function
Internal (Name : String; Thing : String) return
GType","documentation":"","parameters":[{"label":"Name"},{"label":"Thing"}],"activeParameter":1}],"activeSignature":0,"activeParameter":0}}
I believe the reason for Eglot's behavior is due to the way
"active-param" is specified in the cl-loop within `eglot--sig-info`.
```text
with active-param = (or sig-active activeParameter)
```
The value of activeParameter in SignatureInformation (activeParameter)
should be given higher priority (i.e., listed first) over the
activeParameter specified in SignatureHelp (sig-active).
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#74914: Acknowledgement (30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp)
[not found] ` <handler.74914.B.173436237328655.ack@debbugs.gnu.org>
@ 2024-12-23 15:54 ` Troy Brown
0 siblings, 0 replies; 2+ messages in thread
From: Troy Brown @ 2024-12-23 15:54 UTC (permalink / raw)
To: 74914; +Cc: Felician Nemeth, João Távora
FYI, this appears to be a regression introduced by
e33c0a549153fa3894f3b5e9c5e42ce07a1a68c7
Troy.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-23 15:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-16 15:19 bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp Troy Brown
[not found] ` <handler.74914.B.173436237328655.ack@debbugs.gnu.org>
2024-12-23 15:54 ` bug#74914: Acknowledgement (30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp) Troy Brown
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).