From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Troy Brown Newsgroups: gmane.emacs.bugs Subject: bug#73285: 30.0.90; editorconfig-indentation-alist missing modes Date: Tue, 17 Sep 2024 18:28:44 -0400 Message-ID: References: <86plp3ddcu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29603"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 73285@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 18 00:30:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sqghu-0007Xs-Ip for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Sep 2024 00:30:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqghj-0000Xr-Ur; Tue, 17 Sep 2024 18:29:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqghg-0000XN-5B for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2024 18:29:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqghf-0001HM-Rh for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2024 18:29:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=grsNqyFFx64pieg3J8ycBWuq8nNjNYHUaRGZt4f45Z8=; b=KrZdU7XC1ya0ngKH1jZ1Gn1IqHXsQ40tL+rwtcQBJz2lTZ0D98heW40/K3DhalSUh9T5wELCZ2zWimSWG1HVmaO7ihUz+9OylysJ5IsNpg3IHtI6iTUFNB1p0VYrKgeq1kC2B5x8olAYkhpvw/4lBk8uz9zkfDhzaDGXNAJUHYwWOpK+thD5pwLKehRqb6NynxY7bK3s34zSO+Q7iYOLoHRnIexNVJ4I7Zhk1iWiobcKE/ytYaMbA3CmcbUuWPLvCjD0Ejz+EGwPWq0gjdXobhei25sSrBukHkMeaukjlovZrLxGJaKtMB3MhTkAkVMJKCcJF0O5ZxHAlgh11ZtdnQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqghu-0001cM-Ku for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2024 18:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Troy Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Sep 2024 22:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73285 X-GNU-PR-Package: emacs Original-Received: via spool by 73285-submit@debbugs.gnu.org id=B73285.17266121606115 (code B ref 73285); Tue, 17 Sep 2024 22:30:02 +0000 Original-Received: (at 73285) by debbugs.gnu.org; 17 Sep 2024 22:29:20 +0000 Original-Received: from localhost ([127.0.0.1]:56180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqghE-0001aY-CQ for submit@debbugs.gnu.org; Tue, 17 Sep 2024 18:29:20 -0400 Original-Received: from mail-ed1-f43.google.com ([209.85.208.43]:59785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqghC-0001aH-N2 for 73285@debbugs.gnu.org; Tue, 17 Sep 2024 18:29:19 -0400 Original-Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5c3d209db94so993328a12.3 for <73285@debbugs.gnu.org>; Tue, 17 Sep 2024 15:29:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726612137; x=1727216937; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=grsNqyFFx64pieg3J8ycBWuq8nNjNYHUaRGZt4f45Z8=; b=mmqilmeq/F6lixq5ydQ1ba3vrOK3z9HbY6QMthzy0wYy7SpN5KLNgJlIQDHZpbqq+N apsK1bYu+mHird/M33d078VBQDW9mgr4wxMNSxvC+cAskzOOp7kIuAc/U3sxQjv4kJOe qxJLilDJOHrl+6zJIGDwxG0jMWB001ebj193MHBhxCCwkzL3yTAN9KxkZGNxGpvp6f9e acGbDdoyZhTJuOTCifbDV1C6NURjy5CF30B3Bo4LgOEGEMH7d1h7PC7X+A1chR88G1eb IUnYuv17/TufISaNqPd2FbYoAPG3TlzgKbNBwyqn8odTPZzSbEE27P2aDjEadWtrGL73 NXJg== X-Forwarded-Encrypted: i=1; AJvYcCUImOVZc4Y4q/wLppBR8kWr1M7RymUsY5uxCnXS2odHMNFPye+4FNrnhEIrcxx2wbMGo1wH9w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyAznr91+1PCQxxPNfdS2xE3+9vlHQQONwpfMBJJYUfeV0XPD/R gstuxpVS3P1R4BDh9Vz7phEjstFhQ+ik6wr/y18Kr9SLhA3+RplkQe7Fk7KmtCY= X-Google-Smtp-Source: AGHT+IFKNoT/CTpetYwIfc5e4oW/LadtBEB0gWZWhHKH3CLSwCbLaqbRWL7eE/tgIt/0ypzV+9iBsw== X-Received: by 2002:a05:6402:274a:b0:5c3:d8fd:9a3b with SMTP id 4fb4d7f45d1cf-5c413e4d06cmr19625151a12.28.1726612136898; Tue, 17 Sep 2024 15:28:56 -0700 (PDT) Original-Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com. [209.85.208.50]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c42bb5312dsm4132200a12.23.2024.09.17.15.28.56 for <73285@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Sep 2024 15:28:56 -0700 (PDT) Original-Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5c25554ec1eso1196976a12.1 for <73285@debbugs.gnu.org>; Tue, 17 Sep 2024 15:28:56 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU7K2Nf6L/XHSxife4DdX7byR/oTbanjP+RHqTYhWESg/xrkvXREr7k8a4Grv4Bp7I5sGPlaw==@debbugs.gnu.org X-Received: by 2002:a05:6402:34d2:b0:5c4:2ffc:cc2 with SMTP id 4fb4d7f45d1cf-5c42ffc0ecemr9877836a12.13.1726612136037; Tue, 17 Sep 2024 15:28:56 -0700 (PDT) In-Reply-To: X-Gmail-Original-Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291978 Archived-At: On Tue, Sep 17, 2024 at 9:16=E2=80=AFAM Stefan Monnier wrote: > > >> Recently new modes were added to the EditorConfig on GitHub, but those > >> modes have not made their way into Emacs' EditorConfig implementation. > > The two code branches aren't in sync, indeed. I'll see if I can bring > our up-to-date with the upstream code ASAP. > > > The variable listing the modes is a defcustom, so users can update it > > themselves. We will never be able to be up-to-date with all the modes > > out there that are not part of Emacs. > > Indeed. For this reason the code in Emacs (not yet upstream) introduced > `editorconfig-indent-size-vars` which is supposed to be set by the major > modes themselves. > > So we should arguably change `ada/gpr(-ts)-mode` to set > `editorconfig-indent-size-vars`. > Ah, I was not aware of editorconfig-indent-size-vars. I can update the modes I maintain (ada-ts-mode, gpr-ts-mode) to use that instead. Looking at editorconfig--default-indent-size-function, it looks like if it also supported an "-ident" suffix, that would probably cover ada-mode and gpr-mode as well. Those modes are currently without a maintainer, so might be good to either add them to editorconfig-indentation-alist or to adjust the default function to support the "-indent" suffix.