From: Troy Brown <brownts@troybrown.dev>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>, 73285@debbugs.gnu.org
Subject: bug#73285: 30.0.90; editorconfig-indentation-alist missing modes
Date: Tue, 17 Sep 2024 18:28:44 -0400 [thread overview]
Message-ID: <CABvCZ40+mPj5GWxxWowa3bkpKvyMQFuNL8xvsGP555m-TnRkcg@mail.gmail.com> (raw)
In-Reply-To: <jwvmsk68lvq.fsf-monnier+emacs@gnu.org>
On Tue, Sep 17, 2024 at 9:16 AM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
> >> Recently new modes were added to the EditorConfig on GitHub, but those
> >> modes have not made their way into Emacs' EditorConfig implementation.
>
> The two code branches aren't in sync, indeed. I'll see if I can bring
> our up-to-date with the upstream code ASAP.
>
> > The variable listing the modes is a defcustom, so users can update it
> > themselves. We will never be able to be up-to-date with all the modes
> > out there that are not part of Emacs.
>
> Indeed. For this reason the code in Emacs (not yet upstream) introduced
> `editorconfig-indent-size-vars` which is supposed to be set by the major
> modes themselves.
>
> So we should arguably change `ada/gpr(-ts)-mode` to set
> `editorconfig-indent-size-vars`.
>
Ah, I was not aware of editorconfig-indent-size-vars. I can update
the modes I maintain (ada-ts-mode, gpr-ts-mode) to use that instead.
Looking at editorconfig--default-indent-size-function, it looks like
if it also supported an "-ident" suffix, that would probably cover
ada-mode and gpr-mode as well. Those modes are currently without a
maintainer, so might be good to either add them to
editorconfig-indentation-alist or to adjust the default function to
support the "-indent" suffix.
prev parent reply other threads:[~2024-09-17 22:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-15 21:16 bug#73285: 30.0.90; editorconfig-indentation-alist missing modes Troy Brown
2024-09-16 11:53 ` Eli Zaretskii
2024-09-17 13:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-17 22:28 ` Troy Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABvCZ40+mPj5GWxxWowa3bkpKvyMQFuNL8xvsGP555m-TnRkcg@mail.gmail.com \
--to=brownts@troybrown.dev \
--cc=73285@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).