From: "प्रद्युम्न परांजपे" <pradyparanjpe@gmail.com>
To: Robert Pluim <rpluim@gmail.com>
Cc: Jeremy Bryant <jb@jeremybryant.net>,
Justin Burkett <justin@burkett.cc>,
71718@debbugs.gnu.org
Subject: bug#71718: Unicode symbols to represent which key special keys, bug#71718: Unicode symbols to represent which key special keys
Date: Fri, 28 Jun 2024 11:43:58 +0530 [thread overview]
Message-ID: <CABt=8ObbJfR=s9xkk0x71T_7GzbpGMYh+HD=tOt+=P7RqS_jNQ@mail.gmail.com> (raw)
In-Reply-To: <87le2vbrug.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 4693 bytes --]
I am unaware of the protocol here.
I submitted the PR as a bug as advised by the owner of the repository on
github.
I agree with, and accept both suggestions (from Robert and Jeremy).
How do I proceed with including the suggestions?
I am afraid I, being ignorant, might end up opening multiple bug reports
messing up things.
So I am not actively doing anything right now.
Please guide me through.
N.B. You may correct them without my intervention if you can.
--
Prady
रवि, २३, जून २०२४ रोजी ८:५९ PM वाजता रोजी Robert Pluim नी <rpluim@gmail.com>
लिहिले:
> >>>>> On Sat, 22 Jun 2024 14:31:15 +0530, प्रद्युम्न परांजपे <
> pradyparanjpe@gmail.com> said:
>
>
> प्रद्युम्न> Unicode symbols to represent which key special keys
>
> 'which-key'
>
> प्रद्युम्न> * lisp/which-key.el (which-key-speical-keys):Use
> प्रद्युम्न> symbols to represent special keys. If value of
> प्रद्युम्न> ``which-key-special-keys`` is an *alist* of cons
> प्रद्युम्न> cells, whose cars are special keys such as SPC,
> प्रद्युम्न> TAB, ... and the cdrs are symbol strings, replace
> प्रद्युम्न> the special keys with corresponding symbols.
>
> प्रद्युम्न> For backward-compatibility, if
> प्रद्युम्न> ``which-key-special-keys`` is an ordinary list of
> प्रद्युम्न> keys, old logic of truncation to single character
> प्रद्युम्न> works.
>
> Quoting in commit messages is done 'like' 'this' for symbols such as
> variable and function names.
>
> Please put a reference to the bug number somewhere in the commit
> message, in the form (Bug#71718).
>
> प्रद्युम्न> :package-version "1.0" :version "30.1")
> प्रद्युम्न>
> प्रद्युम्न> (defcustom which-key-special-keys '()
> प्रद्युम्न>- "These keys will automatically be truncated to one
> character.
> प्रद्युम्न>+ "These keys will be truncated to first character or
> provided unicode symbol.
> प्रद्युम्न> They also have `which-key-special-key-face' applied to
> them. This
> प्रद्युम्न>-is disabled by default. An example configuration is
> प्रद्युम्न>-
> प्रद्युम्न>-\(setq which-key-special-keys \\='(\"SPC\" \"TAB\" \"RET\"
> \"ESC\" \"DEL\")\)"
> प्रद्युम्न>- :type '(repeat string)
> प्रद्युम्न>+is disabled by default. Example configurations are
> प्रद्युम्न>+
> प्रद्युम्न>+\(setq which-key-special-keys \\='(\"SPC\" \"TAB\" \"RET\"
> \"ESC\" \"DEL\")\) OR
> प्रद्युम्न>+
> प्रद्युम्न>+\(setq which-key-special-keys
> प्रद्युम्न>+ \\='((\"SPC\" . \"␣\")
> प्रद्युम्न>+ (\"TAB\" . \"↹\")
> प्रद्युम्न>+ (\"RET\" . \"⏎\")
> प्रद्युम्न>+ (\"ESC\" . \"⎋\")
> प्रद्युम्न>+ (\"DEL\" . \"⌦\")
> प्रद्युम्न>+ (\"backspace\" . \"⌫\"))\)"
> प्रद्युम्न>+ :type '(repeat (choice string cons))
> प्रद्युम्न> :package-version "1.0" :version "30.1")
> प्रद्युम्न>
>
> `defcustom' has an alist type you could perhaps use here, since with
> the current type it would be possible to create an improper alist.
>
> Please donʼt recommend `setq' in the docstrings for user
> options. Ideally youʼd offer preconfigured values for common setups
> for the user to select. That would also make it easier to select other
> replacement characters than the ones you mention.
>
> (Perhaps itʼs too late because of backwards compatibility, but the
> first value you describe above could be implemented using the form
> used by the second value:
>
> '(("SPC" . "S")
> ("TAB" . "T") etc
> )
>
> Robert
> --
>
--
प्रद्युम्न स्वानंद परांजपे
Pradyumna Swanand Paranjape
CSIR-SRF,
Centre for Cellular and Molecular Biology,
Hyderabad 500007
India
+91 9581261180
[-- Attachment #2: Type: text/html, Size: 7283 bytes --]
next prev parent reply other threads:[~2024-06-28 6:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 9:01 bug#71718: Unicode symbols to represent which key special keys प्रद्युम्न परांजपे
2024-06-22 18:17 ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-23 15:29 ` bug#71718: Unicode symbols to represent which key special keys, " Robert Pluim
2024-06-28 6:13 ` प्रद्युम्न परांजपे [this message]
2024-06-28 7:40 ` Robert Pluim
2024-06-28 17:59 ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABt=8ObbJfR=s9xkk0x71T_7GzbpGMYh+HD=tOt+=P7RqS_jNQ@mail.gmail.com' \
--to=pradyparanjpe@gmail.com \
--cc=71718@debbugs.gnu.org \
--cc=jb@jeremybryant.net \
--cc=justin@burkett.cc \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).