* bug#16576: Binding `standard-output' to a function doesn't work -- function sometimes called with garbage
@ 2014-01-28 9:09 Anders Lindgren
2014-01-28 15:59 ` Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Anders Lindgren @ 2014-01-28 9:09 UTC (permalink / raw)
To: 16576
[-- Attachment #1: Type: text/plain, Size: 9764 bytes --]
Hi!
When binding `standard-output' to a function, is seems as though the
function sometimes is called with garbage, like random control characters
or part of the string in "random" order.
I've seen this problem in Emacs 22 and Emacs 24.3. I haven't been able to
reproduce it on the Emacs trunk, but I've seen some problems (although less
frequent) that could be explained if the problem existed there as well.
Steps to repeat:
emacs -Q
Eval the following:
(defvar bug-bind-output-str nil)
(defun bug-bind-output-function (char)
(setq bug-bind-output-str
(concat bug-bind-output-str (list char))))
(defun bug-bind-output-test ()
(interactive)
(let ((bug-bind-output-str "")
(standard-output 'bug-bind-output-function)
(s
"(\\(co\\(?:mbine-after-change-calls\\|nd\\(?:ition-case\\(?:-unless-debug\\)?\\)?\\)\\|eval-\\(?:a\\(?:fter-load\\|nd-compile\\)\\|next-after-load\\|when\\(?:-compile\\)?\\)\\|i\\(?:f\\|nline\\)\\|l\\(?:ambda\\|et\\(?:\\*\\|rec\\)?\\)\\|p\\(?:case\\(?:-let\\*?\\)?\\|rog[*12nv]?\\)\\|save-\\(?:current-buffer\\|excursion\\|match-data\\|restriction\\|selected-window\\|window-excursion\\)\\|track-mouse\\|unwind-protect\\|w\\(?:hile\\(?:-no-input\\)?\\|ith-\\(?:c\\(?:a\\(?:\\(?:se\\|tegory\\)-table\\)\\|urrent-buffer\\)\\|demoted-errors\\|electric-help\\|local-quit\\|no-warnings\\|output-to-\\(?:string\\|temp-buffer\\)\\|s\\(?:elected-\\(?:frame\\|window\\)\\|ilent-modifications\\|yntax-table\\)\\|t\\(?:emp-\\(?:buffer\\|\\(?:fil\\|messag\\)e\\)\\|imeout\\(?:-handler\\)?\\)\\|wrapper-hook\\)\\)\\)\\>")
s0)
(prin1 s)
bug-bind-output-str))
Type this a number of times:
M-x (bug-bind-output-test) RET
A correct output looks like:
"\"(\\\\(co\\\\(?:mbine-after-change-calls\\\\|nd\\\\(?:ition-case\\\\(?:-unless-debug\\\\)?\\\\)?\\\\)\\\\|eval-\\\\(?:a\\\\(?:fter-load\\\\|nd-compile\\\\)\\\\|next-after-load\\\\|when\\\\(?:-compile\\\\)?\\\\)\\\\|i\\\\(?:f\\\\|nline\\\\)\\\\|l\\\\(?:ambda\\\\|et\\\\(?:\\\\*\\\\|rec\\\\)?\\\\)\\\\|p\\\\(?:case\\\\(?:-let\\\\*?\\\\)?\\\\|rog[*12nv]?\\\\)\\\\|save-\\\\(?:current-buffer\\\\|excursion\\\\|match-data\\\\|restriction\\\\|selected-window\\\\|window-excursion\\\\)\\\\|track-mouse\\\\|unwind-protect\\\\|w\\\\(?:hile\\\\(?:-no-input\\\\)?\\\\|ith-\\\\(?:c\\\\(?:a\\\\(?:\\\\(?:se\\\\|tegory\\\\)-table\\\\)\\\\|urrent-buffer\\\\)\\\\|demoted-errors\\\\|electric-help\\\\|local-quit\\\\|no-warnings\\\\|output-to-\\\\(?:string\\\\|temp-buffer\\\\)\\\\|s\\\\(?:elected-\\\\(?:frame\\\\|window\\\\)\\\\|ilent-modifications\\\\|yntax-table\\\\)\\\\|t\\\\(?:emp-\\\\(?:buffer\\\\|\\\\(?:fil\\\\|messag\\\\)e\\\\)\\\\|imeout\\\\(?:-handler\\\\)?\\\\)\\\\|wrapper-hook\\\\)\\\\)\\\\)\\\\>\""
This is an example of bad output, here, the last couple of lines does not
correspond to the string being printed.
"\"(\\\\(co\\\\(?:mbine-after-change-calls\\\\|nd\\\\(?:ition-case\\\\(?:-unless-debug\\\\)?\\\\)?\\\\)\\\\|eval-\\\\(?:a\\\\(?:fter-load\\\\|nd-compile\\\\)\\\\|next-after-load\\\\|when\\\\(?:-compile\\\\)?\\\\)\\\\|i\\\\(?:f\\\\|nline\\\\)\\\\|l\\\\(?:ambda\\\\|et\\\\(?:\\\\*\\\\|rec\\\\)?\\\\)\\\\|p\\\\(?:case\\\\(?:-let\\\\*?\\\\)?\\\\|rog[*12nv]?\\\\)\\\\|save-\\\\(?:current-buffer\\\\|excursion\\\\|match-data\\\\|restriction\\\\|selected-window\\\\|window-excursion\\\\)\\\\|track-mouse\\\\|unwind-protect\\\\|w\\\\(?:hile\\\\(?:-no-input\\\\)?\\\\|ith-\\\\(?:c\\\\(?:a\\\\(?:\\\\(?:se\\\\|tegory\\\\\\\\(?:-no-input\\\\\\\\)?\\\\\\\\|ith-\\\\\\\\(?:c\\\\\\\\(?:a\\\\\\\\(?:\\\\\\\\(?:se\\\\\\\\|tegory\\\\loca\x10\x17w\x01\\\"(\\\\\\\\(co\\\\\\\\(?:mbine-after-change-calls\\\\\\\\|nd\\\\\\\\(?:ition-case\\\\\\\\(?:-unless-debug\\\\\\\\)?\\\\\\\\)?\\\\\\\\)\\\\\\\\|eval-\\\\\\\\(?:a\\\\\\\\(?:fter-load\\\\\\\\|nd-compile\\\\\\\\)\\\\\\\\|next-after-load\\\\\\\\|when\\\\\\\\(?:-compile\\\\\\\\)?\\\\\\\\)\\\\\\\\|i\\\\\\\\(?:f\\\\\\\\|nline\\\\\\\\)\\\\\\\\|l\\\\\\\\(?:ambd\""
Other examples of bad output is if the string contains random control
characters.
I've noticed that this is intermittent. Sometimes, say, every tenth call
returns a broken string. Sometimes it feels as though you can call the
function any number of times without getting a bad string.
Sincerely,
Anders Lindgren
If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
`bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/Applications/Emacs24.3.app/Contents/Resources/etc/DEBUG.
In GNU Emacs 24.3.1 (x86_64-apple-darwin, NS apple-appkit-1038.36)
of 2013-03-13 on bob.porkrind.org
Windowing system distributor `Apple', version 10.3.1265
Configured using:
`configure '--host=x86_64-apple-darwin' '--build=i686-apple-darwin'
'--with-ns' 'build_alias=i686-apple-darwin'
'host_alias=x86_64-apple-darwin' 'CC=gcc -mmacosx-version-min=10.7
-isystem
/Users/david/Xcode-10.7_4.5.2/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.7.sdk/usr/include/
-F/Users/david/Xcode-10.7_4.5.2/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.7.sdk/System/Library/Frameworks''
Important settings:
value of $LC_CTYPE: UTF-8
locale-coding-system: utf-8-unix
default enable-multibyte-characters: t
Major mode: Emacs-Lisp
Minor modes in effect:
tooltip-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Recent input:
<down> <right> <right> <escape> C-x <down> <down> <down>
<escape> C-x <down> <down> <down> <down> <down> <down>
<escape> C-x <escape> : ( b i g <backspace> <backspace>
u g - b i <tab> t <tab> ) <return> <escape> : <up>
<return> <escape> : <up> <return> <escape> : <up> <return>
<escape> : <up> <return> <escape> : <up> <return> <escape>
: <up> <return> <escape> : <up> <return> <escape> :
<up> <return> <escape> : <up> <return> <escape> : <up>
<return> <escape> : <up> <return> <escape> x e m a
c s - b u <tab> C-g <escape> x m <backspace> e m a
c s - b i <backspace> u g <tab> <s-backspace> <s-backspace>
<escape> <backspace> <escape> <backspace> <escape>
C-g r e p o r t - e m <tab> <return>
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Loading vc-svn...done
bug-bind-output-str
bug-bind-output-function
bug-bind-output-test
"\"(\\\\(co\\\\(?:mbine-after-change-calls\\\\|nd\\\\(?:ition-case\\\\(?:-unless-debug\\\\)?\\\\)?\\\\)\\\\|eval-\\\\(?:a\\\\(?:fter-load\\\\|nd-compile\\\\)\\\\|next-after-load\\\\|when\\\\(?:-compile\\\\)?\\\\)\\\\|i\\\\(?:f\\\\|nline\\\\)\\\\|l\\\\(?:ambda\\\\|et\\\\(?:\\\\*\\\\|rec\\\\)?\\\\)\\\\|p\\\\(?:case\\\\(?:-let\\\\*?\\\\)?\\\\|rog[*12nv]?\\\\)\\\\|save-\\\\(?:current-buffer\\\\|excursion\\\\|match-data\\\\|restriction\\\\|selected-window\\\\|window-excursion\\\\)\\\\|track-mouse\\\\|unwind-protect\\\\|w\\\\(?:hile\\\\(?:-no-input\\\\)?\\\\|ith-\\\\(?:c\\\\(?:a\\\\(?:\\\\(?:se\\\\|tegory\\\\)-table\\\\)\\\\|urrent-buffer\\\\)\\\\|demoted-errors\\\\|electric-help\\\\|local-quit\\\\|no-warnings\\\\|output-to-\\\\(?:string\\\\|temp-buffer\\\\)\\\\|s\\\\(?:elected-\\\\(?:frame\\\\|window\\\\)\\\\|ilent-modifications\\\\|yntax-table\\\\)\\\\|t\\\\(?:emp-\\\\(?:buffer\\\\|\\\\(?:fil\\\\|messag\\\\)e\\\\)\\\\|imeout\\\\(?:-handler\\\\)?\\\\)\\\\|wrapper-hook\\\\)\\\\)\\\\)\\\\>\""
[11 times]
"\"(\\\\(co\\\\(?:mbine-after-change-calls\\\\|nd\\\\(?:ition-case\\\\(?:-unless-debug\\\\)?\\\\)?\\\\)\\\\|eval-\\\\(?:a\\\\(?:fter-load\\\\|nd-compile\\\\)\\\\|next-after-load\\\\|when\\\\(?:-compile\\\\)?\\\\)\\\\|i\\\\(?:f\\\\|nline\\\\)\\\\|l\\\\(?:ambda\\\\|et\\\\(?:\\\\*\\\\|rec\\\\)?\\\\)\\\\|p\\\\(?:case\\\\(?:-let\\\\*?\\\\)?\\\\|rog[*12nv]?\\\\)\\\\|save-\\\\(?:current-buffer\\\\|excursion\\\\|match-data\\\\|restriction\\\\|selected-window\\\\|window-excursion\\\\)\\\\|track-mouse\\\\|unwind-protect\\\\|w\\\\(?:hile\\\\(?:-no-input\\\\)?\\\\|ith-\\\\(?:c\\\\(?:a\\\\(?:\\\\(?:se\\\\|tegory\\\\\\\\(?:-no-input\\\\\\\\)?\\\\\\\\|ith-\\\\\\\\(?:c\\\\\\\\(?:a\\\\\\\\(?:\\\\\\\\(?:se\\\\\\\\|tegory\\\\loca\x10\x17w\x01\\\"(\\\\\\\\(co\\\\\\\\(?:mbine-after-change-calls\\\\\\\\|nd\\\\\\\\(?:ition-case\\\\\\\\(?:-unless-debug\\\\\\\\)?\\\\\\\\)?\\\\\\\\)\\\\\\\\|eval-\\\\\\\\(?:a\\\\\\\\(?:fter-load\\\\\\\\|nd-compile\\\\\\\\)\\\\\\\\|next-after-load\\\\\\\\|when\\\\\\\\(?:-compile\\\\\\\\)?\\\\\\\\)\\\\\\\\|i\\\\\\\\(?:f\\\\\\\\|nline\\\\\\\\)\\\\\\\\|l\\\\\\\\(?:ambd\""
Quit
Load-path shadows:
None found.
Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils vc-dispatcher vc-svn time-date tooltip
ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset
image regexp-opt fringe tabulated-list newcomment lisp-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process ns multi-tty emacs)
[-- Attachment #2: Type: text/html, Size: 11843 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* bug#16576: Binding `standard-output' to a function doesn't work -- function sometimes called with garbage
2014-01-28 9:09 bug#16576: Binding `standard-output' to a function doesn't work -- function sometimes called with garbage Anders Lindgren
@ 2014-01-28 15:59 ` Eli Zaretskii
2014-01-28 19:39 ` Anders Lindgren
0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2014-01-28 15:59 UTC (permalink / raw)
To: Anders Lindgren; +Cc: 16576
> Date: Tue, 28 Jan 2014 10:09:08 +0100
> From: Anders Lindgren <andlind@gmail.com>
>
> emacs -Q
> Eval the following:
>
> (defvar bug-bind-output-str nil)
>
> (defun bug-bind-output-function (char)
> (setq bug-bind-output-str
> (concat bug-bind-output-str (list char))))
>
> (defun bug-bind-output-test ()
> (interactive)
> (let ((bug-bind-output-str "")
> (standard-output 'bug-bind-output-function)
> (s
> "(\\(co\\(?:mbine-after-change-calls\\|nd\\(?:ition-case\\(?:-unless-debug\\)?\\)?\\)\\|eval-\\(?:a\\(?:fter-load\\|nd-compile\\)\\|next-after-load\\|when\\(?:-compile\\)?\\)\\|i\\(?:f\\|nline\\)\\|l\\(?:ambda\\|et\\(?:\\*\\|rec\\)?\\)\\|p\\(?:case\\(?:-let\\*?\\)?\\|rog[*12nv]?\\)\\|save-\\(?:current-buffer\\|excursion\\|match-data\\|restriction\\|selected-window\\|window-excursion\\)\\|track-mouse\\|unwind-protect\\|w\\(?:hile\\(?:-no-input\\)?\\|ith-\\(?:c\\(?:a\\(?:\\(?:se\\|tegory\\)-table\\)\\|urrent-buffer\\)\\|demoted-errors\\|electric-help\\|local-quit\\|no-warnings\\|output-to-\\(?:string\\|temp-buffer\\)\\|s\\(?:elected-\\(?:frame\\|window\\)\\|ilent-modifications\\|yntax-table\\)\\|t\\(?:emp-\\(?:buffer\\|\\(?:fil\\|messag\\)e\\)\\|imeout\\(?:-handler\\)?\\)\\|wrapper-hook\\)
\\)\\)\\>")
> s0)
> (prin1 s)
> bug-bind-output-str))
>
> Type this a number of times:
>
> M-x (bug-bind-output-test) RET
I think there's a bug in your test program. You let-bind
bug-bind-output-str, and print that local binding after you call
prin1. But your print function concatenates each character onto the
_global_ binding of bug-bind-output-str, so the result is not in your
local binding, it's in the global one.
If you change your program like this:
(defun bug-bind-output-test ()
(interactive)
(setq bug-bind-output-str "")
(let ((standard-output 'bug-bind-output-function)
(s
"(\\(co\\(?:mbine-after-change-calls\\|nd\\(?:ition-case\\(?:-unless-debug\\)?\\)?\\)\\|eval-\\(?:a\\(?:fter-load\\|nd-compile\\)\\|next-after-load\\|when\\(?:-compile\\)?\\)\\|i\\(?:f\\|nline\\)\\|l\\(?:ambda\\|et\\(?:\\*\\|rec\\)?\\)\\|p\\(?:case\\(?:-let\\*?\\)?\\|rog[*12nv]?\\)\\|save-\\(?:current-buffer\\|excursion\\|match-data\\|restriction\\|selected-window\\|window-excursion\\)\\|track-mouse\\|unwind-protect\\|w\\(?:hile\\(?:-no-input\\)?\\|ith-\\(?:c\\(?:a\\(?:\\(?:se\\|tegory\\)-table\\)\\|urrent-buffer\\)\\|demoted-errors\\|electric-help\\|local-quit\\|no-warnings\\|output-to-\\(?:string\\|temp-buffer\\)\\|s\\(?:elected-\\(?:frame\\|window\\)\\|ilent-modifications\\|yntax-table\\)\\|t\\(?:emp-\\(?:buffer\\|\\(?:fil\\|messag\\)e\\)\\|imeout\\(?:-handler\\)?\\)\\|wrapper-hook\\)
\\)\\)\\>")
s0)
(prin1 s)
bug-bind-output-str))
i.e., work with the global binding, then the program works as
expected, AFAICS.
^ permalink raw reply [flat|nested] 10+ messages in thread* bug#16576: Binding `standard-output' to a function doesn't work -- function sometimes called with garbage
2014-01-28 15:59 ` Eli Zaretskii
@ 2014-01-28 19:39 ` Anders Lindgren
2014-01-28 20:25 ` Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Anders Lindgren @ 2014-01-28 19:39 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 16576
[-- Attachment #1: Type: text/plain, Size: 4704 bytes --]
Hi!
I got the same result with your version. After running it 24 times, I got
the following output (on Emacs 22) -- please note the extra text and
control characters towards the end of the string (which I have changed to
the \xNN syntax, in order not to confuse the mail program).
"\"(\\\\(co\\\\(?:mbine-after-change-calls\\\\|nd\\\\(?:ition-case\\\\(?:-unless-debug\\\\)?\\\\)?\\\\)\\\\|eval-\\\\(?:a\\\\(?:fter-load\\\\|nd-compile\\\\)\\\\|next-after-load\\\\|when\\\\(?:-compile\\\\)?\\\\)\\\\\\\\|p\\\\(?:case\\\\(?:-let\\\\*?\\\\)?\\\\|rog[*12nv]?\\\\)\\\\|save-\\\\(?:current-buffer\\\\|excursion\\\\|match-data\\\\|restriction\\\\|selected-window\\\\|window-excursion\\\\)\\\\|track-mouse\\\\|unwind-protect\\\\|w\\\\(?:hile\\\\(?:-no-input\\\\)?\\\\|ith-\\\\(?:c\\\\(?:a\\\\(?:\\\\(?:se\\\\|tegory\\\\)-table\\\\)\\\\|urrent-buffer\\\\)\\\\|demoted-errors\\\\|electric-help\\\\|local-quit\\\\|no-warnings\\\\|output-to-\\\\(?:string\\\\|temp-buffer\\\\)\\\\|s\\\\(?:elected-\\\\(?:frame\\\\|window\\\\)\\\\|ilent-modifications\\\\|yntax-table\\\\)\\\\|t\\\\(?:emp-\\\\(?:buffer\\\\|\\\\(?:fil\\\\|messag\\\\)e\\\\)\\\\|imeout\\\\(?:-handler\\\\)?\\\\)\\\\|wrapper-hook\\\\)\\\\)\\\\)\\\\>\x00cs/
\xdc\xac\x06\\\"(\\\\\\\\(co\\\\\\\\(?:mbine-after-change-calls\\\\\\\\|n\""
When it comes to the original program, I believe that it's correct. The
function bound to `standard-output' is called from within `prin1', which is
called from inside the scope of `let'. Hence, it will work on the local
version of the variable. (If it wouldn't have been correct -- why would it
return the correct value *most* of the time?)
-- Anders
On Tue, Jan 28, 2014 at 4:59 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > Date: Tue, 28 Jan 2014 10:09:08 +0100
> > From: Anders Lindgren <andlind@gmail.com>
> >
> > emacs -Q
> > Eval the following:
> >
> > (defvar bug-bind-output-str nil)
> >
> > (defun bug-bind-output-function (char)
> > (setq bug-bind-output-str
> > (concat bug-bind-output-str (list char))))
> >
> > (defun bug-bind-output-test ()
> > (interactive)
> > (let ((bug-bind-output-str "")
> > (standard-output 'bug-bind-output-function)
> > (s
> >
> "(\\(co\\(?:mbine-after-change-calls\\|nd\\(?:ition-case\\(?:-unless-debug\\)?\\)?\\)\\|eval-\\(?:a\\(?:fter-load\\|nd-compile\\)\\|next-after-load\\|when\\(?:-compile\\)?\\)\\|i\\(?:f\\|nline\\)\\|l\\(?:ambda\\|et\\(?:\\*\\|rec\\)?\\)\\|p\\(?:case\\(?:-let\\*?\\)?\\|rog[*12nv]?\\)\\|save-\\(?:current-buffer\\|excursion\\|match-data\\|restriction\\|selected-window\\|window-excursion\\)\\|track-mouse\\|unwind-protect\\|w\\(?:hile\\(?:-no-input\\)?\\|ith-\\(?:c\\(?:a\\(?:\\(?:se\\|tegory\\)-table\\)\\|urrent-buffer\\)\\|demoted-errors\\|electric-help\\|local-quit\\|no-warnings\\|output-to-\\(?:string\\|temp-buffer\\)\\|s\\(?:elected-\\(?:frame\\|window\\)\\|ilent-modifications\\|yntax-table\\)\\|t\\(?:emp-\\(?:buffer\\|\\(?:fil\\|messag\\)e\\)\\|imeout\\(?:-handler\\)?\\)\\|wrapper-hook\\)\\)\\)\\>")
> > s0)
> > (prin1 s)
> > bug-bind-output-str))
> >
> > Type this a number of times:
> >
> > M-x (bug-bind-output-test) RET
>
> I think there's a bug in your test program. You let-bind
> bug-bind-output-str, and print that local binding after you call
> prin1. But your print function concatenates each character onto the
> _global_ binding of bug-bind-output-str, so the result is not in your
> local binding, it's in the global one.
>
> If you change your program like this:
>
> (defun bug-bind-output-test ()
> (interactive)
> (setq bug-bind-output-str "")
> (let ((standard-output 'bug-bind-output-function)
> (s
>
> "(\\(co\\(?:mbine-after-change-calls\\|nd\\(?:ition-case\\(?:-unless-debug\\)?\\)?\\)\\|eval-\\(?:a\\(?:fter-load\\|nd-compile\\)\\|next-after-load\\|when\\(?:-compile\\)?\\)\\|i\\(?:f\\|nline\\)\\|l\\(?:ambda\\|et\\(?:\\*\\|rec\\)?\\)\\|p\\(?:case\\(?:-let\\*?\\)?\\|rog[*12nv]?\\)\\|save-\\(?:current-buffer\\|excursion\\|match-data\\|restriction\\|selected-window\\|window-excursion\\)\\|track-mouse\\|unwind-protect\\|w\\(?:hile\\(?:-no-input\\)?\\|ith-\\(?:c\\(?:a\\(?:\\(?:se\\|tegory\\)-table\\)\\|urrent-buffer\\)\\|demoted-errors\\|electric-help\\|local-quit\\|no-warnings\\|output-to-\\(?:string\\|temp-buffer\\)\\|s\\(?:elected-\\(?:frame\\|window\\)\\|ilent-modifications\\|yntax-table\\)\\|t\\(?:emp-\\(?:buffer\\|\\(?:fil\\|messag\\)e\\)\\|imeout\\(?:-handler\\)?\\)\\|wrapper-hook\\)\\)\\)\\>")
> s0)
> (prin1 s)
> bug-bind-output-str))
>
> i.e., work with the global binding, then the program works as
> expected, AFAICS.
>
[-- Attachment #2: Type: text/html, Size: 5404 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* bug#16576: Binding `standard-output' to a function doesn't work -- function sometimes called with garbage
2014-01-28 19:39 ` Anders Lindgren
@ 2014-01-28 20:25 ` Eli Zaretskii
2014-01-28 22:00 ` Anders Lindgren
0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2014-01-28 20:25 UTC (permalink / raw)
To: Anders Lindgren; +Cc: 16576
> Date: Tue, 28 Jan 2014 20:39:57 +0100
> From: Anders Lindgren <andlind@gmail.com>
> Cc: 16576@debbugs.gnu.org
>
> If it wouldn't have been correct -- why would it return the correct
> value *most* of the time?
Because strings are relocated from time to time, I think.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#16576: Binding `standard-output' to a function doesn't work -- function sometimes called with garbage
2014-01-28 20:25 ` Eli Zaretskii
@ 2014-01-28 22:00 ` Anders Lindgren
2014-01-29 18:01 ` Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Anders Lindgren @ 2014-01-28 22:00 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 16576
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
Hi!
> If it wouldn't have been correct -- why would it return the correct
> > value *most* of the time?
>
> Because strings are relocated from time to time, I think.
>
Well, the main issue here is if this is a real bug or not. You originally
thought this was simply a mistake in the example I provided -- do you still
think so?
-- Anders
[-- Attachment #2: Type: text/html, Size: 662 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* bug#16576: Binding `standard-output' to a function doesn't work -- function sometimes called with garbage
2014-01-28 22:00 ` Anders Lindgren
@ 2014-01-29 18:01 ` Eli Zaretskii
2014-01-29 21:12 ` Anders Lindgren
0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2014-01-29 18:01 UTC (permalink / raw)
To: Anders Lindgren; +Cc: 16576-done
> Date: Tue, 28 Jan 2014 23:00:32 +0100
> From: Anders Lindgren <andlind@gmail.com>
> Cc: 16576@debbugs.gnu.org
>
> Well, the main issue here is if this is a real bug or not. You originally
> thought this was simply a mistake in the example I provided -- do you still
> think so?
There was indeed a bug, now fixed on the trunk, which caused the
problem. It was a very old bug, it went unnoticed until now because,
I guess, no one conses a string one character at a time -- this is a
terrible idea in Emacs Lisp. Use a temporary buffer instead.
There was nothing wrong with prin1 per se, btw, it's just that its
subroutine which prints a string wasn't safe when GC hit in the middle
of a prin1 call. The code protected the string from GC, but that
doesn't preclude relocation of string data, so holding to C 'char *'
pointers is not safe in these situations. And printing a
800-character string like you did triggers GC every time, because it
creates 800 string objects for a grand total of about 320000 bytes.
Anyway, problem solved, and I'm closing the bug. Thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#16576: Binding `standard-output' to a function doesn't work -- function sometimes called with garbage
2014-01-29 18:01 ` Eli Zaretskii
@ 2014-01-29 21:12 ` Anders Lindgren
2014-01-30 0:38 ` Stefan Monnier
0 siblings, 1 reply; 10+ messages in thread
From: Anders Lindgren @ 2014-01-29 21:12 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 16576-done
[-- Attachment #1: Type: text/plain, Size: 1743 bytes --]
Thanks for fixing the bug!
As soon as I realised that there was a problem with binding
`standard-output' to a function, I rewrote the code to use a buffer
instead. Also, thanks for pointing out the excessive memory usage when
accumulating a string -- one can learn something new every day (even after
20 years)...
-- Anders
Ps. I just released the package I've been working in for a couple of weeks,
it's an interactive debugger for font-lock keywords. If you want to try it
you can get it from https://github.com/Lindydancer/font-lock-studio
On Wed, Jan 29, 2014 at 7:01 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > Date: Tue, 28 Jan 2014 23:00:32 +0100
> > From: Anders Lindgren <andlind@gmail.com>
> > Cc: 16576@debbugs.gnu.org
> >
> > Well, the main issue here is if this is a real bug or not. You originally
> > thought this was simply a mistake in the example I provided -- do you
> still
> > think so?
>
> There was indeed a bug, now fixed on the trunk, which caused the
> problem. It was a very old bug, it went unnoticed until now because,
> I guess, no one conses a string one character at a time -- this is a
> terrible idea in Emacs Lisp. Use a temporary buffer instead.
>
> There was nothing wrong with prin1 per se, btw, it's just that its
> subroutine which prints a string wasn't safe when GC hit in the middle
> of a prin1 call. The code protected the string from GC, but that
> doesn't preclude relocation of string data, so holding to C 'char *'
> pointers is not safe in these situations. And printing a
> 800-character string like you did triggers GC every time, because it
> creates 800 string objects for a grand total of about 320000 bytes.
>
> Anyway, problem solved, and I'm closing the bug. Thanks.
>
[-- Attachment #2: Type: text/html, Size: 2441 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* bug#16576: Binding `standard-output' to a function doesn't work -- function sometimes called with garbage
2014-01-29 21:12 ` Anders Lindgren
@ 2014-01-30 0:38 ` Stefan Monnier
2014-01-31 16:20 ` Anders Lindgren
0 siblings, 1 reply; 10+ messages in thread
From: Stefan Monnier @ 2014-01-30 0:38 UTC (permalink / raw)
To: Anders Lindgren; +Cc: 16576-done
> Ps. I just released the package I've been working in for a couple of weeks,
> it's an interactive debugger for font-lock keywords. If you want to try it
> you can get it from https://github.com/Lindydancer/font-lock-studio
What do you think about moving it to GNU ELPA?
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread* bug#16576: Binding `standard-output' to a function doesn't work -- function sometimes called with garbage
2014-01-30 0:38 ` Stefan Monnier
@ 2014-01-31 16:20 ` Anders Lindgren
2014-01-31 21:04 ` Stefan Monnier
0 siblings, 1 reply; 10+ messages in thread
From: Anders Lindgren @ 2014-01-31 16:20 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 16576-done
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
I haven't given it much though, to be honest, but it sounds like a good
idea. I would like it to have some more mileage first, though.
-- Anders
On Thu, Jan 30, 2014 at 1:38 AM, Stefan Monnier <monnier@iro.umontreal.ca>wrote:
> > Ps. I just released the package I've been working in for a couple of
> weeks,
> > it's an interactive debugger for font-lock keywords. If you want to try
> it
> > you can get it from https://github.com/Lindydancer/font-lock-studio
>
> What do you think about moving it to GNU ELPA?
>
>
> Stefan
>
[-- Attachment #2: Type: text/html, Size: 1122 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-01-31 21:04 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-28 9:09 bug#16576: Binding `standard-output' to a function doesn't work -- function sometimes called with garbage Anders Lindgren
2014-01-28 15:59 ` Eli Zaretskii
2014-01-28 19:39 ` Anders Lindgren
2014-01-28 20:25 ` Eli Zaretskii
2014-01-28 22:00 ` Anders Lindgren
2014-01-29 18:01 ` Eli Zaretskii
2014-01-29 21:12 ` Anders Lindgren
2014-01-30 0:38 ` Stefan Monnier
2014-01-31 16:20 ` Anders Lindgren
2014-01-31 21:04 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).