From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#21428: 24.5; Crash of emacs on OS X, installed via homebrew cask Date: Thu, 22 Oct 2015 22:04:08 +0200 Message-ID: References: <83k2r8b4rr.fsf@gnu.org> <834mibbstw.fsf@gnu.org> <83k2r79bi5.fsf@gnu.org> <834mi4x7tp.fsf@gnu.org> <83fv1mellz.fsf@gnu.org> <1130CA27-B8B0-4009-BC14-A3FC76B92216@gmail.com> <838u7265sv.fsf@gnu.org> <83pp0d4rot.fsf@gnu.org> <83611yucx0.fsf@gnu.org> <831tcmu944.fsf@gnu.org> <56291DB4.3040509@gmx.at> <83y4eusswr.fsf@gnu.org> <56292795.3050100@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113ee5c0778bd00522b6ffdd X-Trace: ger.gmane.org 1445544322 25058 80.91.229.3 (22 Oct 2015 20:05:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 22 Oct 2015 20:05:22 +0000 (UTC) Cc: Rainer@krugs.de, 21428@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 22 22:05:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZpM6q-0008Dd-K2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Oct 2015 22:05:12 +0200 Original-Received: from localhost ([::1]:34201 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpM6p-0000Hs-Ky for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Oct 2015 16:05:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpM6m-0000Fy-2E for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2015 16:05:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpM6h-0006UB-SI for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2015 16:05:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpM6h-0006Tu-Ga for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2015 16:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZpM6g-0000Q4-Vj for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2015 16:05:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Oct 2015 20:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 21428-submit@debbugs.gnu.org id=B21428.14455442531483 (code B ref 21428); Thu, 22 Oct 2015 20:05:02 +0000 Original-Received: (at 21428) by debbugs.gnu.org; 22 Oct 2015 20:04:13 +0000 Original-Received: from localhost ([127.0.0.1]:33238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpM5s-0000No-8C for submit@debbugs.gnu.org; Thu, 22 Oct 2015 16:04:12 -0400 Original-Received: from mail-vk0-f47.google.com ([209.85.213.47]:35280) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpM5p-0000Nd-NP for 21428@debbugs.gnu.org; Thu, 22 Oct 2015 16:04:10 -0400 Original-Received: by vkfw189 with SMTP id w189so52881824vkf.2 for <21428@debbugs.gnu.org>; Thu, 22 Oct 2015 13:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=8tTAUmkiv4XdUOzdlL37LbnnwUV1musfPo6KUOXazeA=; b=mBBYykD3V1DuQGerGhgTf+iohwsTuY/BS6zXXMW1qZFx8UagISbk5MvA4TIxF/1lFM 6X62m6qVMKgS0aNOYTexKk0iVrIRcQjruZgrp9Zn2VzhDY/hKZjNgy4vM9nCI2QJFjhp jgwMRWyqzWOjS3UD68WJCGAqYZmsld59aoAh0k47fhCxRBmz2RGeNzst8e53BP83+OGh BITZTXv4VZUV33cad2AZgFZ9IKxabeQnNJsW9bODobVK3YMq3Sq5dSn0i+qG1olr7NxD HZpTyaAelOUdPagwvOIhWpBsOK6o0FE/4Yv+bTSKufMe31sjRxCq/asEQDPAOPWlZ7k2 5chA== X-Received: by 10.31.41.8 with SMTP id p8mr10562333vkp.149.1445544248967; Thu, 22 Oct 2015 13:04:08 -0700 (PDT) Original-Received: by 10.31.210.133 with HTTP; Thu, 22 Oct 2015 13:04:08 -0700 (PDT) In-Reply-To: <56292795.3050100@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107867 Archived-At: --001a113ee5c0778bd00522b6ffdd Content-Type: text/plain; charset=UTF-8 Hi, I doubt that my modification will change anything related to this. However, I noticed that a number of NextStep callback functions start with the following code sequence: if (!emacsframe->output_data.ns) return; If `ns' is NULL it would account for the crash. I don't see why we can't add it to the windowDidResize: method as well. Finally a reservation, I'm still learning the NS code base and I don't know under which circumstances the `ns' field is NULL. -- Anders On Thu, Oct 22, 2015 at 8:14 PM, martin rudalics wrote: > > > extra = FRAME_NS_TITLEBAR_HEIGHT (emacsframe) > > + FRAME_TOOLBAR_HEIGHT (emacsframe); > > Ahh, so this is Emacs 25. Strange. Rainer what do > > p emacsframe->output_data.ns->titlebar_height > > and > > p emacsframe->output_data.ns->toolbar_height > > give in frame#0 of the debugger? > > martin --001a113ee5c0778bd00522b6ffdd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

I doubt that my modification will change anythi= ng related to this.

However, I noticed that a number of NextStep cal= lback functions start with the following code sequence:

=C2=A0 if (!= emacsframe->output_data.ns)
=C2=A0 =C2=A0 return;

If `ns' = is NULL it would account for the crash. I don't see why we can't ad= d it to the windowDidResize: method as well.

Finally a r= eservation, I'm still learning the NS code base and I don't know un= der which circumstances the `ns' field is NULL.

=C2=A0 =C2=A0 -- Anders



On Thu, Oct 22, 2015 at 8:1= 4 PM, martin rudalics <rudalics@gmx.a= t> wrote:
>
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0extra =3D = FRAME_NS_TITLEBAR_HEIGHT (emacsframe)
> > =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0+ FRAME_TOOLBAR_HEIGHT (emacsframe);
>
> Ahh, so this= is Emacs 25.=C2=A0 Strange.=C2=A0 Rainer what do
>
> p emacsfr= ame->output_data.ns->titlebar_height
>
> and
>
&= gt; p emacsframe->output_data.ns->toolbar_height
>
> give= in frame#0 of the debugger?
>
> martin
--001a113ee5c0778bd00522b6ffdd--