From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#23462: [PATCH] Block input while minimizing on NS (bug#23462) Date: Mon, 16 May 2016 20:45:12 +0200 Message-ID: References: <20160512115243.GA53583@breton.holly.idiocy.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114e1ff450350a0532fa06ca X-Trace: ger.gmane.org 1463424389 29026 80.91.229.3 (16 May 2016 18:46:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 May 2016 18:46:29 +0000 (UTC) Cc: 23462-done@debbugs.gnu.org, Alan Third To: Ivan Cibrario Bertolotti Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 16 20:46:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b2NWt-0006YU-Cf for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 May 2016 20:46:11 +0200 Original-Received: from localhost ([::1]:46651 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2NWs-0001zv-SZ for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 May 2016 14:46:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2NWo-0001uQ-Qz for bug-gnu-emacs@gnu.org; Mon, 16 May 2016 14:46:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2NWk-0001hl-Fl for bug-gnu-emacs@gnu.org; Mon, 16 May 2016 14:46:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2NWk-0001hg-CI for bug-gnu-emacs@gnu.org; Mon, 16 May 2016 14:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b2NWk-00051L-8O for bug-gnu-emacs@gnu.org; Mon, 16 May 2016 14:46:02 -0400 Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 May 2016 18:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 23462 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 23462@debbugs.gnu.org, andlind@gmail.com, ivan.cibrario@polito.it Original-Received: via spool by 23462-done@debbugs.gnu.org id=D23462.146342432016932 (code D ref 23462); Mon, 16 May 2016 18:46:02 +0000 Original-Received: (at 23462-done) by debbugs.gnu.org; 16 May 2016 18:45:20 +0000 Original-Received: from localhost ([127.0.0.1]:54301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2NW4-0004OU-4l for submit@debbugs.gnu.org; Mon, 16 May 2016 14:45:20 -0400 Original-Received: from mail-vk0-f65.google.com ([209.85.213.65]:33610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2NW2-0004Hi-3C for 23462-done@debbugs.gnu.org; Mon, 16 May 2016 14:45:18 -0400 Original-Received: by mail-vk0-f65.google.com with SMTP id s184so22556421vkb.0 for <23462-done@debbugs.gnu.org>; Mon, 16 May 2016 11:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=B8+Q2YMkAEJlt0buU+kYI9yyv60G8oMhpvws+gvo0D8=; b=t+2oV/0RCRI3F6nspFw+m1WYFkFDQjTtFCwBLVvVwowF9NMByY+md9rkjl9cdvEshV DDCC4ep6S+w1fjPgWaaEtPJ20FO30I4mIYFGjRLgG2ZRXPMsHY1SQq0OSoOzjZMxR4/T 1tNSiXOexOcZmT/n74iKmMDUocv4bJDAN2ddBBK/kfN8UGWGDFmuYUA6BmNCnzVbV+y+ TfvxN/v0a21ACDfApFmvq7zDuXWot76CyA+oP/RsBsQdVOGTKCHgpkUHrEyaFXvbsSPa 9tAA5s1DNqhEwZpvVYoEpXqCbKcZZ0ShrjXvNXRVurrVM3qcuJgM16hnyWIsuWXfsjnv g7pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=B8+Q2YMkAEJlt0buU+kYI9yyv60G8oMhpvws+gvo0D8=; b=AYXbbiv7DjqobCW+KVR/jfVnBnvDBK2DdEKQKhsHC2mMqxJji53vYhtEAmynSSbmCl sVgRDuabEdTB/IxQROhErIhJuebF9NS7Yq0/eW0TCtJPIs5POIQj6cfUdouA9WE8VQfw SL7H251fT25Plvj307vI7HXc17RH1ZNYw6Ur1F8j5HgIWfOQxYMcRr7ojuOeBSq4L+tR Giau7CjeFR+5t7K5nzaMK3Hm+5tH/99/6jt+0uA2J1ZTDPIEd+594MjF1gwWvLC+wv6b LAVQqeBrK9wV52Ae+Htl7HSdJQ7eN85u9Zbs/iLqxQk6pMwFZbsNdvu4IvCVkJHY1TQW rjzA== X-Gm-Message-State: AOPr4FUiMbqpI2E/gex9zHE/JcfOEdk1ztjZCCkvAFNAt3p2nfIZa7RO2+BVvrCxeSqmOoOxxfKwgijOMhBnFQ== X-Received: by 10.31.94.6 with SMTP id s6mr15666693vkb.105.1463424312683; Mon, 16 May 2016 11:45:12 -0700 (PDT) Original-Received: by 10.31.214.131 with HTTP; Mon, 16 May 2016 11:45:12 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118314 Archived-At: --001a114e1ff450350a0532fa06ca Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi! I got OK from John to commit this to the emacs-25 branch. See http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=3Demacs-25&id=3D06cb28= ff3f24a29fa140d8af747d10abeed44293 for details. Everybody -- thanks! -- Anders On Thu, May 12, 2016 at 8:28 PM, Anders Lindgren wrote: > Hi! > > This is good news! I can't recreate the problem here, most likely because > I'm still on 10.10. However, it works for Alan and Ivan, who originally > reported the problem, has confirmed that the patch corrects the problem. > > Unless anybody objects, I will push the patch to "emacs-25" in a day or > two. John? > > Thanks everybody! > > -- Anders > > On Thu, May 12, 2016 at 6:38 PM, Ivan Cibrario Bertolotti < > ivan.cibrario@polito.it> wrote: > >> Hi, >> >> > On 12 May 2016, at 13:52, Alan Third wrote: >> > >> > [=E2=80=A6] >> > >> > I've tried this on GNUStep as well and it doesn't break it any more >> > than it's already broken. >> >> Thank you so much! I applied your patch to 25.0.93 and tried it on OS X= , >> both with and without NSTRACE_ENABLED. It does not count as a formal te= st, >> but I can confirm no crashes after minimizing/restoring about 20 times >> each. I did it because here Emacs crashed most of the time, but not >> always, and it seemed to depend on timings. >> >> Best regards, >> Ivan >> >> > --001a114e1ff450350a0532fa06ca Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi!

I got OK from John to commit this t= o the emacs-25 branch. See=C2=A0http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=3Demacs-25&= ;id=3D06cb28ff3f24a29fa140d8af747d10abeed44293 for details.
<= br>
Everybody -- thanks!

=C2=A0 =C2=A0 -= - Anders

On Thu, May 12, 2016 at 8:28 PM, Anders Lindgren <<= a href=3D"mailto:andlind@gmail.com" target=3D"_blank">andlind@gmail.com= > wrote:
Hi!
This is good news! I can't recreate the problem here,= most likely because I'm still on 10.10. However, it works for Alan and= Ivan, who originally reported the problem, has confirmed that the patch co= rrects the problem.

Unless anybody objects, I will= push the patch to "emacs-25" in a day or two. John?
Thanks everybody!

=C2=A0 =C2=A0 -- Anders

On Thu, May 12, 2016 at 6:38 PM, Ivan Cibrario Ber= tolotti <ivan.cibrario@polito.it> wrote:
Hi,

> On 12 May 2016, at 13:52, Alan Third <alan@idiocy.org> wrote:
>
> [=E2=80=A6]
>
> I've tried this on GNUStep as well and it doesn't break it any= more
> than it's already broken.

Thank you so much!=C2=A0 I applied your patch to 25.0.93 and tried i= t on OS X, both with and without NSTRACE_ENABLED.=C2=A0 It does not count a= s a formal test, but I can confirm no crashes after minimizing/restoring ab= out 20 times each.=C2=A0 I did it because here Emacs crashed most of the ti= me, but not always, and it seemed to depend on timings.

Best regards,
Ivan



--001a114e1ff450350a0532fa06ca--