From: Anders Lindgren <andlind@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: random832@fastmail.com, 22169@debbugs.gnu.org
Subject: bug#22169: 25.0.50; File name compiletion doesn't work with non-ASCII characters on OS X
Date: Mon, 21 Dec 2015 07:52:53 +0100 [thread overview]
Message-ID: <CABr8ebYprAoFW-RiOvY=w-vXtiPk8-78gqbXDO=JWvkndTPgFw@mail.gmail.com> (raw)
In-Reply-To: <83wps8sc6h.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]
Hi!
I did some simple measurements with and without this patch. I ran
`(file-name-all-completions "x" "src")' on the Emacs src directory. The
timing values were almost identical (varying between 0.001012 and 0.001080).
The way I see it, the patch doesn't do any harm in any coding system, and
it is fast. Hence, I don't really see that it's worth the effort to make
this code conditional.
However, please write a patch for this if you still thinks it's necessary.
I can test it here to make sure it works under OS X.
-- Anders
On Mon, Dec 21, 2015 at 4:39 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> > Date: Sun, 20 Dec 2015 23:00:40 +0100
> > From: Anders Lindgren <andlind@gmail.com>
> > Cc: random832@fastmail.com, 22169@debbugs.gnu.org
> >
> > I managed to get the attached patch to work (when used in conjunction
> with my
> > previous patch).
> >
> > I've tested:
> >
> > * C-x C-f a TAB
> > * (find-file-all-competions "a" ".")
>
> OK, thanks.
>
> The next step is arrange for this to happen only with those values of
> file-name-coding-system that require it. My idea is to put a special
> property on the coding-system's symbol, and check that inside
> file_name_completion (outside of the loop). Can you add this, or do
> you want me to suggest a patch along these lines for you to test?
> Note that the property check will have to be done on
> file-name-coding-system if it is non-nil, otherwise on
> default-file-name-coding-system (if that is non-nil).
>
> Thanks.
>
[-- Attachment #2: Type: text/html, Size: 2240 bytes --]
next prev parent reply other threads:[~2015-12-21 6:52 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 19:08 bug#22169: 25.0.50; File name compiletion doesn't work with non-ASCII characters on OS X Anders Lindgren
2015-12-14 19:20 ` Eli Zaretskii
2015-12-14 21:09 ` Eli Zaretskii
2015-12-14 22:07 ` Anders Lindgren
2015-12-15 3:42 ` Eli Zaretskii
2015-12-15 5:12 ` Anders Lindgren
2015-12-15 9:31 ` Andreas Schwab
2015-12-15 10:21 ` Anders Lindgren
2015-12-15 16:11 ` Eli Zaretskii
2015-12-15 15:58 ` Eli Zaretskii
2015-12-15 19:16 ` Anders Lindgren
2015-12-15 19:56 ` Eli Zaretskii
2015-12-15 20:05 ` Anders Lindgren
2015-12-17 22:01 ` Anders Lindgren
2015-12-18 2:46 ` Random832
2015-12-18 6:29 ` Anders Lindgren
2015-12-18 7:07 ` Eli Zaretskii
2015-12-18 15:26 ` Random832
2015-12-18 17:06 ` Eli Zaretskii
2015-12-20 17:56 ` Eli Zaretskii
2015-12-20 19:16 ` Anders Lindgren
2015-12-20 19:39 ` Eli Zaretskii
2015-12-20 22:00 ` Anders Lindgren
2015-12-21 3:39 ` Eli Zaretskii
2015-12-21 6:52 ` Anders Lindgren [this message]
2015-12-21 16:09 ` Eli Zaretskii
2015-12-21 22:03 ` Anders Lindgren
2015-12-22 3:37 ` Eli Zaretskii
2015-12-22 5:42 ` Anders Lindgren
2015-12-22 17:10 ` Eli Zaretskii
2015-12-22 22:29 ` Anders Lindgren
2015-12-23 3:37 ` Eli Zaretskii
2015-12-23 6:17 ` Anders Lindgren
2015-12-23 17:36 ` Eli Zaretskii
2015-12-24 19:23 ` Anders Lindgren
2015-12-24 19:33 ` Anders Lindgren
2015-12-24 19:42 ` Eli Zaretskii
2015-12-18 7:25 ` Eli Zaretskii
2015-12-18 8:38 ` Anders Lindgren
2015-12-18 9:15 ` Eli Zaretskii
2015-12-18 15:42 ` Random832
2015-12-15 21:53 ` Random832
2015-12-16 3:32 ` Eli Zaretskii
2015-12-16 5:05 ` Random832
2015-12-16 10:17 ` Eli Zaretskii
2015-12-16 16:00 ` Random832
2015-12-16 17:22 ` Eli Zaretskii
2015-12-16 18:19 ` Random832
2015-12-16 18:51 ` Eli Zaretskii
2015-12-14 20:49 ` Random832
2015-12-14 22:41 ` bug#22169: 25.0.50; File name compiletion doesn't work with non-ASCII ch Anders Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABr8ebYprAoFW-RiOvY=w-vXtiPk8-78gqbXDO=JWvkndTPgFw@mail.gmail.com' \
--to=andlind@gmail.com \
--cc=22169@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=random832@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).