From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#21862: Acknowledgement (24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6) Date: Sun, 15 Nov 2015 18:57:02 +0100 Message-ID: References: <563F4B17.6090308@porkrind.org> <56424784.2070600@porkrind.org> <50B60CF8-CBE3-4DF1-8E44-9C6DD5883C6E@gmail.com> <3F4353A6-B088-4DC3-B196-F7AB3EFE5FCE@gmail.com> <859F5387-32A9-4613-BED6-A0FA4D849B38@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c07c7a810b5db0524980537 X-Trace: ger.gmane.org 1447704494 13465 80.91.229.3 (16 Nov 2015 20:08:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Nov 2015 20:08:14 +0000 (UTC) Cc: 21862@debbugs.gnu.org, 21862-done@debbugs.gnu.org, David Caldwell To: David Reitter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 16 21:08:06 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZyQ4J-0006Ci-9F for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Nov 2015 21:08:03 +0100 Original-Received: from localhost ([::1]:48559 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyQ4D-00080u-RV for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Nov 2015 15:07:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zy1Yz-0001jt-BZ for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2015 12:58:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zy1Yw-0003Hq-Hp for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2015 12:58:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49454) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zy1Yw-0003Hm-Ey for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2015 12:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Zy1Yw-00033o-Av for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2015 12:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Nov 2015 17:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21862-done@debbugs.gnu.org id=D21862.144761024311660 (code D ref 21862); Sun, 15 Nov 2015 17:58:02 +0000 Original-Received: (at 21862-done) by debbugs.gnu.org; 15 Nov 2015 17:57:23 +0000 Original-Received: from localhost ([127.0.0.1]:39159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zy1YJ-00031y-6t for submit@debbugs.gnu.org; Sun, 15 Nov 2015 12:57:23 -0500 Original-Received: from mail-yk0-f174.google.com ([209.85.160.174]:33269) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zy1Xy-000317-VX; Sun, 15 Nov 2015 12:57:21 -0500 Original-Received: by ykdv3 with SMTP id v3so206965659ykd.0; Sun, 15 Nov 2015 09:57:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=9umSNhrwkk9OPtnRKtRGqTOLf5z5IVgdmga4JcDaT3o=; b=BaSlSCLZbZzlg00YFwdF7YNBqCdaUdjUTmO4nWxl6yxthOCg3pL4O0iugeLQoD/Vyo 76TpaqAoXCX7g0uIN9rSFPlwucpeokxCp5JPkzNlBe8K7lKp9On/r3w8syeq8iMojyMI /y/7EMYx2lcR8CEy7FeLDwI46ySViKzSoWXPO6FFG8HY+KF1o8QebA3ZkFmqD33U9ChK klVV1cafl8OLD/NcUKX3MaajlUA/uNwanwIMEfCX5zqDgwa4rJCApI1aL3Xz1o9xmYZ2 gEuqa3Xni7GKOdF4upmD4KeI4mMdnbd96RC7BAQwDi5s6izjCQTBtRui9oLFFg0hjoYD 8CMw== X-Received: by 10.13.222.131 with SMTP id h125mr33004570ywe.185.1447610222160; Sun, 15 Nov 2015 09:57:02 -0800 (PST) Original-Received: by 10.31.210.133 with HTTP; Sun, 15 Nov 2015 09:57:02 -0800 (PST) In-Reply-To: <859F5387-32A9-4613-BED6-A0FA4D849B38@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108755 Archived-At: --94eb2c07c7a810b5db0524980537 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, I just pushed the patch on the emacs-25 branch (OK:ed by John). Hopefully, everything should work properly this time. -- Anders On Sat, Nov 14, 2015 at 9:23 PM, David Reitter wrote: > On Nov 14, 2015, at 3:14 PM, Anders Lindgren wrote: > > > David (R), if you think this is a good way to solve this, would you lik= e > to commit this patch, or would you prefer me to do it? > > Yes, defining an extra windowDidBecomeKey function is prettier. > I think that=E2=80=99s okay to check in to master. > > For emacs-25, I think it=E2=80=99s good, too, as it is part of the origin= al > compile bug fix and reduces the chance of future problems rather than > increasing it. I defer to John Wiegley (cc=E2=80=99ed) regarding this. > > Anders, I do think that the cleaner way would be to use notifications to > run these functions, which might reduce extra calls. However, that > requires more testing that I was willing to do (on GNUStep too), because > there=E2=80=99s potential for these methods getting called at a later poi= nt in time. > > - David --94eb2c07c7a810b5db0524980537 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

I just pushed the patch on the emac= s-25 branch (OK:ed by John). Hopefully, everything should work properly thi= s time.

=C2=A0 =C2=A0 -- Anders

On Sat, Nov 14, 2015 at = 9:23 PM, David Reitter <david.reitter@gmail.com> wrote= :
On Nov 14, 2015, at 3:= 14 PM, Anders Lindgren <andlind@gma= il.com> wrote:

> David (R), if you think this is a good way to solve this, would you li= ke to commit this patch, or would you prefer me to do it?

Yes, defining an extra windowDidBecomeKey function is prettier.
I think that=E2=80=99s okay to check in to master.

For emacs-25, I think it=E2=80=99s good, too, as it is part of the original= compile bug fix and reduces the chance of future problems rather than incr= easing it.=C2=A0 I defer to John Wiegley (cc=E2=80=99ed) regarding this.
Anders, I do think that the cleaner way would be to use notifications to ru= n these functions, which might reduce extra calls.=C2=A0 However, that requ= ires more testing that I was willing to do (on GNUStep too), because there= =E2=80=99s potential for these methods getting called at a later point in t= ime.

- David

--94eb2c07c7a810b5db0524980537--