From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal Date: Wed, 15 May 2019 21:10:34 +0200 Message-ID: References: <83woiwb58x.fsf@gnu.org> <83v9ygb4dm.fsf@gnu.org> <877eavwkin.fsf@mail.linkov.net> <87d0kkzv4d.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000110eb60588f1e87c" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="262532"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35695-done@debbugs.gnu.org, 35695@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 15 21:11:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQzJB-0016Ar-9K for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 May 2019 21:11:21 +0200 Original-Received: from localhost ([127.0.0.1]:41279 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQzJA-0007Qa-75 for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 May 2019 15:11:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQzIw-0007Ps-2k for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 15:11:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQzIv-0008VX-6C for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 15:11:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39859) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQzIt-0008TP-Cw for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 15:11:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQzIt-000791-6B for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 15:11:03 -0400 Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 May 2019 19:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 35695 X-GNU-PR-Package: emacs Mail-Followup-To: 35695@debbugs.gnu.org, andlind@gmail.com, andlind@gmail.com Original-Received: via spool by 35695-done@debbugs.gnu.org id=D35695.155794745527437 (code D ref 35695); Wed, 15 May 2019 19:11:02 +0000 Original-Received: (at 35695-done) by debbugs.gnu.org; 15 May 2019 19:10:55 +0000 Original-Received: from localhost ([127.0.0.1]:53402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQzIl-00078O-1Q for submit@debbugs.gnu.org; Wed, 15 May 2019 15:10:55 -0400 Original-Received: from mail-lf1-f51.google.com ([209.85.167.51]:36166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQzIh-000782-Ch; Wed, 15 May 2019 15:10:51 -0400 Original-Received: by mail-lf1-f51.google.com with SMTP id y10so692742lfl.3; Wed, 15 May 2019 12:10:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pyxJoQYSFxODF4zbddGRBXNz7BGoVI1/9Xtf78YdY3Y=; b=DnuB/dltzw4dd8MMef/VhAw8rsAru44ObhvzBXvwiwLnoG4AfmwJypMGKz4i8ap1+A 4bZHEC9bVRViJvwy43nGCcWoM8QI8HNK7B84wQ7MZ2GJsRrE6TDd+MBFxsl9DpHDr/GX mKmu+uMqZRSuTdsbshj8Bdlq4D+ANiLQE0kv2IhkPigISQERd6vX9sSYlDrk3lgQJUTP LV9S1krpBnW04n+Qlq9EHe6iPKCuY6t1/6CIEkV1rwnlvCwuNWP/yhi94OGBmEGpbMBK JJ3TP7ie+aEHlw6Mk502p476ncXq7aarH07usLJw7JVI6BmY09OjW6THofQfe9AXqWjo GtSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pyxJoQYSFxODF4zbddGRBXNz7BGoVI1/9Xtf78YdY3Y=; b=tk82yueMuwYesLlmkDJL53EhZb1VoZZerM3LpNmgmO6BdMBrwNY/uixG9cFRd10Ndd AnSE5tXctqRzGNiy24L9H1GFsvZRXydJb9uU7IzTAOBnRsisguA/2poWcFqOhXLckhys mfF+n+weWkdd1ZUOzcesdHaWfkfruYkg/Kj+DOSmtafmpQ1FzKyfZlBoQKOkrlUtUYTX 3wh+OO4VzV1IrqN0MYMpKiuf38XphTWdJrP8ITyW7GkwOpMD7AhRhjKTj4lXDFWpXMTG oZd+Oxa8AuH50fKdj+07ReOXzOB9I8xuzXObhq0Hi07LOF7KZ9qPdLocUY1Wh4sux8GV N4+A== X-Gm-Message-State: APjAAAVaa8UJMrIBUGCnqK64kU7bcA2ZIqigYakNbT6XbTH4TfP78aAG +yrlI+f6j4P/3IPXjGWoZSmUZe9TwddqNk5gt2I= X-Google-Smtp-Source: APXvYqw6++oVibHi+Nx9J8lv9B7+a/EzYvGXl2d48iYlfUGe8EkaTjtYD92IshJ6BhRE60ge/S/6YJ7sr2TmDvHnz7A= X-Received: by 2002:a19:760e:: with SMTP id c14mr4573630lff.48.1557947445479; Wed, 15 May 2019 12:10:45 -0700 (PDT) In-Reply-To: <87d0kkzv4d.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159352 Archived-At: --000000000000110eb60588f1e87c Content-Type: text/plain; charset="UTF-8" On Tue, May 14, 2019 at 10:36 PM Juri Linkov wrote: > > Should I include a comment describing why we need to treat 256 color > > displays differently? > > Yes, comments are preferable because we don't have deffaces > with more than 88 min-colors anywhere else. > Thanks for the feedback! I've pushed a patch fixing this issue. -- Anders --000000000000110eb60588f1e87c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, May 14, 2019 at 10:36 PM Juri Lin= kov <juri@linkov.net> wrote:
> Should I include a comment describing why we need to treat = 256 color
> displays differently?

Yes, comments are preferable because we don't have deffaces
with more than 88 min-colors anywhere else.

=
Thanks for the feedback!

I've pushed a pa= tch fixing this issue.

=C2=A0 =C2=A0 -- Anders

--000000000000110eb60588f1e87c--