From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thiago Melo Newsgroups: gmane.emacs.bugs Subject: bug#63754: 29.0.91; tmm breaks when tmm-completion-prompt is nil Date: Sat, 27 May 2023 19:48:54 +0000 Message-ID: References: <831qj1k867.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2430"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63754@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 27 21:50:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2zvk-0000No-79 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 May 2023 21:50:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2zvT-0006ye-Eu; Sat, 27 May 2023 15:50:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2zvP-0006yS-DR for bug-gnu-emacs@gnu.org; Sat, 27 May 2023 15:50:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2zvO-00088b-Ru for bug-gnu-emacs@gnu.org; Sat, 27 May 2023 15:50:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2zvO-0007oA-E3 for bug-gnu-emacs@gnu.org; Sat, 27 May 2023 15:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thiago Melo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 May 2023 19:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63754 X-GNU-PR-Package: emacs Original-Received: via spool by 63754-submit@debbugs.gnu.org id=B63754.168521698129975 (code B ref 63754); Sat, 27 May 2023 19:50:02 +0000 Original-Received: (at 63754) by debbugs.gnu.org; 27 May 2023 19:49:41 +0000 Original-Received: from localhost ([127.0.0.1]:52625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2zv2-0007nP-PA for submit@debbugs.gnu.org; Sat, 27 May 2023 15:49:41 -0400 Original-Received: from mail-ed1-f42.google.com ([209.85.208.42]:53370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2zv0-0007n9-A1 for 63754@debbugs.gnu.org; Sat, 27 May 2023 15:49:38 -0400 Original-Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-510e90d785fso2785815a12.2 for <63754@debbugs.gnu.org>; Sat, 27 May 2023 12:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685216972; x=1687808972; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2uwjLsdQY91XSte2yst5KQlLi92OEhCxBrvNUEhqZCI=; b=KTJ1OfFc+a63EmRkBALdAaerhbzLvxgqhujcrQeGO1ozZ7adriQmdWRlI9H43l1KwH QuBf5X7YP+EJ1qK8MmnETc3C2pr3wxWbGkwq54w+u/YCKqTMMnI1wQvm4heI2pCS4Sd1 PAt24+/d5MwVA8zxxAoQUSAc2+CypwA8giGedyihfHTYN3Nz5ZbhpvCZholH7YWvshJw mK6Ij0fDIJ472Y3wJeM2rTJ0FvniRN2A3Sb3T47exYhVHxh9SmTbarlpidsvcEAXY6Ok XgofMUsviOLkc8Iv5Xb3OLQ9E0F5WNpHcuW+mqvopmhAHPyVkYNTJUwiZL4J7QQNqdxF P3bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685216972; x=1687808972; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2uwjLsdQY91XSte2yst5KQlLi92OEhCxBrvNUEhqZCI=; b=I3Ls2L/X/vHfSr7CfRZ+aaT7NWV+1L5iaPUqC9XlqqFyqmiY0OTtRUL1nhjQmBO2VT iKpGrKQcxsevDe7hTtVpsDJk5K2bE4tEssDT11jXXYESWn413eN8gaSrokr9TiRAeDOj wKHjfY89p4jNDPhtWo67AHs9+c4/zqqzxEWPQZQI9q1zRfzMzWwSmdi5IsqpvYsIb4lL gJOjHxf7jprV8h/Lld6ehIM7/dn3RSj2vgwzp73iAQeFbuatPl8nlJFUo4/bwC6CBSiL JoVF7VpnyB5NwrhzxJCzzZAEkn5kGXsi6ZmERjS9LAKjkNbjeu6loe/Ap/lQhXFMd4SW DmMw== X-Gm-Message-State: AC+VfDxI77uNyx8fPA+8SuFaGdpI+oxI44YyPCNNzI0D7VjS/8gi9qOl NNtkaVdId+qs+ba+5r8ARTAFuTzrOOj837o07Gw= X-Google-Smtp-Source: ACHHUZ61o+ZCCvGm0wC4N22ZcdsR9OotWrkQK76JNCE66tw/DLZxiwp4IxsnqEcWPSeA/LZfP/uz2JrcIYyMLE6/BLA= X-Received: by 2002:a05:6402:31f6:b0:512:686f:b651 with SMTP id dy22-20020a05640231f600b00512686fb651mr5120368edb.32.1685216972185; Sat, 27 May 2023 12:49:32 -0700 (PDT) In-Reply-To: <831qj1k867.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262489 Archived-At: On Sat, May 27, 2023 at 5:14=E2=80=AFPM Eli Zaretskii wrote: > Thanks. This was caused by a change in the completion heading line in > Emacs 29: it is now a customizable format string, and can be nil. So > the method used by tmm.el for finding the prompt (so it could delete > it) is no longer workable, and must be replaced by a different method. > > Should be fixed now on the emacs-29 branch. Cool. I've tested, it's working nicely. Thanks for the fix. > (I also fixed it to work > when 'tmm-mid-prompt' is nil, something that seems to have been broken > since about forever -- I found that bug while testing the patch, > because the patch has to work also when 'tmm-mid-prompt' is nil, and > there are no menu shortcuts shown.) Sorry if my comment is out of place, but I also gave a try to `tmm-mid-prompt' =3D nil. Since it disables the tmm shortcuts, maybe it would be more intuitive to let users input keys and do completion at the minibuffer in this situation? (unless I'm missing some unwanted side effect here) With this little change, for example: --- tmm.el.orig 2023-05-27 21:26:44.594743965 +0200 +++ tmm.el 2023-05-27 21:27:13.571769823 +0200 @@ -305,7 +305,7 @@ ;; This returns the old map. (defun tmm-define-keys (minibuffer) (let ((map (make-sparse-keymap))) - (suppress-keymap map t) + (when tmm-mid-prompt (suppress-keymap map t)) (dolist (c tmm-short-cuts) (if (listp tmm-shortcut-style) (define-key map (char-to-string c) 'tmm-shortcut)