From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thiago Melo Newsgroups: gmane.emacs.bugs Subject: bug#63589: [PATCH] 29.0.91; crash after creating graphical frames via emacsclient when compiled with cairo-xcb Date: Sat, 20 May 2023 22:47:17 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000000004cf05fc27d4cc" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21861"; mail-complaints-to="usenet@ciao.gmane.io" To: 63589@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 21 00:49:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q0VNz-0005au-OT for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 May 2023 00:49:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q0VNn-0004ot-V2; Sat, 20 May 2023 18:49:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0VNm-0004oS-Ap for bug-gnu-emacs@gnu.org; Sat, 20 May 2023 18:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q0VNm-0006YH-2Q for bug-gnu-emacs@gnu.org; Sat, 20 May 2023 18:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q0VNl-0008Dk-V2 for bug-gnu-emacs@gnu.org; Sat, 20 May 2023 18:49:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Thiago Melo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 May 2023 22:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63589 X-GNU-PR-Package: emacs Original-Received: via spool by 63589-submit@debbugs.gnu.org id=B63589.168462288331412 (code B ref 63589); Sat, 20 May 2023 22:49:01 +0000 Original-Received: (at 63589) by debbugs.gnu.org; 20 May 2023 22:48:03 +0000 Original-Received: from localhost ([127.0.0.1]:59510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0VMp-0008AY-0N for submit@debbugs.gnu.org; Sat, 20 May 2023 18:48:03 -0400 Original-Received: from mail-yw1-f174.google.com ([209.85.128.174]:52577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0VMn-00089O-2G for 63589@debbugs.gnu.org; Sat, 20 May 2023 18:48:01 -0400 Original-Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-561c1768bacso62192737b3.1 for <63589@debbugs.gnu.org>; Sat, 20 May 2023 15:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684622875; x=1687214875; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=8kqSiolSo290XjZq2YzCmzufpLRV2bNVj1xrw7JGFkU=; b=JC1re0q7NIYsdFJXmOT5N3uVKNojmTEcV8e6vIlN+a0HJDcKWrtEiLKTU+pOwVZknN jzG2YUrfuVXDrJ6Hp+WpkR3L2baEULdH46dRvfcugUhXMPpFJR5DQBCKQglzd7otIrXB y4MGxrrXiU5UF24IWbK0knVB2IwhJja8H3RmwbJ8elER3pTZrbcmDgWLTU25XckzqiBT Wf/y0qp2pgeq3zzeVwmIOG8juuAtssg7hDX12LYa2a7tInRmRKVmBU2kEG0wy+QwULhW 6qBBQ0rBtfKVrK8dKiImBjDIZMO+n80w2BAv9+DzwS/XKo6CaelQUkFFIPA9LnN+flVy U+3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684622875; x=1687214875; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8kqSiolSo290XjZq2YzCmzufpLRV2bNVj1xrw7JGFkU=; b=KNPYD2NdeOpldWjbsuFgyj7oDob/YIrWgx7thXP624q7FChWTecKxkTyoBEs9Brb9i DClqysqUTenf0lJu1jmy8+25XF7RrNd7DEsHnUnMbLkFtA6Yr4zYEDnCUZbkmyaoMNSC S1l5+L0kHzMzn+MLsqpLnj/jm4xyGvi107uXCIWLGQqx9KU6R7VDRyouMGiFhL/aDqhL 23kX9rR918RRukXeisO560acyi6RZ5WfHiHD1qoN/eYRyquPdhBl0y3nzT0o0cjzCsv0 k4uIQUSCVGJDC3wt93RlW41XSK/Ow+A6HGSBPFmbbkafI/b9ncC4i5VJ5mY+QPKBZ+X4 xvKQ== X-Gm-Message-State: AC+VfDzRofag8Ygb4Dhc5sgCn//Eklqfd0eyju2dfE88ApibHZXzsjIM XVyFeK+k1qjhPRZWVwL74EHEnCyVh1+pBCK3dTWNmVPy65o= X-Google-Smtp-Source: ACHHUZ5lnEiS6KxNh07w4NjnI1AT+Y5fxZccOkQWOVhj7tqRdOkj0ma8HjPHjoymvH53+uznKDU1d7uLKweRem9eGGY= X-Received: by 2002:a0d:d901:0:b0:55a:ad64:1b62 with SMTP id b1-20020a0dd901000000b0055aad641b62mr6458599ywe.16.1684622874232; Sat, 20 May 2023 15:47:54 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262070 Archived-At: --0000000000000004cf05fc27d4cc Content-Type: text/plain; charset="UTF-8" Here's a patch to fix this issue. It was created on top of the emacs-29 branch, commit 6b60c81. It's based on the suggestion from the cairo mailing list (see the link I sent in my original message here). It ensures that the cairo device associated with the cairo-xcb surfaces in the display is destroyed before closing the display. It can probably be improved. It could even be extended to handle cairo-xlib. In the cairo mailing list, they mentioned one corner case where the xlib device is not properly destroyed: when cairo is unloaded before the X11 connection is closed. --0000000000000004cf05fc27d4cc Content-Type: text/x-patch; charset="US-ASCII"; name="bugfix-63589.patch" Content-Disposition: attachment; filename="bugfix-63589.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lhwkv92b0 RnJvbSBkNjJiNjVkMmExNGFhMzQ4YmQ2OWJjNzUzNjM1NzIyNWYyNTcxYzE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaGlhZ28gTWVsbyA8dG1kbWVsb0BnbWFpbC5jb20+CkRhdGU6 IFNhdCwgMjAgTWF5IDIwMjMgMTg6NTI6MDMgKzAyMDAKU3ViamVjdDogW1BBVENIXSBGaXggQnVn IzYzNTg5LgoKLS0tCiBzcmMveHRlcm0uYyB8IDE2ICsrKysrKysrKysrKysrKysKIHNyYy94dGVy bS5oIHwgIDYgKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKykKCmRpZmYg LS1naXQgYS9zcmMveHRlcm0uYyBiL3NyYy94dGVybS5jCmluZGV4IGU5ODFhMzYuLjdlZDRkZmMg MTAwNjQ0Ci0tLSBhL3NyYy94dGVybS5jCisrKyBiL3NyYy94dGVybS5jCkBAIC01ODA2LDEwICs1 ODA2LDE2IEBAIHhfYmVnaW5fY3JfY2xpcCAoc3RydWN0IGZyYW1lICpmLCBHQyBnYykKICAgICAg IGNhaXJvX3N1cmZhY2VfdCAqc3VyZmFjZTsKICNpZmRlZiBVU0VfQ0FJUk9fWENCX1NVUkZBQ0UK ICAgICAgIGlmIChGUkFNRV9ESVNQTEFZX0lORk8gKGYpLT54Y2JfdmlzdWFsKQorICAgICAgICB7 CiAJc3VyZmFjZSA9IGNhaXJvX3hjYl9zdXJmYWNlX2NyZWF0ZSAoRlJBTUVfRElTUExBWV9JTkZP IChmKS0+eGNiX2Nvbm5lY3Rpb24sCiAJCQkJCSAgICAoeGNiX2RyYXdhYmxlX3QpIEZSQU1FX1hf UkFXX0RSQVdBQkxFIChmKSwKIAkJCQkJICAgIEZSQU1FX0RJU1BMQVlfSU5GTyAoZiktPnhjYl92 aXN1YWwsCiAJCQkJCSAgICB3aWR0aCwgaGVpZ2h0KTsKKwljYWlyb19kZXZpY2VfdCAqY2Fpcm9f ZGV2aWNlID0gY2Fpcm9fc3VyZmFjZV9nZXRfZGV2aWNlKHN1cmZhY2UpOworCWlmIChjYWlyb19k ZXZpY2VfZ2V0X3R5cGUoY2Fpcm9fZGV2aWNlKSA9PSBDQUlST19ERVZJQ0VfVFlQRV9YQ0IKKwkg ICAgJiYgIUZSQU1FX0RJU1BMQVlfSU5GTyAoZiktPmNhaXJvX2RldmljZSkKKwkgIEZSQU1FX0RJ U1BMQVlfSU5GTyAoZiktPmNhaXJvX2RldmljZSA9IGNhaXJvX2RldmljZV9yZWZlcmVuY2UoY2Fp cm9fZGV2aWNlKTsKKyAgICAgICAgfQogICAgICAgZWxzZQogI2VuZGlmCiAJc3VyZmFjZSA9IGNh aXJvX3hsaWJfc3VyZmFjZV9jcmVhdGUgKEZSQU1FX1hfRElTUExBWSAoZiksCkBAIC0zMDg0MSw2 ICszMDg0NywxNiBAQCB4X2RlbGV0ZV90ZXJtaW5hbCAoc3RydWN0IHRlcm1pbmFsICp0ZXJtaW5h bCkKIAkgY2xvc2luZyBhbGwgdGhlIGRpc3BsYXlzLiAgKi8KICAgICAgIFhybURlc3Ryb3lEYXRh YmFzZSAoZHB5aW5mby0+cmRiKTsKICNlbmRpZgorI2lmZGVmIFVTRV9DQUlST19YQ0JfU1VSRkFD RQorICAgICAgLyogRW5zdXJlIHRoYXQgdGhlIGNhaXJvIGRldmljZSBpcyBkZXN0cm95ZWQgYmVm b3JlIGNsb3NpbmcKKyAgICAgICAgIGNvbm5lY3Rpb24gKEJ1ZyM2MzU4OSkuICAqLworICAgICAg aWYgKGRweWluZm8tPmNhaXJvX2RldmljZSkKKwl7CisJICBjYWlyb19kZXZpY2VfZmluaXNoKGRw eWluZm8tPmNhaXJvX2RldmljZSk7CisJICBjYWlyb19kZXZpY2VfZGVzdHJveShkcHlpbmZvLT5j YWlyb19kZXZpY2UpOworCSAgZHB5aW5mby0+Y2Fpcm9fZGV2aWNlID0gTlVMTDsKKwl9CisjZW5k aWYKICNpZmRlZiBVU0VfR1RLCiAgICAgICB4Z19kaXNwbGF5X2Nsb3NlIChkcHlpbmZvLT5kaXNw bGF5KTsKICNlbHNlCmRpZmYgLS1naXQgYS9zcmMveHRlcm0uaCBiL3NyYy94dGVybS5oCmluZGV4 IDg4MzQzNDYuLmJkYzU0NTggMTAwNjQ0Ci0tLSBhL3NyYy94dGVybS5oCisrKyBiL3NyYy94dGVy bS5oCkBAIC04ODQsNiArODg0LDEyIEBAICNkZWZpbmUgWF9JTlZBTElEX1dJTkRPVyAweGZmZmZm ZmZmCiAgICAgIHNlcnZlcl90aW1lX21vbm90b25pY19wIHdpbGwgYmUgdHJ1ZSkuICAqLwogICBp bnRfZmFzdDY0X3Qgc2VydmVyX3RpbWVfb2Zmc2V0OwogI2VuZGlmCisKKyNpZiBkZWZpbmVkIFVT RV9YQ0IgJiYgZGVmaW5lZCBVU0VfQ0FJUk9fWENCCisgIC8qIENhaXJvIGRldmljZSBhc3NvY2lh dGVkIHdpdGggY2Fpcm8gc3VyZmFjZXMgaW4gdGhpcyBkaXNwbGF5LgorICAgICBSZXF1aXJlZCBm b3IgcHJvcGVyIGNsZWFudXAgYmVmb3JlIGNsb3NpbmcgZGlzcGxheSBjb25uZWN0aW9uLiAgKi8K KyAgY2Fpcm9fZGV2aWNlX3QgKmNhaXJvX2RldmljZTsKKyNlbmRpZgogfTsKIAogI2lmZGVmIEhB VkVfWF9JMThOCi0tIAoyLjM5LjIKCg== --0000000000000004cf05fc27d4cc--