From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gustaf Waldemarson Newsgroups: gmane.emacs.bugs Subject: bug#62696: python.el: Extra indentation for conditionals Date: Thu, 20 Apr 2023 19:44:44 +0200 Message-ID: References: <83zg7355f8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000355a8a05f9c81953" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36824"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62696@debbugs.gnu.org, Eli Zaretskii , npostavs@users.sourceforge.net, gastove@gmail.com, dgutov@yandex.ru To: kobarity Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 20 19:46:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppYMP-0009RL-FR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Apr 2023 19:46:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppYM7-0003C4-Pz; Thu, 20 Apr 2023 13:46:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppYM6-0003Bg-1R for bug-gnu-emacs@gnu.org; Thu, 20 Apr 2023 13:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppYM5-0006cx-PO for bug-gnu-emacs@gnu.org; Thu, 20 Apr 2023 13:46:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ppYM5-0006mz-Hy for bug-gnu-emacs@gnu.org; Thu, 20 Apr 2023 13:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gustaf Waldemarson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Apr 2023 17:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62696 X-GNU-PR-Package: emacs Original-Received: via spool by 62696-submit@debbugs.gnu.org id=B62696.168201270326017 (code B ref 62696); Thu, 20 Apr 2023 17:46:01 +0000 Original-Received: (at 62696) by debbugs.gnu.org; 20 Apr 2023 17:45:03 +0000 Original-Received: from localhost ([127.0.0.1]:38636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppYL8-0006lY-Sy for submit@debbugs.gnu.org; Thu, 20 Apr 2023 13:45:03 -0400 Original-Received: from mail-yb1-f182.google.com ([209.85.219.182]:37782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppYL6-0006km-SH for 62696@debbugs.gnu.org; Thu, 20 Apr 2023 13:45:01 -0400 Original-Received: by mail-yb1-f182.google.com with SMTP id m14so2840944ybk.4 for <62696@debbugs.gnu.org>; Thu, 20 Apr 2023 10:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682012695; x=1684604695; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8IriK/J54aPi8dqfVxKgLCHRa1+In591G4N71r74iiA=; b=qB7QeNrWXHksqKGRXy40DDHLO5NrEiGZThkD0OGZ9v7X0tFOy/E7Ejo9Bm8T96E3TA PbYFhU/ZTiQl6G6j7J4QiFO2Hb4bnRA9JwdocPVSckLlSoSbtIOy9oR0tSusvsFqeXzx iFDNkkEINgg1dS+ObUG4llbnRPbrSfe9UGsh8nMj7sjvA+eRtRzPZLte27efpY1wokZO BLHS3vNfBxhBEEQ7X1GTSVHwKXnw3O2u1BfNpRFKgxNE7PBogsFbB3baCFctsul4Ri3Z WF+98udSBLCE8LVLP5RBn/AeTFVvZGdUoM4ih+/ksZlKRhHZ9kAMV2S3Go4TWpri+yz2 3eHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682012695; x=1684604695; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8IriK/J54aPi8dqfVxKgLCHRa1+In591G4N71r74iiA=; b=jsrcSh/2vF7WuzHH/R1ZzrIXdftyICDZ1oUrcHrm0NO0BGQPfSN7vNmnDV6YI3qgPv 6da3Ww4asbdWeU9LI6WmbKb++6dPwmkhtJU1i93UFfKvG/5NuroeWCy74gFENFRegQke 1EfNzd+EH/eehC7mY29fHVfzxQ/GdSpnFLDtUcR3ZtztoOdKjxSYU15WjG0jcaCldF43 MF7b8/qzwhnr2jhcaz2srLBbCbAQLm8zetv6rO8EUcktEgiOo7YWPds6n0QnohNnnSIB UAn0x1zpJhFfnEQAYviiXweMhwFBXuE5CSEVSio02SDVwHrDhGXPD1aGgSFkSRzkXuus /Eag== X-Gm-Message-State: AAQBX9fVMBNCpvX6t2iBCCGJ/+EcuFyIT49+Rn6M7TfgG1kiCtJtbGvD KXVSj9AKFS8GO9lTlFxyUD3j3Wf7ynyx+9wdfZM= X-Google-Smtp-Source: AKy350Y2IM2YsPIPAGQFN4dCGCfhbcn3VRzavHyX7Tpy5VmEDxB4AbTc0rpyp3xUPw5hbKwWwDKo7MCNZ/j/JE2NwAY= X-Received: by 2002:a25:db4a:0:b0:b92:5a6e:108c with SMTP id g71-20020a25db4a000000b00b925a6e108cmr1861418ybf.19.1682012695254; Thu, 20 Apr 2023 10:44:55 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260349 Archived-At: --000000000000355a8a05f9c81953 Content-Type: text/plain; charset="UTF-8" > If so, I think it is still good. I updated the patches. Yes, as long as the examples are both consistent with the parenthesis they are good to me! Best regards, Gustaf Den tors 20 apr. 2023 kl 16:19 skrev kobarity : > > Gustaf Waldemarson wrote: > > It mostly looks good to me, but perhaps it would make sense to still > output > > the closing paren on the same line as the first example? I suppose it > might > > not make sense from a style-perspective, but I guess someone reading > through > > this mostly care about comparing indentation depths > > Do you mean > > def do_something( > arg1, > arg2): > print('hello') > > is better than the following? > > def do_something( > arg1, > arg2 > ): > print('hello') > > If so, I think it is still good. I updated the patches. > > > > Do these two patches replace every other patch posted in this > > > discussion? > > > Are these two patches ready to be installed, or are you still > > > discussing the issue? > > > > I believe that's the case, but I would wait for a response from Kobarity > > following this. > > Yes, I'm attaching the patches which replace every other patches in > old mails. I was just waiting to see if anyone had any comments or > feedback. So, unless there is an objection, the patches are ready to > be installed on the master branch. > --000000000000355a8a05f9c81953 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> If so, I think it is still good.=C2= =A0 I updated the patches.

Yes, as long as the examples are both consistent with the pare= nthesis
they are good to me!
=
Best regards,
Gustaf
=

<= div dir=3D"ltr" class=3D"gmail_attr">Den tors 20 apr. 2023 kl 16:19 skrev k= obarity <kobarit= y@gmail.com>:

Gustaf Waldemarson wrote:
> It mostly looks good to me, but perhaps it would make sense to still o= utput
> the closing paren on the same line as the first example? I suppose it = might
> not make sense from a style-perspective, but I guess someone reading t= hrough
> this mostly care about comparing indentation depths

Do you mean

=C2=A0 =C2=A0 def do_something(
=C2=A0 =C2=A0 =C2=A0 =C2=A0 arg1,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 arg2):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 print('hello')

is better than the following?

=C2=A0 =C2=A0 def do_something(
=C2=A0 =C2=A0 =C2=A0 =C2=A0 arg1,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 arg2
=C2=A0 =C2=A0 ):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 print('hello')

If so, I think it is still good.=C2=A0 I updated the patches.

> > Do these two patches replace every other patch posted in this
> > discussion?
> > Are these two patches ready to be installed, or are you still
> > discussing the issue?
>
> I believe that's the case, but I would wait for a response from Ko= barity
> following this.

Yes, I'm attaching the patches which replace every other patches in
old mails.=C2=A0 I was just waiting to see if anyone had any comments or feedback.=C2=A0 So, unless there is an objection, the patches are ready to<= br> be installed on the master branch.
--000000000000355a8a05f9c81953--