From: Gustaf Waldemarson <gustaf.waldemarson@gmail.com>
To: kobarity <kobarity@gmail.com>
Cc: 62696@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
npostavs@users.sourceforge.net, gastove@gmail.com,
dgutov@yandex.ru
Subject: bug#62696: python.el: Extra indentation for conditionals
Date: Thu, 20 Apr 2023 19:44:44 +0200 [thread overview]
Message-ID: <CABehr5cFTF+udD1qqEZUZKoKQQ7w2hGOyveVfqJ2Ryd_6GsjHg@mail.gmail.com> (raw)
In-Reply-To: <eke7cz3yk54o.wl-kobarity@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]
> If so, I think it is still good. I updated the patches.
Yes, as long as the examples are both consistent with the parenthesis
they are good to me!
Best regards,
Gustaf
Den tors 20 apr. 2023 kl 16:19 skrev kobarity <kobarity@gmail.com>:
>
> Gustaf Waldemarson wrote:
> > It mostly looks good to me, but perhaps it would make sense to still
> output
> > the closing paren on the same line as the first example? I suppose it
> might
> > not make sense from a style-perspective, but I guess someone reading
> through
> > this mostly care about comparing indentation depths
>
> Do you mean
>
> def do_something(
> arg1,
> arg2):
> print('hello')
>
> is better than the following?
>
> def do_something(
> arg1,
> arg2
> ):
> print('hello')
>
> If so, I think it is still good. I updated the patches.
>
> > > Do these two patches replace every other patch posted in this
> > > discussion?
> > > Are these two patches ready to be installed, or are you still
> > > discussing the issue?
> >
> > I believe that's the case, but I would wait for a response from Kobarity
> > following this.
>
> Yes, I'm attaching the patches which replace every other patches in
> old mails. I was just waiting to see if anyone had any comments or
> feedback. So, unless there is an objection, the patches are ready to
> be installed on the master branch.
>
[-- Attachment #2: Type: text/html, Size: 2124 bytes --]
next prev parent reply other threads:[~2023-04-20 17:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 12:47 bug#62696: python.el: Extra indentation for conditionals Gustaf Waldemarson
2023-04-09 12:11 ` kobarity
2023-04-10 11:11 ` Gustaf Waldemarson
2023-04-10 15:21 ` kobarity
2023-04-11 11:11 ` Gustaf Waldemarson
2023-04-12 15:26 ` kobarity
2023-04-16 13:24 ` kobarity
2023-04-16 15:49 ` Gustaf Waldemarson
2023-04-18 14:23 ` kobarity
2023-04-20 8:22 ` Eli Zaretskii
2023-04-20 13:40 ` Gustaf Waldemarson
2023-04-20 14:19 ` kobarity
2023-04-20 17:44 ` Gustaf Waldemarson [this message]
2023-04-22 9:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABehr5cFTF+udD1qqEZUZKoKQQ7w2hGOyveVfqJ2Ryd_6GsjHg@mail.gmail.com \
--to=gustaf.waldemarson@gmail.com \
--cc=62696@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=gastove@gmail.com \
--cc=kobarity@gmail.com \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).