From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#15214: 24.3.50; `Revert This Session's Customization' does not do what it says Date: Tue, 7 Jan 2020 18:58:13 -0300 Message-ID: References: <8b504c44-91b3-4c9f-bca5-3b4d1547f67f@default> <83mub8laut.fsf@gnu.org> <83mub7jfql.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000025d4cf059b93e020" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="124009"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 15214@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 07 22:59:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iowsZ-000SxB-16 for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jan 2020 22:59:11 +0100 Original-Received: from localhost ([::1]:56368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iowsX-0006Ml-Gt for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jan 2020 16:59:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53287) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iowsR-0006L7-8M for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 16:59:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iowsQ-0008J5-AU for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 16:59:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43538) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iowsQ-0008Iz-7y for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 16:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iowsQ-00078i-7V for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 16:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jan 2020 21:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15214 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15214-submit@debbugs.gnu.org id=B15214.157843431527408 (code B ref 15214); Tue, 07 Jan 2020 21:59:02 +0000 Original-Received: (at 15214) by debbugs.gnu.org; 7 Jan 2020 21:58:35 +0000 Original-Received: from localhost ([127.0.0.1]:49511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iowry-000780-Po for submit@debbugs.gnu.org; Tue, 07 Jan 2020 16:58:34 -0500 Original-Received: from mail-lf1-f51.google.com ([209.85.167.51]:45389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iowrw-00077j-SR for 15214@debbugs.gnu.org; Tue, 07 Jan 2020 16:58:33 -0500 Original-Received: by mail-lf1-f51.google.com with SMTP id 203so852997lfa.12 for <15214@debbugs.gnu.org>; Tue, 07 Jan 2020 13:58:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sCADKM/brLV1r8eWbqPUkqq8dT/tVqIPIzR5LlNM5Vg=; b=C1juIbFHvj7iLCAXS+jsAeTi5krym4RDTAoBEh0VFHtHjLhS/m7msTC2344uBgYrYg XOR40ZtrZYMnjy6o8/+Bob1GU0b33qvt5/Cr01NmK7XKnCwjxw1Ds4L0AyqojJeRVKpz us5W2CAxuEZ4qxRM8VVFuMafKf8Ad3utb5C8XB8eBCjDWz1wvkPbNgJtuUx2cklGDLPq jtqR3gn6/YWdWII0qb6Py4qjBA+f5ORDyFtQq+FXBEJLzZwS5HbuFM0Q5+gELh8z9eBJ ksrWqOkbcvxwE0X/BfiTB1rtr9yuZoUY36oDmadN7T519fPE05Oc1JSvrlkocOTmKC35 7MFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sCADKM/brLV1r8eWbqPUkqq8dT/tVqIPIzR5LlNM5Vg=; b=moq4CVcPX/CNPlA9QnoCKPhbs1v7KoSFoUcEUIVgU0fuvh3R0G6Xn9uKeZPPoECZdF KQSesd2ZTNgL9p0gJLPZJFgLFL5pexX6IMXmTp3wSnDn0TgVclmtUM5Zww0qFVecVP1L 8vfPumjOsDSwHly3W/BOHMXNFjl1Lqsg8J43lSs2Edq1Q9lL/BLn5UoXLP87zWH3re+Q /+J9Jomv8t94sUmTX2feN5FDjbtkvJDiMllxz6f54Q4h51U89TlJAz5HjHbWYSRp68m6 /ZRPYXudyesZv6eUVgK3jCL4VAtp1cYkfPWHBDweFMg7V0LZWLmIQwTIBvoE+5OS3qUs oSuA== X-Gm-Message-State: APjAAAXtEcuS4rshmMcVCHUAIWrAQpCylpM+nOxZsUpj2wbMAgeNQonO l55SYhjjQquiQPG+hFTVU6xqkG92nDm9mJ54IDI= X-Google-Smtp-Source: APXvYqxt+7cJGstpmCOpDQxhamVJyYTb+D5NolY+3kX8qiB0iYuf1i9YZ2Z2elm4M1yHXpf0ARxjVVYyE0TK1yPqPxw= X-Received: by 2002:a05:6512:c7:: with SMTP id c7mr962182lfp.120.1578434306625; Tue, 07 Jan 2020 13:58:26 -0800 (PST) In-Reply-To: <83mub7jfql.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174351 Archived-At: --00000000000025d4cf059b93e020 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: >> What part of the doc string do you find ambiguous? > > The "reset" part. The best I can come up with is just saying: "...; otherwise, set the variable to the standard value." (If the change is applied, of course). >> I still think it would be a good addition to the code. In case you are >> OK with it, I attach a patch with moves the funcall outside of the >> if-else form. > > It LGTM, thanks. Great. If there are no other objections, I'll wait for someone to push it. --00000000000025d4cf059b93e020 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@gnu= .org> writes:

>> What part of the doc string do you fin= d ambiguous?
>
> The "reset" part.

The best I = can come up with is just saying:
"...; otherwise, set the variable = to the standard value."
(If the change is applied, of course).
<= br>>> I still think it would be a good addition to the code.=C2=A0 In= case you are
>> OK with it, I attach a patch with moves the funca= ll outside of the
>> if-else form.
>
> It LGTM, thanks= .

Great.=C2=A0 If there are no other objections, I'll wait for s= omeone to push
it.
--00000000000025d4cf059b93e020--