From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Date: Sun, 30 Aug 2020 08:52:41 -0300 Message-ID: References: <837dtiymay.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000016502005ae16edfa" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26647"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41145@debbugs.gnu.org, Philipp Stephani To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 30 13:54:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCLuU-0006nn-Ca for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Aug 2020 13:54:10 +0200 Original-Received: from localhost ([::1]:41236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCLuT-0001dn-1n for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Aug 2020 07:54:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCLuO-0001dS-21 for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 07:54:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38026) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCLuM-0007fC-8C for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 07:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCLuM-0004Uo-6w for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 07:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Aug 2020 11:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41145 X-GNU-PR-Package: emacs Original-Received: via spool by 41145-submit@debbugs.gnu.org id=B41145.159878838417218 (code B ref 41145); Sun, 30 Aug 2020 11:54:02 +0000 Original-Received: (at 41145) by debbugs.gnu.org; 30 Aug 2020 11:53:04 +0000 Original-Received: from localhost ([127.0.0.1]:49572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCLtQ-0004Te-Ht for submit@debbugs.gnu.org; Sun, 30 Aug 2020 07:53:04 -0400 Original-Received: from mail-wm1-f48.google.com ([209.85.128.48]:37402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCLtL-0004T5-Li for 41145@debbugs.gnu.org; Sun, 30 Aug 2020 07:53:03 -0400 Original-Received: by mail-wm1-f48.google.com with SMTP id x9so2901668wmi.2 for <41145@debbugs.gnu.org>; Sun, 30 Aug 2020 04:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W20iFA2i+MTUSUMCGZzeIt/uZnfJrSzRjiNK7AUWm2A=; b=AmFxIejYNbOgDyXmdkWKsgmCy3kTgMZw1YtIZ0GlNEE16mCa3fmnoOsCTas6B85xPD Sk0C/faBnJwtyXmGRc6Wz9l2oNuDy1/XZsoKg3YcMyOYnasvPrJ0RbGfgiDeLte9fx71 vzLAzL3oBCvdVzPYDRGBslXwzg1BOoQ2h3XiCRqdllOT77K88lWww4a5CPr5+MPpgSuh hgrBMhkD803VMubxNbCBveC+6E9cMaDo9xlVFzLpd9pY7flK1jQ7qsfbrqk9FMS+80Zd BUe/fbF30V0Kk2E+KjQYK/gGlJvBk8sbGTH0ug4XoAx5AY0gVvxPynKIn2vR3tD6UIAI NS+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W20iFA2i+MTUSUMCGZzeIt/uZnfJrSzRjiNK7AUWm2A=; b=d5VEmVTwi2guzb9l7/VMwb8lckXnslE1UISoxM3Pd9jo98DE5H24PmVgOviJyVlxeG NH5MX7P5+1k7aFIRJ7bwal90HpRdnY2+wRSa/3nLAv0Xej4HmuR6uJeUU3a7a/ECo7to Z0jUDn6COOQ/QSc+N1k9rhcdehnI5O1FrnMi62rzeyiITWBpPFqd0rtiZQoY5cSB2P2Y gdySmchPSj8mPwTDK6dTsFiBryQ6H9QI+UgYIeWbIGWBYmYhjaUFckN9mOZHsStXLZRT Xfk9GFSr+swVYOgl89Tl0VV/U9S4H5xk9PDLD5me57NO5zQx5twCWFH+hWJlQic6/Ov7 STyg== X-Gm-Message-State: AOAM533TUHykpjfvB+kKu+M/Faqj1iU4hEKmVa5uzjub9CspMbou9O+f mYNOwkSQVkbthA0oUv9F31zFCQ1BuV+Sc/a9qds= X-Google-Smtp-Source: ABdhPJxiHn2Pl6ZuQAvboJl0shcDwPHtq9yvN4TP1d2tKg2XO61rFyZ+JCTkmrgznX1oDlax3SXAsYJIsSOzGdNBXJA= X-Received: by 2002:a1c:2b04:: with SMTP id r4mr6427365wmr.76.1598788373728; Sun, 30 Aug 2020 04:52:53 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186686 Archived-At: --00000000000016502005ae16edfa Content-Type: text/plain; charset="UTF-8" Stefan Monnier writes: >>>>> Or if eventually a defface or a defcustom makes its way into >>>>> display-fill-column-indicator.el, of course. >>> >>> Actually, there is a defcustom there (in the expansion of >>> `define-globalized-minor-mode`). >> >> Sorry, I wasn't clear enough. There is no defcustom or defface whose >> :group is display-fill-column-indicator. > > `global-display-fill-column-indicator-mode` should definitely belong to > the `display-fill-column-indicator` group (because the `defcustom` > doesn't have an explicit `:group` so it should fallback to using the > last-defined group). Is it, though? emacs -Q M-x customize-option RET global-display-fill-column-indicator-mode And near the end of buffer I read: Groups: Global Display Fill Column Indicator Furthermore, the list (global-display-fill-column-indicator-mode custom-variable) is not a member of the custom-group property of display-fill-column-indicator. > BTW, another quick-fix might be to move the defface definition to > display-fill-column-indicator.el. Right. --00000000000016502005ae16edfa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>>>> O= r if eventually a defface or a defcustom makes its way into
>>>= >> display-fill-column-indicator.el, of course.
>>>
&g= t;>> Actually, there is a defcustom there (in the expansion of
>= ;>> `define-globalized-minor-mode`).
>>
>> Sorry, I= wasn't clear enough.=C2=A0 There is no defcustom or defface whose
&= gt;> :group is display-fill-column-indicator.
>
> `global-di= splay-fill-column-indicator-mode` should definitely belong to
> the `= display-fill-column-indicator` group (because the `defcustom`
> doesn= 't have an explicit `:group` so it should fallback to using the
>= last-defined group).

Is it, though?
emacs -Q
M-x customize-op= tion RET global-display-fill-column-indicator-mode
And near the end of b= uffer I read:
Groups: Global Display Fill Column Indicator

Furthe= rmore, the list
(global-display-fill-column-indicator-mode custom-variab= le) is not a
member of the custom-group property of display-fill-column-= indicator.

> BTW, another quick-fix might be to move the defface = definition to
> display-fill-column-indicator.el.

Right.
--00000000000016502005ae16edfa--