unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Mauro Aranda <maurooaranda@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 41145@debbugs.gnu.org, Philipp Stephani <p.stephani2@gmail.com>
Subject: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group
Date: Sun, 30 Aug 2020 08:52:41 -0300	[thread overview]
Message-ID: <CABczVwfQSZeBTJBdbp8uftwt+VnywrnXNbmA8LP9uf7mR1eeAQ@mail.gmail.com> (raw)
In-Reply-To: <jwv8sdw23dx.fsf-monnier+emacs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>>>> Or if eventually a defface or a defcustom makes its way into
>>>>> display-fill-column-indicator.el, of course.
>>>
>>> Actually, there is a defcustom there (in the expansion of
>>> `define-globalized-minor-mode`).
>>
>> Sorry, I wasn't clear enough.  There is no defcustom or defface whose
>> :group is display-fill-column-indicator.
>
> `global-display-fill-column-indicator-mode` should definitely belong to
> the `display-fill-column-indicator` group (because the `defcustom`
> doesn't have an explicit `:group` so it should fallback to using the
> last-defined group).

Is it, though?
emacs -Q
M-x customize-option RET global-display-fill-column-indicator-mode
And near the end of buffer I read:
Groups: Global Display Fill Column Indicator

Furthermore, the list
(global-display-fill-column-indicator-mode custom-variable) is not a
member of the custom-group property of display-fill-column-indicator.

> BTW, another quick-fix might be to move the defface definition to
> display-fill-column-indicator.el.

Right.

[-- Attachment #2: Type: text/html, Size: 1344 bytes --]

  reply	other threads:[~2020-08-30 11:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09  8:30 bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Philipp Stephani
2020-05-09  9:37 ` Eli Zaretskii
2020-05-09 12:31   ` Philipp Stephani
2020-08-28 14:48 ` Mauro Aranda
2020-08-29  6:54   ` Eli Zaretskii
2020-08-29 15:36     ` Stefan Monnier
2020-08-29 16:23       ` Mauro Aranda
2020-08-30  3:58         ` Stefan Monnier
2020-08-30 11:52           ` Mauro Aranda [this message]
2020-08-30 14:51             ` Stefan Monnier
2020-08-30 15:09               ` Eli Zaretskii
2020-08-30 17:03                 ` Stefan Monnier
2020-09-04  2:24                   ` Stefan Monnier
2020-09-04  7:09                     ` Eli Zaretskii
2020-09-04 12:47                       ` Stefan Monnier
2020-08-30 15:09               ` Drew Adams
2020-09-11 23:26               ` Michael Heerdegen
2020-09-12 15:43                 ` Stefan Monnier
2020-09-12 18:51                   ` Michael Heerdegen
2020-08-30 13:50           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABczVwfQSZeBTJBdbp8uftwt+VnywrnXNbmA8LP9uf7mR1eeAQ@mail.gmail.com \
    --to=maurooaranda@gmail.com \
    --cc=41145@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).