From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Date: Fri, 28 Aug 2020 11:48:57 -0300 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000cb499305adf12745" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11161"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41145@debbugs.gnu.org, Philipp Stephani To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 28 16:55:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBfmk-0002mP-9R for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Aug 2020 16:55:22 +0200 Original-Received: from localhost ([::1]:50344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBfmj-0002Lg-6n for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Aug 2020 10:55:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBfha-0001EZ-3b for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 10:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35568) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBfhZ-0000UK-OH for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 10:50:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kBfhZ-00063n-NA for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 10:50:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Aug 2020 14:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41145 X-GNU-PR-Package: emacs Original-Received: via spool by 41145-submit@debbugs.gnu.org id=B41145.159862615823238 (code B ref 41145); Fri, 28 Aug 2020 14:50:01 +0000 Original-Received: (at 41145) by debbugs.gnu.org; 28 Aug 2020 14:49:18 +0000 Original-Received: from localhost ([127.0.0.1]:47114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBfgr-00062k-OU for submit@debbugs.gnu.org; Fri, 28 Aug 2020 10:49:18 -0400 Original-Received: from mail-wr1-f50.google.com ([209.85.221.50]:43402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBfgp-00062X-T7 for 41145@debbugs.gnu.org; Fri, 28 Aug 2020 10:49:16 -0400 Original-Received: by mail-wr1-f50.google.com with SMTP id k15so1542371wrn.10 for <41145@debbugs.gnu.org>; Fri, 28 Aug 2020 07:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=5Tfe/dNQNMoZcRo7XCZ004U6L2JlnEBhXNlDvJdZxB8=; b=pCrL4Cvx7QvS+GbRMpnnwdeFwWRZKiDw8IzGGw9vgaIsZZJvcQqMZVmx/Wvh9uWEPU 7lWithVjb552YyrJDt7CRA4oe+wOVC8Sf0MMLECas/bWWpVwycPFUFyUVHS/AgDV6rh5 RRyBK+T72oe+9FCmKMbeN7NT0/zPIy9JwGNMHeBesLe/IsUxTw1UbArDT8d9VBP49eoH fASYi1H41Ft0sxx3kLMd1Lf0WDOzH7jEIXr/bdBtkkwwvnUVdH7RVV3tEv8zeh1LE9Zc KNkC/KFHnxfUa/ZgQOr6DUnXPEyez7hU6fI23I13Yg7ijaQtfGIWeUVwLMWD6Ts59/Cn T4gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=5Tfe/dNQNMoZcRo7XCZ004U6L2JlnEBhXNlDvJdZxB8=; b=G2B4RSmpcXGBvHihrQXe9ONf9/QV613oEqVOtOVdWRiURvqS+1hCpr3mYZYy+bgRGG 45nAwf9gRqSrMJ6C4W3bZCQFAzOJYy/YbGfDIZnfn1vW4O3kqIPI6O45cMyPywMH7+8N FzzSfYNUOhFQ0BbBgwIGFbcIYsdmeCxXvsP4BomwTy6Q4YcWqCZoM0JNt6NRlbi/VudY 3S+abV7q2CBqEYWECFwR1tqZWTraikEvKD1Wd+YYIbHtmr/sZdVEPdI2QOIFI8Vyg7Gq aOGx7xJnwWblcXL5rr7u1W5YIeOzwHrEh2AzsSkwuB2K6oyq55IDSDtdkf/LSmgB3H/E NcIQ== X-Gm-Message-State: AOAM530uKpWKn1/s21xSvgXIM2L/eO/BLDkgaGglcnvoD90nGx1ya7wR q0iDnlUqlAIcFWZPUz+OTgwL8m+wU5WtvlkddtI= X-Google-Smtp-Source: ABdhPJzqeeFwUKlnHG9d3d/P2ikjesTF3NOSvoWu4KSiUlU8YPPi2OFmxqwfrZcoeDYPbM3hdyf8O8s+dqtDLRDRRtM= X-Received: by 2002:adf:edca:: with SMTP id v10mr2001306wro.124.1598626149909; Fri, 28 Aug 2020 07:49:09 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186612 Archived-At: --000000000000cb499305adf12745 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: >> From: Philipp Stephani >> Date: Sat, 09 May 2020 10:30:13 +0200 >> >> The two issues here are: >> >> 1. "Group definition missing." It looks like customizing this group >> should load `display-fill-column-indicator-mode', which defines this >> group, or the group definition should be in cus-start.el. > The same seems to work for display-line-numbers, and I don't think I > see the crucial difference. I did some debugging and found that the difference is that there are no custom options or faces defined in display-fill-column-indicator.el: fill-column-indicator is in faces.el and display-fill-column-indicator, display-fill-column-indicator-character and display-fill-column-indicator-column are in xdisp.c custom-make-dependencies doesn't go through faces.el, since it's preloaded, so it doesn't record the custom-where property into fill-column-indicator. And since cus-dep.el doesn't require cus-start, fill-column-indicator is the only member of the custom-group property of display-fill-column-indicator, so there is no way custom-make-dependencies will record the custom-where property into any of the options defined in xdisp.c. So later on, when looking for a custom-where property in the members of the display-fill-column-indicator group, we find nothing, resulting in no custom-loads thingy for display-fill-column-indicator. The problem goes away if we require cus-start in cus-dep, or if we record into the custom-loads the file where to find the custom-group. That is, add in the first mapatoms call something like this: (when (get symbol 'custom-where) (push (get symbol 'custom-where) found)) Or if eventually a defface or a defcustom makes its way into display-fill-column-indicator.el, of course. Note that adding the above form will result in adding cus-edit to the custom-loads property of the groups defined in cus-edit (like editing, convenience, etc.). I don't know if that is harmless. --000000000000cb499305adf12745 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@gnu= .org> writes:

>> From: Philipp Stephani <p.stephani2@gmail.com>
>> Dat= e: Sat, 09 May 2020 10:30:13 +0200
>>
>> The two issues = here are:
>>
>> 1. "Group definition missing."= =C2=A0It looks like customizing this group
>> =C2=A0 =C2=A0should= load `display-fill-column-indicator-mode', which defines this
>&= gt; =C2=A0 =C2=A0group, or the group definition should be in cus-start.el.<= br>> The same seems to work for display-line-numbers, and I don't th= ink I
> see the crucial difference.

I did some debugging and f= ound that the difference is that there are no
custom options or faces de= fined in display-fill-column-indicator.el:
fill-column-indicator is in f= aces.el and
display-fill-column-indicator, display-fill-column-indicator= -character
and display-fill-column-indicator-column are in xdisp.c
custom-make-dependencies doesn't go through faces.el, since it's<= br>preloaded, so it doesn't record the custom-where property into
fi= ll-column-indicator.
And since cus-dep.el doesn't require cus-start,= fill-column-indicator is
the only member of the custom-group property o= f
display-fill-column-indicator, so there is no way
custom-make-depen= dencies will record the custom-where property into any
of the options de= fined in xdisp.c.

So later on, when looking for a custom-where prope= rty in the members of
the display-fill-column-indicator group, we find n= othing, resulting in
no custom-loads thingy for display-fill-column-indi= cator.

The problem goes away if we require cus-start in cus-dep, or = if we
record into the custom-loads the file where to find the custom-gro= up.
That is, add in the first mapatoms call something like this:
(whe= n (get symbol 'custom-where)
=C2=A0 (push (get symbol 'custom-wh= ere) found))

Or if eventually a defface or a defcustom makes its way= into
display-fill-column-indicator.el, of course.

Note that addi= ng the above form will result in adding cus-edit to the
custom-loads pro= perty of the groups defined in cus-edit (like editing,
convenience, etc.= ).=C2=A0 I don't know if that is harmless.
--000000000000cb499305adf12745--