From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#14398: 24.3.50; Customize: `Revert...' and `Apply' Date: Tue, 3 Nov 2020 12:22:50 -0300 Message-ID: References: <87blge4jiv.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005818fa05b33570b3" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12776"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 14398@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 03 16:32:32 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZyIQ-00039V-Vv for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Nov 2020 16:32:30 +0100 Original-Received: from localhost ([::1]:40068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZyIP-0007oj-Vr for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Nov 2020 10:32:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZyAE-0003ra-99 for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 10:24:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34523) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZyAD-0006Ak-QF for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 10:24:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZyAD-0001Kg-KD for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 10:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Nov 2020 15:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14398 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14398-submit@debbugs.gnu.org id=B14398.16044169905059 (code B ref 14398); Tue, 03 Nov 2020 15:24:01 +0000 Original-Received: (at 14398) by debbugs.gnu.org; 3 Nov 2020 15:23:10 +0000 Original-Received: from localhost ([127.0.0.1]:46069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZy9N-0001JX-Ox for submit@debbugs.gnu.org; Tue, 03 Nov 2020 10:23:09 -0500 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:43796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZy9M-0001JK-Of for 14398@debbugs.gnu.org; Tue, 03 Nov 2020 10:23:09 -0500 Original-Received: by mail-wr1-f41.google.com with SMTP id g12so18958939wrp.10 for <14398@debbugs.gnu.org>; Tue, 03 Nov 2020 07:23:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I3405gmpKAuwOK5adCvyxwsTlLiXwbf16j0Gep+s9Vc=; b=SjyRVJGrz6+BDcuBcmW3+YD8dJqqFKtpXqBrHtTluyff0spe8ElSUEWUieAuU2rEbV lnRHIFr4IMkBIDU+W7XCIYjwPDwmensZa6a8kcu0QRf01qcg22xa/ciKWTP/ZppSeII4 Uvqh609pTZE5NAi0ZLg8K1cpB2v0ogcfSgCv2uorp8tFHlIMCoKm/PifXm8gHt/QcL5K kccjcDZzS/yEGP+CzQROfRRz8SOeGcMnb2g6xWFcjsfYKc1L0nADHx9rdln2pxFYlw6P SHK30ZRwwBdXrF86ZCL7rokH6mu68Hg3oR7fi1PMID7ZsfwxVcmobBxDxsxz4VJPxbnt 3Fzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I3405gmpKAuwOK5adCvyxwsTlLiXwbf16j0Gep+s9Vc=; b=j65WIci2rHrQ+If4pV0xsEQqbx4dcUhhbx2h+wNd6R+CpAy4pFd30115BTYzYR2IWU sQtBiiPTslsmqa2CKt+FFcwomc8P4UScX9s106fKfLgzMqN6CLCHZr3LM2oLhLtOIIOm B64OXk8oxShuJ7kEFHuA9YbkTX3BFGdEj8DhJYJOkbDlIW4WmO4gCCJgK6U7L9v3gQLp toUgvd7FKSyt9fcfQ79H6uiRAsaCXDCJGTD2RFN+PdCIODKY4JGP3QugfohOAm3BMxlF Sa7RGWooFqN98DZJ7W+/Odc3GSB1viTXE9+b4LDL4jTkrIt57K4YXp2qbuvkiG4hEamk 7+RQ== X-Gm-Message-State: AOAM531RADCnYDam23OD/ZGCRoB7wu7ZP5JJSM8jdfFAhTgGA2VLhET7 7Enl0+iaW3iYUgxUVhQaB0jjUeEr+vRDLYtSE80= X-Google-Smtp-Source: ABdhPJxgPFsnGqP6zFykfxLvBjhY4gbisoZgO0lMUoe431tGSKzQWS42slNIB5rhIzeckQQHHjrv0sWIPmsoC8SanEA= X-Received: by 2002:adf:df03:: with SMTP id y3mr26738778wrl.70.1604416983012; Tue, 03 Nov 2020 07:23:03 -0800 (PST) In-Reply-To: <87blge4jiv.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192612 Archived-At: --0000000000005818fa05b33570b3 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> I think that toolbar icons and menu bar items should also be >> enabled/disabled according to the state of the options in the Custom >> buffer, so I propose a patch that adds logic to do that as well. > > I haven't tried the patch, but this makes sense to me. Thanks. Should I wait for further comments, or is it OK to push and see if anything comes up? I mean, I have tested the code quite a bit, but perhaps I should wait for comments about the code itself? --0000000000005818fa05b33570b3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Lars Ingebrigtsen <la= rsi@gnus.org> writes:

> Mauro Aranda <maurooaranda@gmail.com> writes:
>
= >> I think that toolbar icons and menu bar items should also be
&g= t;> enabled/disabled according to the state of the options in the Custom=
>> buffer, so I propose a patch that adds logic to do that as wel= l.
>
> I haven't tried the patch, but this makes sense to m= e.

Thanks.=C2=A0 Should I wait for further comments, or is it OK to = push and see
if anything comes up? I mean, I have tested the code quite = a bit, but
perhaps I should wait for comments about the code itself? --0000000000005818fa05b33570b3--