From: Mauro Aranda <maurooaranda@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Oleh Krehel <ohwoeowho@gmail.com>, 20664@debbugs.gnu.org
Subject: bug#20664: 25.0.50; Customize: Link option or face name to the source definition
Date: Thu, 17 Sep 2020 17:16:09 -0300 [thread overview]
Message-ID: <CABczVwf0RpHfSk1Dq1OW2iqFmCi848SBq2QwcktuC3cQFJCnwA@mail.gmail.com> (raw)
In-Reply-To: <0ef05975-f3ab-4601-81bb-e4fc17d0cb87@default>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Oleh Krehel <ohwoeowho@gmail.com> writes:
>
>> * lisp/cus-edit.el (custom-face-value-create): Make the face name into
>> a button that calls `find-face-definition'.
>
> [...]
>
>> + (setq opoint (point))
>> + ;; Face name (tag).
>> + (insert " " tag)
>> + (make-button opoint (point)
>> + 'follow-link t
>> + 'action (lambda (&rest _x) (find-face-definition symbol))))
>
> Makes sense to me. I tweaked it a bit before applying, though -- used
> insert-text-button for convenience.
>
Why a button.el button, and not a link widget? Using a button.el button
makes it look like TAB is inconsistent, because it skips the button, so
you can't get to the button by just pressing TAB.
And given there are links to which you can get to by pressing TAB, not
being able to reach this one makes it feel like something is wrong.
[-- Attachment #2: Type: text/html, Size: 1263 bytes --]
next prev parent reply other threads:[~2020-09-17 20:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 20:41 bug#20664: 25.0.50; Customize: Link option or face name to the source definition Drew Adams
2015-05-27 13:19 ` Oleh Krehel
2015-05-27 14:09 ` martin rudalics
2015-05-27 14:28 ` Oleh Krehel
2015-05-27 14:59 ` Drew Adams
2015-05-27 15:16 ` Oleh Krehel
2015-05-27 15:28 ` Drew Adams
2015-05-27 14:15 ` Drew Adams
2015-05-27 14:30 ` Oleh Krehel
2020-09-17 18:46 ` Lars Ingebrigtsen
2020-09-17 20:16 ` Mauro Aranda [this message]
2020-09-17 20:30 ` Drew Adams
2020-09-18 11:28 ` Lars Ingebrigtsen
2020-09-18 11:39 ` Mauro Aranda
2020-09-17 21:41 ` Mauro Aranda
2020-09-17 21:46 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABczVwf0RpHfSk1Dq1OW2iqFmCi848SBq2QwcktuC3cQFJCnwA@mail.gmail.com \
--to=maurooaranda@gmail.com \
--cc=20664@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=ohwoeowho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).