unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Mauro Aranda <maurooaranda@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18@debbugs.gnu.org
Subject: bug#18: Fine-grained revert-buffer
Date: Sat, 27 Apr 2019 14:46:50 -0300	[thread overview]
Message-ID: <CABczVwez0ZhgVY2CGkwgpo4KnO+_t2DfP5a6LtA3uTNPSONH5Q@mail.gmail.com> (raw)
In-Reply-To: <83h8ajv29z.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> Is there a requirement to be able to undo the revert piecemeal? What
> would be the use case for that?

Your questions made me open my eyes, so thanks.  I originally thought
that it would be a good thing, for example if the user wants to revert some
of the changes but keep others.  But that use case is already covered by
using diff-buffer-with-file, for example, and applying (or not) each hunk
separately.  Even better, the undo process doesn't have to be from
the Nth hunk to the 1st, in order.  So please, ignore what I said about
that problem, using replace-buffer-contents seems to be a great choice
to address this wishlist item.

>> I haven't timed it yet.  I didn't know if it would be considered good
>> enough, to time it.  For a week, I've been testing it manually with some
>> of the changes in the Emacs sources, and the experience has been
>> satisfactory.  Are there, by any chance, such tests for
>> replace-buffer-contents?
>
> You can find one in bug#31888.
>
> Also, this discussion:
>
>   http://lists.gnu.org/archive/html/help-gnu-emacs/2019-02/msg00000.html
>
> indicates that using JSON pretty-printer might produce a good test
> case.

Thanks.

I'll keep working on the potential fallback for replace-buffer-contents,
and report back when I feel I've made some progress.

Best regards,
Mauro.

[-- Attachment #2: Type: text/html, Size: 1754 bytes --]

  reply	other threads:[~2019-04-27 17:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <jwvpruii0xr.fsf@iro.umontreal.ca>
2013-12-17  3:16 ` bug#18: Fine-grained revert-buffer Dmitry Gutov
2013-12-17 13:32   ` Stefan Monnier
2018-04-12  6:21 ` Toon Claes
2018-04-12 12:18   ` Stefan Monnier
2018-04-14  7:00     ` Toon Claes
2018-04-14 14:14       ` Stefan Monnier
2019-04-26 22:42 ` Mauro Aranda
2019-04-27  7:34   ` Eli Zaretskii
2019-04-27 15:10     ` Mauro Aranda
2019-04-27 16:30       ` Eli Zaretskii
2019-04-27 17:46         ` Mauro Aranda [this message]
2019-04-29 12:49       ` martin rudalics
2019-05-02 15:54         ` Basil L. Contovounesios
2019-05-02 16:20           ` Glenn Morris
2019-05-02 16:23             ` Basil L. Contovounesios
2019-05-02 21:27           ` Richard Stallman
2019-05-03 14:05             ` Basil L. Contovounesios
2019-05-05 22:41               ` Richard Stallman
2019-04-27  8:31   ` martin rudalics
2019-04-28  2:47   ` Richard Stallman
2019-04-29 23:32     ` Mauro Aranda
2019-04-30  0:17       ` Mauro Aranda
2019-05-15 23:10         ` Mauro Aranda
2020-09-19 23:08           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABczVwez0ZhgVY2CGkwgpo4KnO+_t2DfP5a6LtA3uTNPSONH5Q@mail.gmail.com \
    --to=maurooaranda@gmail.com \
    --cc=18@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).