unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#36959: 26.2.50; Copypaste errors in pong docstrings
@ 2019-08-07 15:08 Mauro Aranda
  2019-08-07 15:11 ` Mauro Aranda
  0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2019-08-07 15:08 UTC (permalink / raw)
  To: 36959

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

Hello.

I found two minor docstring errors in pong.el.

Both pong-move-left and pong-move-right docstrings refer to the bat 2,
when they should say bat 1.  Also, pong-move-right says it moves the but
up, when actually it moves the bat down.

I'll attach a patch shortly.

Best regards,
Mauro.

[-- Attachment #2: Type: text/html, Size: 357 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#36959: 26.2.50; Copypaste errors in pong docstrings
  2019-08-07 15:08 bug#36959: 26.2.50; Copypaste errors in pong docstrings Mauro Aranda
@ 2019-08-07 15:11 ` Mauro Aranda
  2019-08-10  8:54   ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2019-08-07 15:11 UTC (permalink / raw)
  To: 36959


[-- Attachment #1.1: Type: text/plain, Size: 39 bytes --]

tags 36959 patch
quit

Patch attached.

[-- Attachment #1.2: Type: text/html, Size: 109 bytes --]

[-- Attachment #2: 0001-Fix-docstrings-in-pong.patch --]
[-- Type: text/x-patch, Size: 972 bytes --]

From c700ce0ebd6a4858dee4724f059a04a500933e12 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Wed, 7 Aug 2019 11:55:54 -0300
Subject: [PATCH] Fix docstrings in pong

* lisp/play/pong.el (pong-move-left pong-move-right): Refer to the
right bats and directions of movement.  (Bug#36959)
---
 lisp/play/pong.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/play/pong.el b/lisp/play/pong.el
index 555c193..13fe8b8 100644
--- a/lisp/play/pong.el
+++ b/lisp/play/pong.el
@@ -262,7 +262,7 @@ pong-init-buffer
 
 
 (defun pong-move-left ()
-  "Move bat 2 up.
+  "Move bat 1 up.
 This is called left for historical reasons, since in some pong
 implementations you move with left/right paddle."
   (interactive)
@@ -274,7 +274,7 @@ pong-move-left
 
 
 (defun pong-move-right ()
-  "Move bat 2 up."
+  "Move bat 1 down."
   (interactive)
   (if (< (+ pong-bat-player1 pong-bat-width) (1- pong-height))
       (and
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#36959: 26.2.50; Copypaste errors in pong docstrings
  2019-08-07 15:11 ` Mauro Aranda
@ 2019-08-10  8:54   ` Eli Zaretskii
  0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2019-08-10  8:54 UTC (permalink / raw)
  To: Mauro Aranda; +Cc: 36959-done

> From: Mauro Aranda <maurooaranda@gmail.com>
> Date: Wed, 7 Aug 2019 12:11:50 -0300
> 
> Patch attached.

Thanks, pushed to the emacs-26 branch.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-08-10  8:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-07 15:08 bug#36959: 26.2.50; Copypaste errors in pong docstrings Mauro Aranda
2019-08-07 15:11 ` Mauro Aranda
2019-08-10  8:54   ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).