From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#19999: 24.4; Selecting Mutiple Custom Themes Date: Mon, 6 Jan 2020 11:55:16 -0300 Message-ID: References: <87fv9ldpq4.wl-ded-law@ddoherty.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000ad58d5059b79d93f" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="176884"; mail-complaints-to="usenet@blaine.gmane.org" Cc: ded-law@ddoherty.net To: 19999@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 06 16:21:25 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ioUC5-000jum-6f for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Jan 2020 16:21:25 +0100 Original-Received: from localhost ([::1]:53398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioUC3-0005Me-EF for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Jan 2020 10:21:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48630) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioTnX-0007KR-Fp for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 09:56:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ioTnW-00088W-8Y for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 09:56:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40519) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ioTnW-00088R-3l for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 09:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ioTnW-0007TH-1W for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 09:56:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87fv9ldpq4.wl-ded-law@ddoherty.net> Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2020 14:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19999 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 19999-submit@debbugs.gnu.org id=B19999.157832253728702 (code B ref 19999); Mon, 06 Jan 2020 14:56:01 +0000 Original-Received: (at 19999) by debbugs.gnu.org; 6 Jan 2020 14:55:37 +0000 Original-Received: from localhost ([127.0.0.1]:46490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioTn7-0007Sr-42 for submit@debbugs.gnu.org; Mon, 06 Jan 2020 09:55:37 -0500 Original-Received: from mail-lf1-f41.google.com ([209.85.167.41]:40212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioTn5-0007Sd-5L for 19999@debbugs.gnu.org; Mon, 06 Jan 2020 09:55:35 -0500 Original-Received: by mail-lf1-f41.google.com with SMTP id i23so36565558lfo.7 for <19999@debbugs.gnu.org>; Mon, 06 Jan 2020 06:55:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=y6qKgr/oAajbG3a3XfTR+eCK7ahb/usKqcJMxBBubmU=; b=iA5JRJXQY1Jcp6aPSIPl/ASSfgswNrMzfrD1ne1lVkzn/GJhtsFUqQt6Wm4hB4yem3 Or81U18nS3AJ5iXAeFp9XC3EUX+ePqisj5Y03tNorjfjWyGAHJoztwrdKL545KZBXU/b orPEs/G1yWAr2aOAAA94VWi2EVDyd65eb+dDqdYZ+POuXKjjpy40ulFo+WqhwiNAmECT p3BbkvKfCSTCHOfN2zNTzO9nEp7sGuAyGGsQhY6sQvBiQetCxkogaAQ6GSaYIWl4n6S0 +3/qlBGWoYHXGRJj9aTiOmsh+GKmOyoAZe76lhDIut3Ogj9qQsB9ryQl1MWqWC2L6lDC eDxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=y6qKgr/oAajbG3a3XfTR+eCK7ahb/usKqcJMxBBubmU=; b=TCEr0cxOkkNAnn+uvxDSn6z3wbwCxurMSm0JSB6CFDkxc6h+jizzS8xNX8mL+NieQF uqfatzGLtLTmMOGWqvGGg4Gc7sW0k0uQAlo60H3anm5JOt4mUChbb5qcU4EJ1nfIbfV6 zXAju3042IqEEX28ZKjtuMfnR6Vt8CuCqf9/OHo0TIFZDkRUsLBfW5GLsvgjJ8aHTaQf iiF4fz0JlJz/kYvuShFnfd7zXMp0CCtsMWzb5zeukCyl1YY9scW2hXnzOZEjcX/QeTeL oSJ+ZmacZpuc8f447oXzMybOUrgqfs20JWmgX7mCs9Dm7U/jjyUIWq25sAG51FH0aHCs n+wg== X-Gm-Message-State: APjAAAXtowR81RuDfUoaGkaUcLaS5xQ9g0BrkDvTYywfrQkpHm9i93Gv b/ns35nj4wD6uqFUCBmHX6/X7onWtkb1cDLCAhxYc8fMLR0= X-Google-Smtp-Source: APXvYqwhVXmxrcDtla3BErfAYlKkvh8mdjmUQzqTcnPLLhg7tQOPc9WRBNEqboO4kVOVatOl0qsGDrQra14e/tQ44n8= X-Received: by 2002:a19:710a:: with SMTP id m10mr55876514lfc.58.1578322528911; Mon, 06 Jan 2020 06:55:28 -0800 (PST) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174237 Archived-At: --000000000000ad58d5059b79d93f Content-Type: multipart/alternative; boundary="000000000000ad58d2059b79d93d" --000000000000ad58d2059b79d93d Content-Type: text/plain; charset="UTF-8" tags 19999 patch thanks Daniel E. Doherty writes: > (customize-themes) > Check "Select more than one theme at a time" > Check "leuven" > Check "wombat" > Click "Save Theme Settings" > > Open custom.el > > Only one of the themes is enabled. I'm able to reproduce this on the release branch. enable-theme, which is called while setting custom-enabled-themes, destructively modifies custom-enabled-themes, thus affecting what will be stored in the 'saved-value property of custom-enabled-themes when saving it with custom-theme-save. One possible fix is to make the updating of custom-enabled-themes in enable-theme side-effect free, as the attached patch does. Best regards, Mauro. --000000000000ad58d2059b79d93d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
tags 19999 patch
thanks

<= /div>
Daniel E. Doherty <ded= -law@ddoherty.net> writes:

> (customize-themes)
> = Check "Select more than one theme at a time"
> Check "= leuven"
> Check "wombat"
> Click "Save Them= e Settings"
>
> Open custom.el
>
> Only one of= the themes is enabled.

I'm able to reproduce this on the releas= e branch.

enable-theme, which is called while setting custom-enabled= -themes,
destructively modifies custom-enabled-themes, thus affecting wh= at will
be stored in the 'saved-value property of custom-enabled-the= mes when
saving it with custom-theme-save.

One possible fix is to= make the updating of custom-enabled-themes in
enable-theme side-effect = free, as the attached patch does.

Best regards,
Mauro.
--000000000000ad58d2059b79d93d-- --000000000000ad58d5059b79d93f Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-saving-multiple-themes.patch" Content-Disposition: attachment; filename="0001-Fix-saving-multiple-themes.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k52k3s9e0 RnJvbSBiNjA0MzhmMTkzM2EzNmU1YWY1NTc0NWQ3Y2MyMTk5MGEwNmM2YTYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IE1vbiwgNiBKYW4gMjAyMCAxMTowNDoyOSAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIEZp eCBzYXZpbmcgbXVsdGlwbGUgdGhlbWVzCgoqIGxpc3AvY3VzdG9tLmVsIChlbmFibGUtdGhlbWUp OiBCZSBzaWRlLWVmZmVjdCBmcmVlIHdoZW4gbW9kaWZ5aW5nCmN1c3RvbS1lbmFibGVkLXRoZW1l cy4gIChCdWcjMTk5OTkpCi0tLQogbGlzcC9jdXN0b20uZWwgfCAyICstCiAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saXNwL2N1c3Rv bS5lbCBiL2xpc3AvY3VzdG9tLmVsCmluZGV4IDAzN2Y2YzUuLjg4NWM0ODYgMTAwNjQ0Ci0tLSBh L2xpc3AvY3VzdG9tLmVsCisrKyBiL2xpc3AvY3VzdG9tLmVsCkBAIC0xMzgxLDcgKzEzODEsNyBA QCBlbmFibGUtdGhlbWUKIAkgICAgKGN1c3RvbS10aGVtZS1yZWNhbGMtdmFyaWFibGUgc3ltYm9s KSkpKSkpKQogICAodW5sZXNzIChlcSB0aGVtZSAndXNlcikKICAgICAoc2V0cSBjdXN0b20tZW5h YmxlZC10aGVtZXMKLQkgIChjb25zIHRoZW1lIChkZWxxIHRoZW1lIGN1c3RvbS1lbmFibGVkLXRo ZW1lcykpKQorCSAgKGNvbnMgdGhlbWUgKHJlbXEgdGhlbWUgY3VzdG9tLWVuYWJsZWQtdGhlbWVz KSkpCiAgICAgOzsgR2l2ZSB0aGUgYHVzZXInIHRoZW1lIHRoZSBoaWdoZXN0IHByaW9yaXR5Lgog ICAgIChlbmFibGUtdGhlbWUgJ3VzZXIpKSkKIAotLSAKMi43LjQKCg== --000000000000ad58d5059b79d93f--