From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#14398: 24.3.50; Customize: `Revert...' and `Apply' Date: Tue, 3 Nov 2020 10:56:32 -0300 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000b442df05b3343b6a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5376"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 14398@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 03 14:57:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZwoA-0001HY-Af for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Nov 2020 14:57:10 +0100 Original-Received: from localhost ([::1]:52352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZwo9-0004NK-Ay for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Nov 2020 08:57:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZwo2-0004Mp-D2 for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 08:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60555) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZwo2-0001Ie-0B for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 08:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZwo1-0002oh-Vn for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 08:57:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Nov 2020 13:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14398 X-GNU-PR-Package: emacs Original-Received: via spool by 14398-submit@debbugs.gnu.org id=B14398.160441181410815 (code B ref 14398); Tue, 03 Nov 2020 13:57:01 +0000 Original-Received: (at 14398) by debbugs.gnu.org; 3 Nov 2020 13:56:54 +0000 Original-Received: from localhost ([127.0.0.1]:43868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZwnt-0002oH-Pg for submit@debbugs.gnu.org; Tue, 03 Nov 2020 08:56:54 -0500 Original-Received: from mail-wm1-f47.google.com ([209.85.128.47]:36237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZwnq-0002nt-Uq for 14398@debbugs.gnu.org; Tue, 03 Nov 2020 08:56:51 -0500 Original-Received: by mail-wm1-f47.google.com with SMTP id e2so12884370wme.1 for <14398@debbugs.gnu.org>; Tue, 03 Nov 2020 05:56:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=X8zTsKElb+AMYbUJeR+3/zjYyFzcYzYcTKlaWQ9DzzI=; b=mNQdx77ASjKAlKgAmBFGbiBk6ZRpW6GYtGdt63ZyuzZzGwn2unGXLJgsy7kxISW1Tz gUB91vxRzUzSH/lEKXPWHCvliUxWDypGDmWmsC/QIrjn/VcCgBYpvSgOKk0dXIXB5KAr yJhrYkBdE3+779xNe36cMj6woDbNuGUYgbgviUuEJUK1ZxeeUkoM/okVIjZfqYRutap4 H+qp1WlqMib8hAbBUn1biaMTCCvLTKnhBRb/qUXZJXPeuzDgd+kBTxdNNaoniiPD4yQr DsphGVoS8s/pr9FDE5nQ+RBFoKAOOqib92kM2DU6Sbk1m6yPzuwwUXRachQ+fbcSNkwt fqZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=X8zTsKElb+AMYbUJeR+3/zjYyFzcYzYcTKlaWQ9DzzI=; b=JtCfBZrRwKnETjgNZHgqvxQYt7WhidsiXQud+APUohLuOmlUC0+jzzgY3/4nbJDUuw fUuANgdKeLwsJwMg4PAUDTP+BXpKPVl/pc+KMduPwe/JgxQDfYvrDiDiD76nfIeU0dxD rGPui8RNaRj+XpQ1ZQOEPLfxxuKDU8Sj7LWF+lqXcaZY3l3Xp70Pork2zXfMkljEuPXi +I/Ln9OuZK7y43W13dA4V+w0kaB5iWxMIk7NEzsAR5TsLOKgl/ZvjXJmqOLnzvq4Kq8a Jhr2aurFsy/8gF0bdkjeRc3QTzlT0vw+/PN3rajc1pghsZpaitLTObJkFys1hhahYRLb 3A6Q== X-Gm-Message-State: AOAM532NM/rsSxR5bamm8SJTFl8b6BrUio4pd6XHERbUOKgG3tItSj6w Kt0IqW3Jqe9Q4rLxzcZskNC/GY9BHFaWWMwejmw= X-Google-Smtp-Source: ABdhPJzfCv0Xoh1XyWF175jN8tBM8XOST40l31eu/WbhS/qIE33mHjfOj94agO7BofFqrmaKmNEotw+vTuwvt9zwd0k= X-Received: by 2002:a1c:20c6:: with SMTP id g189mr3946462wmg.6.1604411804886; Tue, 03 Nov 2020 05:56:44 -0800 (PST) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192603 Archived-At: --000000000000b442df05b3343b6a Content-Type: multipart/alternative; boundary="000000000000b442dc05b3343b68" --000000000000b442dc05b3343b68 Content-Type: text/plain; charset="UTF-8" tags 14398 patch quit "Drew Adams" writes: > 1. The `Revert...' menu items should be controled by either :enable or > :visible. It makes no sense to show a user an active menu item `Undo > Edits in Customization Buffer' if there have been no edits. After a > user clicks this, undoing any edits, this menu item should disappear or > be dimmed. Similarly for other menu items. Now that widget-choose supports extended menus, this can be done like in Bug#4787. > 2. `Apply' is not helpful as is. The name does not sufficiently > indicate what it does (apply what? to what?). The help echo is also not > helpful enough: `Apply settings (for current session only)'. What > settings? While "Apply" might not be helpful, I think that the help-echo answers the questions. And I'd say it is evident that it talks about the settings the user is seeing in the Custom buffer at that moment. > And again, if no settings have been changed (edited) then > this button should not even be available. Its presence when it is a > no-op just confuses. Makes sense to me. And this can be easily controlled by activating and deactivating the widgets. I think that toolbar icons and menu bar items should also be enabled/disabled according to the state of the options in the Custom buffer, so I propose a patch that adds logic to do that as well. --000000000000b442dc05b3343b68 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
tags 14398 patch
quit

&qu= ot;Drew Adams" <drew.adams= @oracle.com> writes:

> 1. The `Revert...' menu items= should be controled by either :enable or
> :visible.=C2=A0 It makes = no sense to show a user an active menu item `Undo
> Edits in Customiz= ation Buffer' if there have been no edits.=C2=A0 After a
> user c= licks this, undoing any edits, this menu item should disappear or
> b= e dimmed.=C2=A0 Similarly for other menu items.

Now that widget-choo= se supports extended menus, this can be done like in
Bug#4787.

&g= t; 2. `Apply' is not helpful as is.=C2=A0 The name does not sufficientl= y
> indicate what it does (apply what? to what?).=C2=A0 The help echo= is also not
> helpful enough: `Apply settings (for current session o= nly)'.=C2=A0 What
> settings?

While "Apply" migh= t not be helpful, I think that the help-echo
answers the questions.=C2= =A0 And I'd say it is evident that it talks about
the settings the u= ser is seeing in the Custom buffer at that moment.

> And again, i= f no settings have been changed (edited) then
> this button should no= t even be available.=C2=A0 Its presence when it is a
> no-op just con= fuses.

Makes sense to me.=C2=A0 And this can be easily controlled by= activating and
deactivating the widgets.

I think that toolbar ic= ons and menu bar items should also be
enabled/disabled according to the = state of the options in the Custom
buffer, so I propose a patch that add= s logic to do that as well.
--000000000000b442dc05b3343b68-- --000000000000b442df05b3343b6a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Enable-disable-buttons-tool-bar-and-menu-items-in-Cu.patch" Content-Disposition: attachment; filename="0001-Enable-disable-buttons-tool-bar-and-menu-items-in-Cu.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kh21c0p50 RnJvbSA4NjNhYmU0ZmNhZDVjYjU2MGVkNTFiNmYwYTgyZGM5ZTBkZDU4NDQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IFR1ZSwgMTggQXVnIDIwMjAgMTI6NTA6MTcgLTAzMDAKU3ViamVjdDogW1BBVENIXSBF bmFibGUvZGlzYWJsZSBidXR0b25zLCB0b29sIGJhciBhbmQgbWVudSBpdGVtcyBpbiBDdXN0b20K IGJ1ZmZlciAoQnVnIzE0Mzk4KQoKKiBsaXNwL2N1cy1lZGl0LmVsIChjdXN0b20tcmVzZXQtZXh0 ZW5kZWQtbWVudSk6IEtleW1hcCBtZW51IGZvciB0aGUKUmV2ZXJ0Li4uIG1lbnUgYnV0dG9uLgoo Y3VzdG9tLXJlc2V0LW1lbnUpOiBLZWVwIGZvciBiYWNrd2FyZCBjb21wYXRpYmlsaXR5LCBidXQg ZGVmYXVsdCB0bwpuaWwsIHNvIHdlIHByZWZlciB0aGUga2V5bWFwIG1lbnUgaW5zdGVhZC4KKGN1 c3RvbS1yZXNldCk6IFBhc3MgdGhlIG5ldyBrZXltYXAgbWVudSB0byB3aWRnZXQtY2hvb3NlLgoK KGN1c3RvbS1jb21tYW5kcyk6IEFkZCBhbiBlbGVtZW50IHRvIGVhY2ggbGlzdCBpdGVtLCB0byBt YW5hZ2UgaXRzCmVuYWJsZS9kaXNhYmxlIHN0YXRlLiAgQWRkIGRvY3N0cmluZy4KKGN1c3RvbS1j b21tYW5kLWJ1dHRvbnMpOiBOZXcgdmFyaWFibGUsIHRvIGhvbGQgdGhlIGJ1dHRvbnMgdGhhdCBh Y3QKb24gYWxsIG9wdGlvbnMgaW4gYSBDdXN0b20gYnVmZmVyLgooY3VzdG9tLWJ1ZmZlci1jcmVh dGUtaW50ZXJuYWwpOiBXaGVuIGNyZWF0aW5nIHRoZSBjb21tYW5kIGJ1dHRvbnMsCmFkZCB0aGUg b3B0aW9uYWwgOm5vdGlmeSBmdW5jdGlvbiB0byBlbmFibGUvZGlzYWJsZSB0aGVtLiAgQWRkIHRo ZQpidXR0b25zIHRvIHRoZSBuZXcgdmFyaWFibGUgY3VzdG9tLWNvbW1hbmQtYnV0dG9ucy4KKGN1 c3RvbWl6ZS1tZW51LWNyZWF0ZSk6IEFkZCBhbiA6YWN0aXZlIGZvcm0gdG8gdGhlIHZlY3RvciBw YXNzZWQgdG8KdG9vbC1iYXItbG9jYWwtaXRlbS1mcm9tLW1lbnUsIHNvIGJ1dHRvbnMgY2FuIGJl IGVuYWJsZWQvZGlzYWJsZWQuCihjdXN0b20tYnVmZmVyLWNyZWF0ZSk6IE5vdGlmeSB0aGUgY29t bWFuZCBidXR0b25zIGFmdGVyIGNyZWF0aW5nIHRoZQpDdXN0b20gYnVmZmVyLCBzbyB0aGV5IGFy ZSBjb3JyZWN0bHkgZW5hYmxlZC9kaXNhYmxlZC4KKGN1c3RvbS1yZWRyYXctbWFnaWMsIGN1c3Rv bS1ub3RpZnkpOiBOb3RpZnkgdGhlIGNvbW1hbmQgYnV0dG9ucyBhbmQKdXBkYXRlIHRoZSB0b29s IGJhciB3aGVuIGNoYW5naW5nIGEgd2lkZ2V0IHRvIHRoZSBtb2RpZmllZCBzdGF0ZS4KLS0tCiBs aXNwL2N1cy1lZGl0LmVsIHwgMTQ4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTEwIGluc2VydGlvbnMoKyksIDM4IGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvY3VzLWVkaXQuZWwgYi9saXNwL2N1cy1lZGl0LmVs CmluZGV4IDM0ZDc2YmYwOTYuLmQxMDc3ZDM2N2QgMTAwNjQ0Ci0tLSBhL2xpc3AvY3VzLWVkaXQu ZWwKKysrIGIvbGlzcC9jdXMtZWRpdC5lbApAQCAtNzMwLDQ4ICs3MzAsODYgQEAgY3VzdG9tLXNv cnQtaXRlbXMKIDs7IGBjdXN0b20tYnVmZmVyLWNyZWF0ZS1pbnRlcm5hbCcgaWYgYGN1c3RvbS1i dWZmZXItdmVyYm9zZS1oZWxwJyBpcyBub24tbmlsLgogCiAoZGVmdmFyIGN1c3RvbS1jb21tYW5k cwotICAnKCgiIEFwcGx5ICIgQ3VzdG9tLXNldCB0Ci0gICAgICJBcHBseSBzZXR0aW5ncyAoZm9y IHRoZSBjdXJyZW50IHNlc3Npb24gb25seSkuIgotICAgICAiaW5kZXgiCi0gICAgICJBcHBseSIp Ci0gICAgKCIgQXBwbHkgYW5kIFNhdmUgIiBDdXN0b20tc2F2ZQotICAgICAob3IgY3VzdG9tLWZp bGUgdXNlci1pbml0LWZpbGUpCi0gICAgICJBcHBseSBzZXR0aW5ncyBhbmQgc2F2ZSBmb3IgZnV0 dXJlIHNlc3Npb25zLiIKLSAgICAgInNhdmUiCi0gICAgICJTYXZlIikKKyAgJygoIiBBcHBseSAi IEN1c3RvbS1zZXQgdCAiQXBwbHkgc2V0dGluZ3MgKGZvciB0aGUgY3VycmVudCBzZXNzaW9uIG9u bHkpLiIKKyAgICAgImluZGV4IiAiQXBwbHkiIChtb2RpZmllZCkpCisgICAgKCIgQXBwbHkgYW5k IFNhdmUgIiBDdXN0b20tc2F2ZSAob3IgY3VzdG9tLWZpbGUgdXNlci1pbml0LWZpbGUpCisgICAg ICJBcHBseSBzZXR0aW5ncyBhbmQgc2F2ZSBmb3IgZnV0dXJlIHNlc3Npb25zLiIgInNhdmUiICJT YXZlIgorICAgICAobW9kaWZpZWQgc2V0IGNoYW5nZWQgcm9ndWUpKQogICAgICgiIFVuZG8gRWRp dHMgIiBDdXN0b20tcmVzZXQtY3VycmVudCB0CiAgICAgICJSZXN0b3JlIGN1c3RvbWl6YXRpb24g YnVmZmVyIHRvIHJlZmxlY3QgZXhpc3Rpbmcgc2V0dGluZ3MuIgotICAgICAicmVmcmVzaCIKLSAg ICAgIlVuZG8iKQorICAgICAicmVmcmVzaCIgIlVuZG8iIChtb2RpZmllZCkpCiAgICAgKCIgUmVz ZXQgQ3VzdG9taXphdGlvbnMgIiBDdXN0b20tcmVzZXQtc2F2ZWQgdAotICAgICAiVW5kbyBhbnkg c2V0dGluZ3MgYXBwbGllZCBvbmx5IGZvciB0aGUgY3VycmVudCBzZXNzaW9uLiIKLSAgICAgInVu ZG8iCi0gICAgICJSZXNldCIpCisgICAgICJVbmRvIGFueSBzZXR0aW5ncyBhcHBsaWVkIG9ubHkg Zm9yIHRoZSBjdXJyZW50IHNlc3Npb24uIiAidW5kbyIgIlJlc2V0IgorICAgICAobW9kaWZpZWQg c2V0IGNoYW5nZWQgcm9ndWUpKQogICAgICgiIEVyYXNlIEN1c3RvbWl6YXRpb25zICIgQ3VzdG9t LXJlc2V0LXN0YW5kYXJkCiAgICAgIChvciBjdXN0b20tZmlsZSB1c2VyLWluaXQtZmlsZSkKLSAg ICAgIlVuLWN1c3RvbWl6ZSBzZXR0aW5ncyBpbiB0aGlzIGFuZCBmdXR1cmUgc2Vzc2lvbnMuIgot ICAgICAiZGVsZXRlIgotICAgICAiVW5jdXN0b21pemUiKQotICAgICgiIEhlbHAgZm9yIEN1c3Rv bWl6ZSAiIEN1c3RvbS1oZWxwIHQKLSAgICAgIkdldCBoZWxwIGZvciB1c2luZyBDdXN0b21pemUu IgotICAgICAiaGVscCIKLSAgICAgIkhlbHAiKQotICAgICgiIEV4aXQgIiBDdXN0b20tYnVmZmVy LWRvbmUgdCAiRXhpdCBDdXN0b21pemUuIiAiZXhpdCIgIkV4aXQiKSkpCisgICAgICJVbi1jdXN0 b21pemUgc2V0dGluZ3MgaW4gdGhpcyBhbmQgZnV0dXJlIHNlc3Npb25zLiIgImRlbGV0ZSIgIlVu Y3VzdG9taXplIgorICAgICAobW9kaWZpZWQgc2V0IGNoYW5nZWQgcm9ndWUgc2F2ZWQpKQorICAg ICgiIEhlbHAgZm9yIEN1c3RvbWl6ZSAiIEN1c3RvbS1oZWxwIHQgIkdldCBoZWxwIGZvciB1c2lu ZyBDdXN0b21pemUuIgorICAgICAiaGVscCIgIkhlbHAiIHQpCisgICAgKCIgRXhpdCAiIEN1c3Rv bS1idWZmZXItZG9uZSB0ICJFeGl0IEN1c3RvbWl6ZS4iICJleGl0IiAiRXhpdCIgdCkpCisgICJB bGlzdCBvZiBzcGVjaWZpY2F0aW9ucyBmb3IgQ3VzdG9taXplIG1lbnUgaXRlbXMsIHRvb2wgYmFy IGljb25zIGFuZCBidXR0b25zLgorRWFjaCBtZW1iZXIgaGFzIHRoZSBmb3JtYXQgKFRBRyBDT01N QU5EIFZJU0lCTEUgSEVMUCBJQ09OIExBQkVMIEVOQUJMRSkuCitUQUcgaXMgYSBzdHJpbmcsIHVz ZWQgYXMgdGhlIDp0YWcgcHJvcGVydHkgb2YgYSB3aWRnZXQuCitDT01NQU5EIGlzIHRoZSBjb21t YW5kIHRoYXQgdGhlIGl0ZW0gb3IgYnV0dG9uIHJ1bnMuCitWSVNJQkxFIHNob3VsZCBiZSBhIGZv cm0sIHN1aXRhYmxlIHRvIHBhc3MgYXMgdGhlIDp2aXNpYmxlIHByb3BlcnR5IGZvciBtZW51Citv ciB0b29sIGJhciBpdGVtcy4KK0hFTFAgc2hvdWxkIGJlIGEgc3RyaW5nIHRoYXQgY2FuIGJlIHVz ZWQgYXMgdGhlIGhlbHAgZWNobyBwcm9wZXJ0eSBmb3IgdG9vbHRpcHMKK2FuZCB0aGUgbGlrZS4K K0lDT04gaXMgYSBzdHJpbmcgdGhhdCBuYW1lcyB0aGUgaW1hZ2UgdG8gdXNlIGZvciB0aGUgdG9v bCBiYXIgaXRlbSwgbGlrZSBpbiB0aGUKK2ZpcnN0IGFyZ3VtZW50IG9mIGB0b29sLWJhci1sb2Nh bC1pdGVtJy4KK0xBQkVMIHNob3VsZCBiZSBhIHN0cmluZywgdXNlZCBhcyB0aGUgbmFtZSBvZiB0 aGUgbWVudSBpdGVtcy4KK0VOQUJMRSBzaG91bGQgYmUgYSBsaXN0IG9mIGN1c3RvbSBzdGF0ZXMg b3IgdC4gIFdoZW4gRU5BQkxFIGlzIHQsIHRoZSBpdGVtIGlzCithbHdheXMgZW5hYmxlZC4gIE90 aGVyd2lzZSwgaXQgaXMgZW5hYmxlZCBvbmx5IGlmIGF0IGxlYXN0IG9uZSBvcHRpb24gZGlzcGxh eWVkCitpbiB0aGUgQ3VzdG9tIGJ1ZmZlciBpcyBpbiBhIHN0YXRlIHByZXNlbnQgaW4gRU5BQkxF LiIpCisKKyhkZWZ2YXItbG9jYWwgY3VzdG9tLWNvbW1hbmQtYnV0dG9ucyBuaWwKKyAgIkEgbGlz dCB0aGF0IGhvbGRzIHRoZSBidXR0b25zIHRoYXQgYWN0IG9uIGFsbCBzZXR0aW5ncyBpbiBhIEN1 c3RvbSBidWZmZXIuCitgY3VzdG9tLWJ1ZmZlci1jcmVhdGUtaW50ZXJuYWwnIGFkZHMgdGhlIGJ1 dHRvbnMgdG8gdGhpcyBsaXN0LgorQ2hhbmdlcyBpbiB0aGUgc3RhdGUgb2YgdGhlIGN1c3RvbSBv cHRpb25zIHNob3VsZCBub3RpZnkgdGhlIGJ1dHRvbnMgdmlhIHRoZQorOm5vdGlmeSBwcm9wZXJ0 eSwgc28gYnV0dG9ucyBjYW4gYmUgZW5hYmxlZC9kaXNhYmxlZCBjb3JyZWN0bHkgYXQgYWxsIHRp bWVzLiIpCiAKIChkZWZ1biBDdXN0b20taGVscCAoKQogICAiUmVhZCB0aGUgbm9kZSBvbiBFYXN5 IEN1c3RvbWl6YXRpb24gaW4gdGhlIEVtYWNzIG1hbnVhbC4iCiAgIChpbnRlcmFjdGl2ZSkKICAg KGluZm8gIihlbWFjcylFYXN5IEN1c3RvbWl6YXRpb24iKSkKIAotKGRlZnZhciBjdXN0b20tcmVz ZXQtbWVudQotICAnKCgiVW5kbyBFZGl0cyBpbiBDdXN0b21pemF0aW9uIEJ1ZmZlciIgLiBDdXN0 b20tcmVzZXQtY3VycmVudCkKLSAgICAoIlJldmVydCBUaGlzIFNlc3Npb24ncyBDdXN0b21pemF0 aW9ucyIgLiBDdXN0b20tcmVzZXQtc2F2ZWQpCi0gICAgKCJFcmFzZSBDdXN0b21pemF0aW9ucyIg LiBDdXN0b20tcmVzZXQtc3RhbmRhcmQpKQotICAiQWxpc3Qgb2YgYWN0aW9ucyBmb3IgdGhlIGBS ZXNldCcgYnV0dG9uLgorKGRlZnZhciBjdXN0b20tcmVzZXQtbWVudSBuaWwKKyAgIklmIG5vbi1u aWwsIGFuIGFsaXN0IG9mIGFjdGlvbnMgZm9yIHRoZSBgUmVzZXQnIGJ1dHRvbi4KKworVGhpcyB2 YXJpYWJsZSBpcyBrZXB0IGZvciBiYWNrd2FyZCBjb21wYXRpYmlsaXR5IHJlYXNvbnMsIHBsZWFz ZSB1c2UKK2BjdXN0b20tcmVzZXQtZXh0ZW5kZWQtbWVudScgaW5zdGVhZC4KKwogVGhlIGtleSBp cyBhIHN0cmluZyBjb250YWluaW5nIHRoZSBuYW1lIG9mIHRoZSBhY3Rpb24sIHRoZSB2YWx1ZSBp cyBhCiBMaXNwIGZ1bmN0aW9uIHRha2luZyB0aGUgd2lkZ2V0IGFzIGFuIGVsZW1lbnQgd2hpY2gg d2lsbCBiZSBjYWxsZWQKIHdoZW4gdGhlIGFjdGlvbiBpcyBjaG9zZW4uIikKIAorKGRlZnZhciBj dXN0b20tcmVzZXQtZXh0ZW5kZWQtbWVudQorICAobGV0ICgobWFwIChtYWtlLXNwYXJzZS1rZXlt YXApKSkKKyAgICAoZGVmaW5lLWtleS1hZnRlciBtYXAgW0N1c3RvbS1yZXNldC1jdXJyZW50XQor ICAgICAgJyhtZW51LWl0ZW0gIlVuZG8gRWRpdHMgaW4gQ3VzdG9taXphdGlvbiBCdWZmZXIiIEN1 c3RvbS1yZXNldC1jdXJyZW50CisgICAgICAgICAgICAgICAgICA6ZW5hYmxlIChzZXEtc29tZSAo bGFtYmRhIChvcHRpb24pCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChl cSAod2lkZ2V0LWdldCBvcHRpb24gOmN1c3RvbS1zdGF0ZSkKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICdtb2RpZmllZCkpCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjdXN0b20tb3B0aW9ucykpKQorICAgIChkZWZpbmUta2V5LWFmdGVyIG1h cCBbQ3VzdG9tLXJlc2V0LXNhdmVkXQorICAgICAgJyhtZW51LWl0ZW0gIlJldmVydCBUaGlzIFNl c3Npb24ncyBDdXN0b21pemF0aW9ucyIgQ3VzdG9tLXJlc2V0LXNhdmVkCisgICAgICAgICAgICAg ICAgICA6ZW5hYmxlIChzZXEtc29tZSAobGFtYmRhIChvcHRpb24pCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIChtZW1xICh3aWRnZXQtZ2V0IG9wdGlvbiA6Y3VzdG9tLXN0 YXRlKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyhtb2RpZmll ZCBzZXQgY2hhbmdlZCByb2d1ZSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY3VzdG9tLW9wdGlvbnMpKSkKKyAgICAod2hlbiAob3IgY3VzdG9tLWZpbGUgdXNlci1pbml0 LWZpbGUpCisgICAgICAoZGVmaW5lLWtleS1hZnRlciBtYXAgW0N1c3RvbS1yZXNldC1zdGFuZGFy ZF0KKyAgICAgICAgJyhtZW51LWl0ZW0gIkVyYXNlIEN1c3RvbWl6YXRpb25zIiBDdXN0b20tcmVz ZXQtc3RhbmRhcmQKKyAgICAgICAgICAgICAgICAgICAgOmVuYWJsZSAoc2VxLXNvbWUKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKGxhbWJkYSAob3B0aW9uKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChtZW1xICh3aWRnZXQtZ2V0IG9wdGlvbiA6Y3VzdG9tLXN0YXRlKQor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcobW9kaWZpZWQgc2V0IGNoYW5n ZWQgcm9ndWUgc2F2ZWQpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY3VzdG9tLW9w dGlvbnMpKSkpCisgICAgbWFwKQorICAiQSBtZW51IGZvciB0aGUgXCJSZXZlcnQuLi5cIiBidXR0 b24uCitVc2VkIGluIGBjdXN0b20tcmVzZXQnIHRvIHNob3cgYSBtZW51IHRvIHRoZSB1c2VyLiIp CisKIChkZWZ2YXIgY3VzdG9tLW9wdGlvbnMgbmlsCiAgICJDdXN0b21pemF0aW9uIHdpZGdldHMg aW4gdGhlIGN1cnJlbnQgYnVmZmVyLiIpCiAKQEAgLTgyMSw3ICs4NTksOCBAQCBjdXN0b20tcmVz ZXQKICAgIlNlbGVjdCBpdGVtIGZyb20gcmVzZXQgbWVudS4iCiAgIChsZXQqICgoY29tcGxldGlv bi1pZ25vcmUtY2FzZSB0KQogCSAoYW5zd2VyICh3aWRnZXQtY2hvb3NlICJSZXNldCBzZXR0aW5n cyIKLQkJCQljdXN0b20tcmVzZXQtbWVudQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAob3IgY3VzdG9tLXJlc2V0LW1lbnUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGN1c3RvbS1yZXNldC1leHRlbmRlZC1tZW51KQogCQkJCWV2ZW50KSkpCiAgICAgKGlmIGFu c3dlcgogCShmdW5jYWxsIGFuc3dlcikpKSkKQEAgLTE1NTUsNyArMTU5NCwxMCBAQCBjdXN0b20t YnVmZmVyLWNyZWF0ZQogREVTQ1JJUFRJT04gaXMgdW51c2VkLiIKICAgKHBvcC10by1idWZmZXIt c2FtZS13aW5kb3cKICAgIChjdXN0b20tZ2V0LWZyZXNoLWJ1ZmZlciAob3IgbmFtZSAiKkN1c3Rv bWl6YXRpb24qIikpKQotICAoY3VzdG9tLWJ1ZmZlci1jcmVhdGUtaW50ZXJuYWwgb3B0aW9ucykp CisgIChjdXN0b20tYnVmZmVyLWNyZWF0ZS1pbnRlcm5hbCBvcHRpb25zKQorICA7OyBOb3RpZnkg dGhlIGNvbW1hbmQgYnV0dG9ucywgdG8gY29ycmVjdGx5IGVuYWJsZS9kaXNhYmxlIHRoZW0uCisg IChkb2xpc3QgKGJ0biBjdXN0b20tY29tbWFuZC1idXR0b25zKQorICAgICh3aWRnZXQtYXBwbHkg YnRuIDpub3RpZnkpKSkKIAogOzs7IyMjYXV0b2xvYWQKIChkZWZ1biBjdXN0b20tYnVmZmVyLWNy ZWF0ZS1vdGhlci13aW5kb3cgKG9wdGlvbnMgJm9wdGlvbmFsIG5hbWUgX2Rlc2NyaXB0aW9uKQpA QCAtMTY3MiwxMSArMTcxNCwyNCBAQCBjdXN0b20tYnVmZmVyLWNyZWF0ZS1pbnRlcm5hbAogICAg IChpZiBjdXN0b20tYnVmZmVyLXZlcmJvc2UtaGVscAogCSh3aWRnZXQtaW5zZXJ0ICIKIE9wZXJh dGUgb24gYWxsIHNldHRpbmdzIGluIHRoaXMgYnVmZmVyOlxuIikpCi0gICAgKGxldCAoKGJ1dHRv biAobGFtYmRhICh0YWcgYWN0aW9uIGFjdGl2ZSBoZWxwIF9pY29uIF9sYWJlbCkKKyAgICAobGV0 ICgoYnV0dG9uIChsYW1iZGEgKHRhZyBhY3Rpb24gdmlzaWJsZSBoZWxwIF9pY29uIF9sYWJlbCBh Y3RpdmUpCiAJCSAgICAod2lkZ2V0LWluc2VydCAiICIpCi0JCSAgICAoaWYgKGV2YWwgYWN0aXZl KQotCQkJKHdpZGdldC1jcmVhdGUgJ3B1c2gtYnV0dG9uIDp0YWcgdGFnCi0JCQkJICAgICAgIDpo ZWxwLWVjaG8gaGVscCA6YWN0aW9uIGFjdGlvbikpKSkKKyAgICAgICAgICAgICAgICAgICAgKGlm IChldmFsIHZpc2libGUpCisgICAgICAgICAgICAgICAgICAgICAgICAocHVzaCAod2lkZ2V0LWNy ZWF0ZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdwdXNoLWJ1dHRvbiA6dGFnIHRh ZworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDpoZWxwLWVjaG8gaGVscCA6YWN0aW9u IGFjdGlvbgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDpub3RpZnkKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAobGFtYmRhICh3aWRnZXQpCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAod2hlbiAobGlzdHAgYWN0aXZlKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoaWYgKHNlcS1zb21lCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKGxhbWJkYSAod2lkZ2V0KQorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKG1lbXEKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAod2lkZ2V0LWdldCB3aWRnZXQgOmN1c3RvbS1zdGF0ZSkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhY3RpdmUpKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGN1c3RvbS1vcHRpb25zKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKHdpZGdldC1hcHBseSB3aWRnZXQgOmFjdGl2YXRlKQor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICh3aWRnZXQtYXBwbHkgd2lkZ2V0 IDpkZWFjdGl2YXRlKSkpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGN1c3RvbS1j b21tYW5kLWJ1dHRvbnMpKSkpCiAJICAoY29tbWFuZHMgY3VzdG9tLWNvbW1hbmRzKSkKICAgICAg IChpZiBjdXN0b20tcmVzZXQtYnV0dG9uLW1lbnUKIAkgIChwcm9nbgpAQCAtMjIxNSw3ICsyMjcw LDExIEBAIGN1c3RvbS1ub3RpZnkKICAgKGxldCAoKHN0YXRlICh3aWRnZXQtZ2V0IHdpZGdldCA6 Y3VzdG9tLXN0YXRlKSkpCiAgICAgKHVubGVzcyAoZXEgc3RhdGUgJ21vZGlmaWVkKQogICAgICAg KHVubGVzcyAobWVtcSBzdGF0ZSAnKG5pbCB1bmtub3duIGhpZGRlbikpCi0JKHdpZGdldC1wdXQg d2lkZ2V0IDpjdXN0b20tc3RhdGUgJ21vZGlmaWVkKSkKKwkod2lkZ2V0LXB1dCB3aWRnZXQgOmN1 c3RvbS1zdGF0ZSAnbW9kaWZpZWQpCisgICAgICAgIDs7IFRlbGwgb3VyIGJ1dHRvbnMgYW5kIHRo ZSB0b29sIGJhciB0aGF0IHdlIGNoYW5nZWQgdGhlIHdpZGdldCdzIHN0YXRlLgorICAgICAgICAo Zm9yY2UtbW9kZS1saW5lLXVwZGF0ZSkKKyAgICAgICAgKGRvbGlzdCAoYnRuIGN1c3RvbS1jb21t YW5kLWJ1dHRvbnMpCisgICAgICAgICAgKHdpZGdldC1hcHBseSBidG4gOm5vdGlmeSkpKQogICAg ICAgOzsgVXBkYXRlIHRoZSBzdGF0dXMgdGV4dCAodXN1YWxseSBmcm9tICJTVEFOREFSRCIgdG8g IkVESVRFRAogICAgICAgOzsgYmxhIGJsYSIgaW4gdGhlIGJ1ZmZlciBhZnRlciB0aGUgY29tbWFu ZCBoYXMgcnVuLiAgT3RoZXJ3aXNlCiAgICAgICA7OyBjb21tYW5kcyBsaWtlIGBNLXUnICh0aGF0 IHdvcmsgb24gYSByZWdpb24gaW4gdGhlIGJ1ZmZlcikKQEAgLTIyNTQsNyArMjMxMywxMCBAQCBj dXN0b20tcmVkcmF3LW1hZ2ljCiAJICAgICAgIChjdXN0b20tZ3JvdXAtc3RhdGUtdXBkYXRlIHdp ZGdldCkpKQogCSAgICAodAogCSAgICAgKHNldHEgd2lkZ2V0IG5pbCkpKSkpCi0gICh3aWRnZXQt c2V0dXApKQorICAod2lkZ2V0LXNldHVwKQorICAoZm9yY2UtbW9kZS1saW5lLXVwZGF0ZSkKKyAg KGRvbGlzdCAoYnRuIGN1c3RvbS1jb21tYW5kLWJ1dHRvbnMpCisgICAgKHdpZGdldC1hcHBseSBi dG4gOm5vdGlmeSkpKQogCiAoZGVmdW4gY3VzdG9tLXNob3cgKHdpZGdldCB2YWx1ZSkKICAgIk5v bi1uaWwgaWYgV0lER0VUIHNob3VsZCBiZSBzaG93biB3aXRoIFZBTFVFIGJ5IGRlZmF1bHQuIgpA QCAtNDk0NSw5ICs1MDA3LDE5IEBAIGN1c3RvbWl6ZS1tZW51LWNyZWF0ZQogCSAobWFwY2FyIChs YW1iZGEgKGFyZykKIAkJICAgKGxldCAoKHRhZyAgICAgKG50aCAwIGFyZykpCiAJCQkgKGNvbW1h bmQgKG50aCAxIGFyZykpCi0JCQkgKGFjdGl2ZSAgKG50aCAyIGFyZykpCi0JCQkgKGhlbHAgICAg KG50aCAzIGFyZykpKQotCQkgICAgICh2ZWN0b3IgdGFnIGNvbW1hbmQgOmFjdGl2ZSAoZXZhbCBh Y3RpdmUpIDpoZWxwIGhlbHApKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAodmlzaWJsZSAo bnRoIDIgYXJnKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAoaGVscCAgICAobnRoIDMgYXJn KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAoYWN0aXZlICAobnRoIDYgYXJnKSkpCisgICAg ICAgICAgICAgICAgICAgICAodmVjdG9yIHRhZyBjb21tYW5kIDp2aXNpYmxlIChldmFsIHZpc2li bGUpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDphY3RpdmUKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgYChvciAoZXEgdCAnLGFjdGl2ZSkKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoc2VxLXNvbWUgLChsYW1iZGEgKHdpZGdldCkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG1lbXEKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICh3aWRnZXQtZ2V0IHdpZGdldAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOmN1 c3RvbS1zdGF0ZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGFjdGl2ZSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGN1c3RvbS1vcHRpb25zKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOmhlbHAgaGVs cCkpKQogCQkgY3VzdG9tLWNvbW1hbmRzKSkpCiAKIChkZWZ2YXIgdG9vbC1iYXItbWFwKQotLSAK Mi4yOS4yCgo= --000000000000b442df05b3343b6a--