From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#6755: 24.0.50; Customize buffer is too wide. Put doc string on separate line. Date: Tue, 17 Sep 2019 09:04:43 -0300 Message-ID: References: <871rwgt32h.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000658d470592be87e4" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="60102"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 6755@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 17 14:15:59 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iACOk-000FWy-Vx for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Sep 2019 14:15:59 +0200 Original-Received: from localhost ([::1]:45358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iACOj-0000CZ-OH for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Sep 2019 08:15:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60465) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iACFA-0001Ge-6G for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2019 08:06:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iACF8-0006BZ-NA for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2019 08:06:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42924) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iACF7-0006BK-Rt for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2019 08:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iACF7-0005GF-Kq for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2019 08:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Sep 2019 12:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6755 X-GNU-PR-Package: emacs Original-Received: via spool by 6755-submit@debbugs.gnu.org id=B6755.156872190520149 (code B ref 6755); Tue, 17 Sep 2019 12:06:01 +0000 Original-Received: (at 6755) by debbugs.gnu.org; 17 Sep 2019 12:05:05 +0000 Original-Received: from localhost ([127.0.0.1]:51745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iACED-0005Ev-32 for submit@debbugs.gnu.org; Tue, 17 Sep 2019 08:05:05 -0400 Original-Received: from mail-lj1-f172.google.com ([209.85.208.172]:33664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iACEA-0005EL-Um for 6755@debbugs.gnu.org; Tue, 17 Sep 2019 08:05:03 -0400 Original-Received: by mail-lj1-f172.google.com with SMTP id a22so3272242ljd.0 for <6755@debbugs.gnu.org>; Tue, 17 Sep 2019 05:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C/UTXBYAFP41o9/jeaAkQFp9yVqMkpAFl1xnNypjdkA=; b=o37CevZ1KbpWbrq4R22Er6DQEy3r7+XYiZm6zBw1zFLyF1xK9Eejifyh1f/bf7yi2K Q91Pii5+RCUBg3Wptc54K5MqB2PTDtH3mY+DwOVX+GvYBrZnBFJkMNY1ZNPlAgMQoz/9 J8BclgZuVx606EP9LeH5zhoixQv1KQr4PCR2OSzDtv6CI7tXoj0veNWDQhKeJE/L8HFV A7ccbSFygy82mR9uPPvcoeGTQjBtaMIE/0sTTIF/hyPOw2Lpb8tl27rrGd7XfhCvrLpe 3BYy49wuq3b11/lDVPPbXhzxPDaMnVxf65r/FXLOaJ6iP3ZepE3ZhlP9v/Qm3xDhxIR1 mEBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C/UTXBYAFP41o9/jeaAkQFp9yVqMkpAFl1xnNypjdkA=; b=fEX5UslZZsqFV5Oqni0bOczKkRYsG8cprNEfY918KVAxxgIBbJGbIMRB2JTcNnSUqK 8UenQwUf9mW5NT2uHLZYpUY6I9aqMCXSM2aRTdqe0wMlxJEdULNqpGpU19UNIlqnk9Fw jmQ8XRnyLoIoH5btaBsyCs1FnT8BLUbW1+jysfDYNKCUVGIJKVuH7cD3KLtWgqhhIgJc bhacl04D+l89RHmqWB3jGujZsTUJFbGoenpfW8f16kcwe7fMoLTtMa/or/j+JJue7ssj SfxuIzoYh8wbQ211Zy5JkHiMaaNy7J4IvZXkBGIz7xFyOUk4RWuOVFX8OrEjMD0zUahP JDTQ== X-Gm-Message-State: APjAAAUV1BOSTG7454qGYMO0RHQNaLdLwnv0TPHUuoeV1GALOoJJVa62 N/9rMMQGkblPnsqcshkCEYSoUW/WAdlZiS4/K+M= X-Google-Smtp-Source: APXvYqxAtY17jMgFEiyINEA+V7y0tX02Rxg5EcEggT4f+wQWki6w4BaCdqHuBBFpyYUreNkBqvai6C/9CvTFSx05aB8= X-Received: by 2002:a2e:9d0d:: with SMTP id t13mr1684412lji.169.1568721896566; Tue, 17 Sep 2019 05:04:56 -0700 (PDT) In-Reply-To: <871rwgt32h.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166631 Archived-At: --000000000000658d470592be87e4 Content-Type: multipart/alternative; boundary="000000000000658d450592be87e2" --000000000000658d450592be87e2 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> But I wanted to ask first, do we really want to make this behavior >> unconditional in the widget library? Or would it be better to provide >> it as an option, for customize (and possibly other clients) to set it? > > I think an option here would be nice, because I think this is something > the caller would want to control. I agree with you. I've come up with the attached patch, let me know what you think. For a quick way to test it, I used the option window-combination-limit: emacs -Q M-x customize-variable window-combination-limit Changing the values, it can be seen when the tag string is filled and when it's not. --000000000000658d450592be87e2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Lars Ingebrigtsen <la= rsi@gnus.org> writes:

> Mauro Aranda <maurooaranda@gmail.com> writes:
>
= >> But I wanted to ask first, do we really want to make this behavior=
>> unconditional in the widget library?=C2=A0 Or would it be bett= er to provide
>> it as an option, for customize (and possibly othe= r clients) to set it?
>
> I think an option here would be nice,= because I think this is something
> the caller would want to control= .

I agree with you.=C2=A0 I've come up with the attached patch, = let me know
what you think.

For a quick way to test it, I used th= e option window-combination-limit:

emacs -Q
M-x customize-variabl= e window-combination-limit

Changing the values, it can be seen when = the tag string is filled and
when it's not.
--000000000000658d450592be87e2-- --000000000000658d470592be87e4 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fill-tag-strings-in-customize-buffers-Bug-6755.patch" Content-Disposition: attachment; filename="0001-Fill-tag-strings-in-customize-buffers-Bug-6755.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k0nshmpx0 RnJvbSBiMDMxM2M3Y2IyODY4MDA2MGRhOWJjNTZjMDViZjA0MTE2NWI5MWJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IE1vbiwgMTYgU2VwIDIwMTkgMTg6MTU6NDYgLTAzMDAKU3ViamVjdDogW1BBVENIXSBG aWxsIHRhZyBzdHJpbmdzIGluIGN1c3RvbWl6ZSBidWZmZXJzIChCdWcjNjc1NSkKCiogbGlzcC93 aWQtZWRpdC5lbCAod2lkZ2V0LWZpbGwtdGFnLXN0cmluZyk6IE5ldyB2YXJpYWJsZSwgdG8gY29u dHJvbAp3aGV0aGVyIHRvIGZpbGwgc3RyaW5ncyBzcGVjaWZpZWQgYnkgdGhlICV0IGZvcm1hdCBl c2NhcGUuCih3aWRnZXQtZGVmYXVsdC1jcmVhdGUpOiBVc2UgaXQuCiogZG9jL21pc2Mvd2lkZ2V0 LnRleGkgKEJhc2ljIFR5cGVzKTogRG9jdW1lbnQgdGhlIG5ldyB2YXJpYWJsZS4KKiBsaXNwL2N1 cy1lZGl0LmVsIChjdXN0b20tLWluaXRpYWxpemUtd2lkZ2V0LXZhcmlhYmxlcyk6IFNldAp3aWRn ZXQtZmlsbC10YWctc3RyaW5nIHRvIHQsIHRvIGZpbGwgdGFnIHN0cmluZ3MuCi0tLQogZG9jL21p c2Mvd2lkZ2V0LnRleGkgfCAgNiArKysrKy0KIGxpc3AvY3VzLWVkaXQuZWwgICAgIHwgIDEgKwog bGlzcC93aWQtZWRpdC5lbCAgICAgfCAxNCArKysrKysrKysrLS0tLQogMyBmaWxlcyBjaGFuZ2Vk LCAxNiBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9taXNj L3dpZGdldC50ZXhpIGIvZG9jL21pc2Mvd2lkZ2V0LnRleGkKaW5kZXggNmQ5NDc2OC4uNDg4YjQ0 ZSAxMDA2NDQKLS0tIGEvZG9jL21pc2Mvd2lkZ2V0LnRleGkKKysrIGIvZG9jL21pc2Mvd2lkZ2V0 LnRleGkKQEAgLTUzMyw5ICs1MzMsMTMgQEAgQmFzaWMgVHlwZXMKIGxhbWJkYSBleHByZXNzaW9u LCBpdCB3aWxsIGJlIGNhbGxlZCB3aXRoIHRoZSB3aWRnZXQncyB2YWx1ZSBhcyBhbgogYXJndW1l bnQsIGFuZCB0aGUgcmVzdWx0IHdpbGwgYmUgdXNlZCBhcyB0aGUgZG9jdW1lbnRhdGlvbiB0ZXh0 LgogCitAdmluZGV4IHdpZGdldC1maWxsLXRhZy1zdHJpbmcKIEBpdGVtICV0CiBJbnNlcnQgdGhl IHN0cmluZyBzcGVjaWZpZWQgYnkgQGNvZGV7OnRhZ30gaGVyZSwgb3IgdGhlIEBjb2Rle3ByaW5j fQotcmVwcmVzZW50YXRpb24gb2YgdGhlIHZhbHVlIGlmIHRoZXJlIGlzIG5vIHRhZy4KK3JlcHJl c2VudGF0aW9uIG9mIHRoZSB2YWx1ZSBpZiB0aGVyZSBpcyBubyB0YWcuICBUaGUgdmFyaWFibGUK K0Bjb2Rle3dpZGdldC1maWxsLXRhZy1zdHJpbmd9IGNvbnRyb2xzIHdoZXRoZXIgdG8gZmlsbCB0 aGUgaW5zZXJ0ZWQKK3N0cmluZyBvciBub3QuICBAeHJlZntGaWxsaW5nLCwsIGVsaXNwLCB0aGUg RW1hY3MgTGlzcCBSZWZlcmVuY2UgTWFudWFsfSwKK2ZvciBkZXRhaWxzIG9uIGZpbGxpbmcuCiAK IEBpdGVtICUlCiBJbnNlcnQgYSBsaXRlcmFsIEBzYW1weyV9LgpkaWZmIC0tZ2l0IGEvbGlzcC9j dXMtZWRpdC5lbCBiL2xpc3AvY3VzLWVkaXQuZWwKaW5kZXggOGE4YmFkOS4uMGMzOTJmZiAxMDA2 NDQKLS0tIGEvbGlzcC9jdXMtZWRpdC5lbAorKysgYi9saXNwL2N1cy1lZGl0LmVsCkBAIC00ODMz LDYgKzQ4MzMsNyBAQCBjdXN0b20tLWluaXRpYWxpemUtd2lkZ2V0LXZhcmlhYmxlcwogICAgIChz ZXRxLWxvY2FsIHdpZGdldC1wdXNoLWJ1dHRvbi1zdWZmaXggIiIpCiAgICAgKHNldHEtbG9jYWwg d2lkZ2V0LWxpbmstcHJlZml4ICIiKQogICAgIChzZXRxLWxvY2FsIHdpZGdldC1saW5rLXN1ZmZp eCAiIikpCisgIChzZXRxLWxvY2FsIHdpZGdldC1maWxsLXRhZy1zdHJpbmcgdCkKICAgKHNldHEg c2hvdy10cmFpbGluZy13aGl0ZXNwYWNlIG5pbCkpCiAKIChkZWZpbmUtZGVyaXZlZC1tb2RlIEN1 c3RvbS1tb2RlIG5pbCAiQ3VzdG9tIgpkaWZmIC0tZ2l0IGEvbGlzcC93aWQtZWRpdC5lbCBiL2xp c3Avd2lkLWVkaXQuZWwKaW5kZXggN2VkN2I4MS4uNjllOTcxNiAxMDA2NDQKLS0tIGEvbGlzcC93 aWQtZWRpdC5lbAorKysgYi9saXNwL3dpZC1lZGl0LmVsCkBAIC0xNDc3LDYgKzE0NzcsOSBAQCB3 aWRnZXQtZGVmYXVsdC1jb21wbGV0aW9ucwogICAgICAgICAgICAgICAgIChjYWxsLWludGVyYWN0 aXZlbHkKICAgICAgICAgICAgICAgICAgKHdpZGdldC1nZXQgd2lkZ2V0IDpjb21wbGV0ZS1mdW5j dGlvbikpKSkpKSkpKQogCisoZGVmdmFyIHdpZGdldC1maWxsLXRhZy1zdHJpbmcgbmlsCisgICJJ ZiBub24tbmlsLCBmaWxsIHRoZSBzdHJpbmcgaW5zZXJ0ZWQgYnkgdGhlICV0IDpmb3JtYXQgZXNj YXBlLiIpCisKIChkZWZ1biB3aWRnZXQtZGVmYXVsdC1jcmVhdGUgKHdpZGdldCkKICAgIkNyZWF0 ZSBXSURHRVQgYXQgcG9pbnQgaW4gdGhlIGN1cnJlbnQgYnVmZmVyLiIKICAgKHdpZGdldC1zcGVj aWZ5LWluc2VydApAQCAtMTUwOSwxNSArMTUxMiwxOCBAQCB3aWRnZXQtZGVmYXVsdC1jcmVhdGUK IAkJICAoaW5zZXJ0LWNoYXIgP1xzICh3aWRnZXQtZ2V0IHdpZGdldCA6aW5kZW50KSkpKQogCSAg ICAgICAoKGVxIGVzY2FwZSA/dCkKIAkJKGxldCAoKGltYWdlICh3aWRnZXQtZ2V0IHdpZGdldCA6 dGFnLWdseXBoKSkKLQkJICAgICAgKHRhZyAoc3Vic3RpdHV0ZS1jb21tYW5kLWtleXMKLQkJCSAg ICAod2lkZ2V0LWdldCB3aWRnZXQgOnRhZykpKSkKKwkJICAgICAgKHRhZyAoc3Vic3RpdHV0ZS1j b21tYW5kLWtleXMgKHdpZGdldC1nZXQgd2lkZ2V0IDp0YWcpKSkKKyAgICAgICAgICAgICAgICAg ICAgICAob3BvaW50IChwb2ludCkpKQogCQkgIChjb25kIChpbWFnZQogCQkJICh3aWRnZXQtaW1h Z2UtaW5zZXJ0IHdpZGdldCAob3IgdGFnICJpbWFnZSIpIGltYWdlKSkKIAkJCSh0YWcKIAkJCSAo aW5zZXJ0IHRhZykpCiAJCQkodAotCQkJIChwcmluYyAod2lkZ2V0LWdldCB3aWRnZXQgOnZhbHVl KQotCQkJCShjdXJyZW50LWJ1ZmZlcikpKSkpKQorCQkJIChwcmluYyAod2lkZ2V0LWdldCB3aWRn ZXQgOnZhbHVlKSAoY3VycmVudC1idWZmZXIpKSkpCisgICAgICAgICAgICAgICAgICAod2hlbiB3 aWRnZXQtZmlsbC10YWctc3RyaW5nCisgICAgICAgICAgICAgICAgICAgIChzYXZlLXJlc3RyaWN0 aW9uCisgICAgICAgICAgICAgICAgICAgICAgKHdpZGVuKQorICAgICAgICAgICAgICAgICAgICAg IChmaWxsLXJlZ2lvbiBvcG9pbnQgKHBvaW50KSBuaWwgdCkpKSkpCiAJICAgICAgICgoZXEgZXNj YXBlID9kKQogCQkobGV0ICgoZG9jICh3aWRnZXQtZ2V0IHdpZGdldCA6ZG9jKSkpCiAJCSAgKHdo ZW4gZG9jCi0tIAoyLjcuNAoK --000000000000658d470592be87e4--