bug#3192: 23.0.92; disabling tooltip-mode inhibits showing Customize error msgs

[Mauro Aranda <maurooaranda@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 467 bytes --]

Stefan Kangas <stefan@marxist.se> writes:

> Mauro Aranda <maurooaranda@gmail.com> writes:
>
>> I don't know what happens on other systems other than GNU/Linux and
>> Windows, so it would be good to have that information.
>
> I'm not able to reproduce this on current master on macOS.  I see
> these messages echoed in the minibuffer and in the *Messages* buffer:
>

Thank you Stefan.

I propose the attached patch.

>
> Thanks,
> Stefan Kangas

Best regards,
Mauro.

[-- Attachment #1.2: Type: text/html, Size: 717 bytes --]

[-- Attachment #2: 0001-With-tooltip-mode-disabled-don-t-unconditionally-cle.patch --]
[-- Type: text/x-patch, Size: 1132 bytes --]

From 2fcecc4efc443b8d7f58369f6cd64570913b9650 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Fri, 30 Aug 2019 10:11:11 -0300
Subject: [PATCH] With tooltip-mode disabled, don't unconditionally clear the
 echo area

* lisp/tooltip.el (tooltip-show-help-non-mode): Only clear the echo
area when the current message displayed is a tooltip message.  (Bug#3192)
---
 lisp/tooltip.el | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lisp/tooltip.el b/lisp/tooltip.el
index b1c69ae..407531b 100644
--- a/lisp/tooltip.el
+++ b/lisp/tooltip.el
@@ -365,7 +365,10 @@ tooltip-show-help-non-mode
       (let ((message-log-max nil))
         (message "%s" tooltip-previous-message)
         (setq tooltip-previous-message nil)))
-     (t
+     ;; Only stop displaying the message when the current message is our own.
+     ;; This has the advantage of not clearing the echo area when
+     ;; running after an error message was displayed.  (Bug#3192)
+     ((equal-including-properties tooltip-help-message (current-message))
       (message nil)))))
 
 (defun tooltip-show-help (msg)
-- 
2.7.4