From: Mauro Aranda <maurooaranda@gmail.com>
To: Alan Mackenzie <acm@muc.de>
Cc: 32403@debbugs.gnu.org
Subject: bug#32403: 27.0.50; cc mode: c-display-defun-name doesn't work when return type is a pointer
Date: Sun, 26 Aug 2018 11:40:38 -0300 [thread overview]
Message-ID: <CABczVwcc=K28ezu_QUKogR6LV+2Evgqkt1=T1OKTAOw95C3o=A@mail.gmail.com> (raw)
In-Reply-To: <20180826112501.GA1867@ACM>
[-- Attachment #1: Type: text/plain, Size: 2056 bytes --]
Hi Alan,
The fix works great. Thank you!
2018-08-26 8:25 GMT-03:00 Alan Mackenzie <acm@muc.de>:
> Hello, Mauro, hello, Eli.
>
> On Fri, Aug 17, 2018 at 20:37:07 +0000, Alan Mackenzie wrote:
> > On Fri, Aug 17, 2018 at 12:24:50 +0300, Eli Zaretskii wrote:
> > > > From: Mauro Aranda <maurooaranda@gmail.com>
> > > > Date: Wed, 8 Aug 2018 17:18:58 -0300
>
> > > > Hello. I'm sending this report here because I tested in GNU Emacs
> 26.1.50 and the problem is not present. If
> > > > it belongs to the CC Mode mailing list, please let me know.
>
> > > > I run: emacs -Q and visit a C file.
>
> > > > Inside a function that doesn't return a pointer,
> c-display-defun-name works just fine. Example:
>
> > > > int
> > > > dummy_returnint(int ret)
> > > > {
> > > > return ret;
> > > > }
>
> > > > Minibuffer displays: dummy_returnint
>
> > > > But when the function returns a pointer, c-display-defun-name fails
> to display the function name in the
> > > > minibuffer. Example:
>
> > > > int *
> > > > dummy_returnpointertoint(int *ret)
> > > > {
> > > > return ret;
> > > > }
>
> > > > Minibuffer displays nothing
>
> > > Confirmed. Alan, could you please take a look at this?
>
> > Yes, certainly. I've worked out a patch for Mauro's failure case (with
> > the function's type being a pointer).
>
> > Additionally, I've found a couple of edge cases which currently aren't
> > working right:
>
> > struct foo bar = {0, 0};
>
> > returns "struct foo" on C-c C-z. It ought to return "bar";
>
> > struct foo {int a; int b} bar = {0, 0};
>
> > also ought to return "bar".
>
> > It shouldn't be too much work to fix these two, too. I hope to have this
> > done by tomorrow (European time) or, at the latest, on Sunday.
>
> I've committed a fix for this to master. It was a bit trickier than I'd
> anticipated.
>
> Mauro, would you please test the fix with your real source code and
> either confirm to me that the problem has indeed been fixed, or tell me
> where it's still failing. Thanks!
>
> --
> Alan Mackenzie (Nuremberg, Germany).
>
[-- Attachment #2: Type: text/html, Size: 3030 bytes --]
next prev parent reply other threads:[~2018-08-26 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 20:18 bug#32403: 27.0.50; cc mode: c-display-defun-name doesn't work when return type is a pointer Mauro Aranda
2018-08-17 9:24 ` Eli Zaretskii
2018-08-17 20:37 ` Alan Mackenzie
2018-08-26 11:25 ` Alan Mackenzie
2018-08-26 14:40 ` Mauro Aranda [this message]
2018-08-26 16:27 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABczVwcc=K28ezu_QUKogR6LV+2Evgqkt1=T1OKTAOw95C3o=A@mail.gmail.com' \
--to=maurooaranda@gmail.com \
--cc=32403@debbugs.gnu.org \
--cc=acm@muc.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).