From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#18074: 24.3.50; `default' clause in face specs with custom-theme-set-faces doesn't work as advertised Date: Wed, 26 Aug 2020 10:51:09 -0300 Message-ID: References: <83sgc936a2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000064395405adc81d8c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22048"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Frank Terbeck , 18074@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 26 15:53:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAvrb-0005dx-BY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Aug 2020 15:53:19 +0200 Original-Received: from localhost ([::1]:40066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAvra-0003bZ-Bh for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Aug 2020 09:53:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAvqL-00028k-Vr for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 09:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54528) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAvqL-0000Ci-LN for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 09:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kAvqL-0000LK-KM for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 09:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Aug 2020 13:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18074 X-GNU-PR-Package: emacs Original-Received: via spool by 18074-submit@debbugs.gnu.org id=B18074.15984498941283 (code B ref 18074); Wed, 26 Aug 2020 13:52:01 +0000 Original-Received: (at 18074) by debbugs.gnu.org; 26 Aug 2020 13:51:34 +0000 Original-Received: from localhost ([127.0.0.1]:37841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAvpt-0000Kc-TW for submit@debbugs.gnu.org; Wed, 26 Aug 2020 09:51:34 -0400 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:41480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAvpn-0000KB-Lc for 18074@debbugs.gnu.org; Wed, 26 Aug 2020 09:51:29 -0400 Original-Received: by mail-wr1-f54.google.com with SMTP id p17so1880800wrj.8 for <18074@debbugs.gnu.org>; Wed, 26 Aug 2020 06:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9tqPF5uxaLc6YWzmNSkllYM1eTvGrRdynvoXbe1ugOo=; b=h0z4Q5JI3zOny7m52G/SsjQWxdyzM1A5oyxnA67k9vKjOxcuWliLCS+h7og97ZOdte tbHVQKQC+AffYaVMR2uTE1OmFPDMtRx0nncbr2/G86pu2ug3Im6y2CvT52Xd2yRFY7yE JJyziIclIX7qXmWBa0YFDFYd9xMgM7812+FpWtxkzYaidWAmjHhltcDSAPMV1ZZxYvgR LTzA/0xOxycVupJ0kQ1C3i0GbYgRqYjY3TfvA/MMxsRKflO+I08jncMspsvMs5KSoiB+ vFaYRrEXqSs2+l/ln0HhHqUvHXfdBipHEI+oseMrhAlLcDdtvYJtn7yG8t/YZFPElxKC RI0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9tqPF5uxaLc6YWzmNSkllYM1eTvGrRdynvoXbe1ugOo=; b=CwurKMM5iEM1+1DbGakNOUomckQ4B/8BhOYwWh6MWGt8j5P9TS3+QYB1aflmeQrFL8 cklfqYYuMU2kf7GCVZTzlpAWIuJqayv6ohu4f4jSmQ4SNyjwxrbO9fVbienpEyKNJKIE Nx7tYX/ILuS29iMqoKoGhkReiiLHYRkLESWSnkxUk+fueWfXzZCzapDdNBkxlN+uyT19 B8n/R4mYN5WeDyIYVXkNgff9rRpTo07WAqwXIgPHzzPTkgMUU/j19vh1CuyPuKqae6Ne Kr8i8Uz8KHSYpHb2GkcYaZnbQLQfRyaDUaf1SWEAAnWUhD0rtasGdcxKh2IxlBAfiXx3 b6Dw== X-Gm-Message-State: AOAM530fZTzayc4KfmsgQEowp7Cild0f2N8vUmjqjSM7fY1wOkp7NPkg GRwmdKI0gUvVqO3W+0R6ljZAnrSk8ch0r6kj75I= X-Google-Smtp-Source: ABdhPJx2ZKi+5C/bbJvQYC4sZNJ6rRr/Ym3c5HY2+ME/XvS6UFa6NNwMQSDGLTKOzXlwRUowcEM9MLXctd7WUDge3mQ= X-Received: by 2002:adf:e452:: with SMTP id t18mr14751665wrm.109.1598449881724; Wed, 26 Aug 2020 06:51:21 -0700 (PDT) In-Reply-To: <83sgc936a2.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186442 Archived-At: --00000000000064395405adc81d8c Content-Type: text/plain; charset="UTF-8" unarchive 40336 forcemerge 40336 18074 quit Eli Zaretskii writes: >> From: Mauro Aranda >> Date: Wed, 26 Aug 2020 09:50:34 -0300 >> Cc: 18074@debbugs.gnu.org, Eli Zaretskii >> >> > (deftheme foobar "Foobar theme") >> > (custom-theme-set-faces 'foobar >> > '(default ((default :slant normal >> > :weight bold >> > :foreground "white" >> > :background "black") >> > (t :foreground "blue")))) >> > >> > What I would expect is the `blue' foreground definition from the `t' >> > clause to override the `white' foreground definition from the `default' >> > clause. But alas, it doesn't work, the foreground remains white. >> >> I can reproduce this in Emacs 27, but not with current master. >> >> It looks like this was fixed in: >> commit 05d365d3105371ec956f31f109a2de14c5cf67df >> Author: Eli Zaretskii >> Date: Sat Apr 4 09:59:16 2020 +0300 >> >> Fix face spec handling for 'default' "terminal class" >> >> * lisp/faces.el (face-spec-choose): Reverse order of 'defaults' >> and 'result' when generating attribute list, so that the spec for >> 'default' "terminal class" is indeed overridden by the actual >> class's spec, per the documentation. (Bug#40336) >> >> CCing Eli, hoping he can confirm. > > Confirmed, thanks. Thanks. Merging this bug with Bug#40336. --00000000000064395405adc81d8c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
unarchive 40336
forcemerge 40336 18074=
quit

Eli Zaretskii <eliz@gnu.= org> writes:

>> From: Mauro Aranda <maurooaranda@gmail.com>
>> Date: = Wed, 26 Aug 2020 09:50:34 -0300
>> Cc: 18074@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
>>
>> > (defthem= e foobar "Foobar theme")
>> > (custom-theme-set-faces= 'foobar
>> > =C2=A0 '(default ((default :slant normal<= br>>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 :weight bold
>> > =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :foreground "whit= e"
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 :background "black")
>> >= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(t :foreground "blue&= quot;))))
>> >
>> > What I would expect is the `blu= e' foreground definition from the `t'
>> > clause to ov= erride the `white' foreground definition from the `default'
>= > > clause. But alas, it doesn't work, the foreground remains whi= te.
>>
>> I can reproduce this in Emacs 27, but not with= current master.
>>
>> It looks like this was fixed in:<= br>>> commit 05d365d3105371ec956f31f109a2de14c5cf67df
>> Aut= hor: Eli Zaretskii <eliz@gnu.org>=
>> Date: =C2=A0 Sat Apr 4 09:59:16 2020 +0300
>>
>= ;> =C2=A0 =C2=A0 Fix face spec handling for 'default' "term= inal class"
>> =C2=A0 =C2=A0
>> =C2=A0 =C2=A0 * lis= p/faces.el (face-spec-choose): Reverse order of 'defaults'
>&= gt; =C2=A0 =C2=A0 and 'result' when generating attribute list, so t= hat the spec for
>> =C2=A0 =C2=A0 'default' "terminal= class" is indeed overridden by the actual
>> =C2=A0 =C2=A0 c= lass's spec, per the documentation. =C2=A0(Bug#40336)
>>
&= gt;> CCing Eli, hoping he can confirm.
>
> Confirmed, thanks= .

Thanks.=C2=A0 Merging this bug with Bug#40336.
--00000000000064395405adc81d8c--