From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#5358: 23.1; Adding comment loses customizations in progress Date: Fri, 27 Sep 2019 12:04:37 -0300 Message-ID: References: <87r241omor.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000002f629505938a3589" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="183269"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Dave Abrahams , ahyatt@gmail.com, 5358@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 27 19:11:29 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iDtmC-000lYG-FX for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Sep 2019 19:11:28 +0200 Original-Received: from localhost ([::1]:54032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDtmA-0001g1-Fe for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Sep 2019 13:11:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54885) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDrnz-0006jS-Br for bug-gnu-emacs@gnu.org; Fri, 27 Sep 2019 11:05:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDrnt-0005K3-LX for bug-gnu-emacs@gnu.org; Fri, 27 Sep 2019 11:05:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39579) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iDrnt-0005Jp-0D for bug-gnu-emacs@gnu.org; Fri, 27 Sep 2019 11:05:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iDrnq-0008UV-OH for bug-gnu-emacs@gnu.org; Fri, 27 Sep 2019 11:05:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Sep 2019 15:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5358 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 5358-submit@debbugs.gnu.org id=B5358.156959669932613 (code B ref 5358); Fri, 27 Sep 2019 15:05:02 +0000 Original-Received: (at 5358) by debbugs.gnu.org; 27 Sep 2019 15:04:59 +0000 Original-Received: from localhost ([127.0.0.1]:48398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDrnn-0008Tx-0k for submit@debbugs.gnu.org; Fri, 27 Sep 2019 11:04:59 -0400 Original-Received: from mail-lf1-f53.google.com ([209.85.167.53]:37988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDrnk-0008Td-IN for 5358@debbugs.gnu.org; Fri, 27 Sep 2019 11:04:57 -0400 Original-Received: by mail-lf1-f53.google.com with SMTP id u28so2183849lfc.5 for <5358@debbugs.gnu.org>; Fri, 27 Sep 2019 08:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oqe68eRGKY2CP7wlmB1MHJM9VdAotXWx9XyUgTZvr9A=; b=T2EsvUotxxziCI8LBrknxS4J6Xk9Ne7pQreHWv9mOTUyq9GcCbnyO2uqel7Md44WqH Ci7BO3DS7cauq7960NraeiFW+OKFLee0D50XiZRDjWcE92ScIwu7Gyv7tmzpUS3g+ICV Jysvatz2dtV81D3uAdBXhPvl+k2gdGf3ERtQ92QVYCusWrmzpVXFl+9b/nemF0Wn+CFi 14Kf/aJkpWydAnDUTFe9tG/lVfFB+3RIMyaa3BxFUySe25DELN4fSa1rzVHL5/7Q4bpS eOxwVxdPO3CnJDNcUAD7eq5Ft00iILycGrowW2VxZ8P+lUeIFIfCDe9zc8xLv1HGwnLG eGDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oqe68eRGKY2CP7wlmB1MHJM9VdAotXWx9XyUgTZvr9A=; b=NidToeZeL5MFhnrGI2csqrvqCBjaQGc19x2a3gjoHStjR8Zsjdyh6wWqWRuac4TF5I cLBsTssysVSINQ4XnN/bjdCwDqBzn6jqlauCBSTMhpGLdMlotZrHx7LPPu/4V1XW40n4 WzN+mW61D8Zr3QtmOegNb98i6GEaugZ9Vhh4nynXDjR4q3zJ8zh26wcznQ9jINz42jrv 7xyzWeH+HOHRtulNe3aiDy3Y7QQLk6B2oHnQLR2jpqa2Hi5bscNvRn5wVWpCY2MIoGv2 bKVyiGRSuv8yyFQvJ3QyM3l2By1EPNOhU3g/ZPAkgEwv9wyDU3s3/XvnTcdjB5/HnXwz 4cWA== X-Gm-Message-State: APjAAAV1izvzJJu3NU8XaKXUi4ZaPJWxH+oz8Jdl6SJoL8BP4UG2g5A9 emnyrNbr6LxZbPVF4oFSbQmxWlnH2Bp2e3D8iXc= X-Google-Smtp-Source: APXvYqyaXj216eFBzDOR1a9k+IrjKZIhBlUA/WxkErorbRsIrhbjKx3Q2ahWItoC3ITQiNoIGL/8ZGwtvKXj4KcJUTs= X-Received: by 2002:a19:f711:: with SMTP id z17mr3107065lfe.58.1569596690613; Fri, 27 Sep 2019 08:04:50 -0700 (PDT) In-Reply-To: <87r241omor.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167420 Archived-At: --0000000000002f629505938a3589 Content-Type: multipart/alternative; boundary="0000000000002f629405938a3587" --0000000000002f629405938a3587 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> Subject: [PATCH] Don't discard customizations in progress when adding comments >> (Bug#5358) > > Looks good to me. Just one tiny comment: > >> + (condition-case nil >> + (let* ((symbol (widget-get widget :value)) >> + (get (or (get symbol 'custom-get) 'default-value)) >> + (value (if (default-boundp symbol) >> + (funcall get symbol) >> + (symbol-value symbol)))) >> + (not (equal value (widget-value (car (widget-get widget :children)))))) >> + (error t))) > > If it's just the funcall you expect that might fail, then moving the > condition-case down there might be a better choice. Having a > condition-case around code that shouldn't fail can hide errors you don't > want to hide. Right, thanks for noticing that. I've moved down the condition-case, and I've added an outer catch, to avoid the comparison in case of an error. I think that's OK, but if you see something wrong, please let me know. --0000000000002f629405938a3587 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Lars Ingebrigtsen <la= rsi@gnus.org> writes:

> Mauro Aranda <maurooaranda@gmail.com> writes:
>
= >> Subject: [PATCH] Don't discard customizations in progress when= adding comments
>> =C2=A0(Bug#5358)
>
> Looks good to= me.=C2=A0 Just one tiny comment:
>
>> + =C2=A0(condition-ca= se nil
>> + =C2=A0 =C2=A0 =C2=A0(let* ((symbol (widget-get widget = :value))
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (get (or (= get symbol 'custom-get) 'default-value))
>> + =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (value (if (default-boundp symbol)
>&= gt; + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0(funcall get symbol)
>> + =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(symbol-value symbol)))= )
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0(not (equal value (widget-value = (car (widget-get widget :children))))))
>> + =C2=A0 =C2=A0(error t= )))
>
> If it's just the funcall you expect that might fail= , then moving the
> condition-case down there might be a better choic= e.=C2=A0 Having a
> condition-case around code that shouldn't fai= l can hide errors you don't
> want to hide.

Right, thanks = for noticing that.

I've moved down the condition-case, and I'= ;ve added an outer catch, to
avoid the comparison in case of an error.= =C2=A0 I think that's OK, but if you
see something wrong, please let= me know.
--0000000000002f629405938a3587-- --0000000000002f629505938a3589 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Don-t-discard-customizations-in-progress-when-adding.patch" Content-Disposition: attachment; filename="0001-Don-t-discard-customizations-in-progress-when-adding.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k129atyx0 RnJvbSAzOTMzNGI1NmQ3MWFlMzA5ZTlkZWJhMTU2OGMyYjIxMzQ3YzUxOWUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IEZyaSwgNiBTZXAgMjAxOSAwOTo1NTozOSAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIERv bid0IGRpc2NhcmQgY3VzdG9taXphdGlvbnMgaW4gcHJvZ3Jlc3Mgd2hlbiBhZGRpbmcgY29tbWVu dHMKIChCdWcjNTM1OCkKCiogbGlzcC9jdXMtZWRpdC5lbCAoY3VzdG9tLWNvbW1lbnQtc2hvdyk6 IEFkZCBkb2NzdHJpbmcuICBTYXZlIHRoZQp3aWRnZXQgdmFsdWUgaW4gdGhlIDpzaG93bi12YWx1 ZSBwcm9wZXJ0eSwgYmVmb3JlIHJlZHJhd2luZy4KKGN1c3RvbS12YXJpYWJsZS1tb2RpZmllZC1w KTogTmV3IGZ1bmN0aW9uLCB0byBjb21wbGVtZW50IHRoZSByZXR1cm4KdmFsdWVzIG9mIGN1c3Rv bS12YXJpYWJsZS1zdGF0ZS4KKGN1c3RvbS12YXJpYWJsZS1zdGF0ZS1zZXQpOiBVc2UgaXQuCihj dXN0b20tZmFjZS12YWx1ZS1jcmVhdGUpOiBBZGQgY2hpbGRyZW4gdG8gdGhlIGN1c3RvbS1mYWNl IHdpZGdldApiZWZvcmUgc2V0dGluZyB0aGUgc3RhdGUsIHRvIGJlIGFibGUgdG8gY2hlY2sgZm9y IHVzZXIgZWRpdHMuCihjdXN0b20tZmFjZS1zdGF0ZS1zZXQpOiBDaGVjayBmb3IgdXNlciBlZGl0 cyBiZWZvcmUgY2FsbGluZwpjdXN0b20tZmFjZS1zdGF0ZS4KCiogdGVzdC9saXNwL2N1c3RvbS10 ZXN0cy5lbCAoY3VzdG9tLXRlc3Qtc2hvdy1jb21tZW50LXByZXNlcnZlcy1jaGFuZ2VzKToKTmV3 IHRlc3QuCi0tLQogbGlzcC9jdXMtZWRpdC5lbCAgICAgICAgICB8IDY0ICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCiB0ZXN0L2xpc3AvY3VzdG9tLXRlc3Rz LmVsIHwgMjggKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDgwIGluc2Vy dGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvY3VzLWVkaXQuZWwg Yi9saXNwL2N1cy1lZGl0LmVsCmluZGV4IDI0OTY5NjMuLmI5ZmQzZTAgMTAwNjQ0Ci0tLSBhL2xp c3AvY3VzLWVkaXQuZWwKKysrIGIvbGlzcC9jdXMtZWRpdC5lbApAQCAtMjQxNiw5ICsyNDE2LDIx IEBAIGN1c3RvbS1jb21tZW50LWhpZGUKIDs7IFRob3NlIGZ1bmN0aW9ucyBhcmUgZm9yIHRoZSBt ZW51LiBXSURHRVQgaXMgTk9UIHRoZSBjb21tZW50IHdpZGdldC4gSXQncwogOzsgdGhlIGdsb2Jh bCBjdXN0b20gb25lCiAoZGVmdW4gY3VzdG9tLWNvbW1lbnQtc2hvdyAod2lkZ2V0KQotICAod2lk Z2V0LXB1dCB3aWRnZXQgOmNvbW1lbnQtc2hvd24gdCkKLSAgKGN1c3RvbS1yZWRyYXcgd2lkZ2V0 KQotICAod2lkZ2V0LXNldHVwKSkKKyAgIlNob3cgdGhlIGNvbW1lbnQgZWRpdGFibGUgZmllbGQg dGhhdCBiZWxvbmdzIHRvIFdJREdFVC4iCisgIChsZXQgKChjaGlsZCAoY2FyICh3aWRnZXQtZ2V0 IHdpZGdldCA6Y2hpbGRyZW4pKSkKKyAgICAgICAgOzsgSnVzdCB0byBiZSBzYWZlLCB3ZSB3aWxs IHJlc3RvcmUgdGhpcyB2YWx1ZSBhZnRlciByZWRyYXdpbmcuCisgICAgICAgIChvbGQtc2hvd24t dmFsdWUgKHdpZGdldC1nZXQgd2lkZ2V0IDpzaG93bi12YWx1ZSkpKQorICAgICh3aWRnZXQtcHV0 IHdpZGdldCA6Y29tbWVudC1zaG93biB0KQorICAgIDs7IFNhdmUgdGhlIGNoYW5nZXMgbWFkZSBi eSB0aGUgdXNlciBiZWZvcmUgcmVkcmF3aW5nLCB0byBhdm9pZAorICAgIDs7IGxvc2luZyBjdXN0 b21pemF0aW9ucyBpbiBwcm9ncmVzcy4gIChCdWcjNTM1OCkKKyAgICAoaWYgKGVxICh3aWRnZXQt dHlwZSB3aWRnZXQpICdjdXN0b20tZmFjZSkKKyAgICAgICAgKGlmIChlcSAod2lkZ2V0LXR5cGUg Y2hpbGQpICdjdXN0b20tZmFjZS1lZGl0KQorICAgICAgICAgICAgKHdpZGdldC1wdXQgd2lkZ2V0 IDpzaG93bi12YWx1ZSBgKCh0ICwod2lkZ2V0LXZhbHVlIGNoaWxkKSkpKQorICAgICAgICAgICh3 aWRnZXQtcHV0IHdpZGdldCA6c2hvd24tdmFsdWUgKHdpZGdldC12YWx1ZSBjaGlsZCkpKQorICAg ICAgKHdpZGdldC1wdXQgd2lkZ2V0IDpzaG93bi12YWx1ZSAobGlzdCAod2lkZ2V0LXZhbHVlIGNo aWxkKSkpKQorICAgIChjdXN0b20tcmVkcmF3IHdpZGdldCkKKyAgICAod2lkZ2V0LXB1dCB3aWRn ZXQgOnNob3duLXZhbHVlIG9sZC1zaG93bi12YWx1ZSkKKyAgICAod2lkZ2V0LXNldHVwKSkpCiAK IChkZWZ1biBjdXN0b20tY29tbWVudC1pbnZpc2libGUtcCAod2lkZ2V0KQogICAobGV0ICgodmFs ICh3aWRnZXQtdmFsdWUgKHdpZGdldC1nZXQgd2lkZ2V0IDpjb21tZW50LXdpZGdldCkpKSkKQEAg LTI4MTAsMTIgKzI4MjIsMzUgQEAgY3VzdG9tLXZhcmlhYmxlLXN0YXRlCiAJICAgICAnY2hhbmdl ZCkpCiAJICAodCAncm9ndWUpKSkpCiAKKyhkZWZ1biBjdXN0b20tdmFyaWFibGUtbW9kaWZpZWQt cCAod2lkZ2V0KQorICAiTm9uLW5pbCBpZiB0aGUgdmFyaWFibGUgdmFsdWUgb2YgV0lER0VUIGhh cyBiZWVuIG1vZGlmaWVkLgorV0lER0VUIHNob3VsZCBiZSBhIGN1c3RvbS12YXJpYWJsZSB3aWRn ZXQsIHdob3NlIGZpcnN0IGNoaWxkIGlzIHRoZSB3aWRnZXQKK3RoYXQgaG9sZHMgdGhlIHZhbHVl LgorTW9kaWZpZWQgbWVhbnMgdGhhdCB0aGUgd2lkZ2V0IHRoYXQgaG9sZHMgdGhlIHZhbHVlIGhh cyBiZWVuIGVkaXRlZCBieSB0aGUgdXNlcgoraW4gYSBjdXN0b21pemUgYnVmZmVyLgorVG8gY2hl Y2sgZm9yIG90aGVyIHN0YXRlcywgY2FsbCBgY3VzdG9tLXZhcmlhYmxlLXN0YXRlJy4iCisgIChj YXRjaCAnZ2V0LWVycm9yCisgICAgKGxldCogKChzeW1ib2wgKHdpZGdldC1nZXQgd2lkZ2V0IDp2 YWx1ZSkpCisgICAgICAgICAgIChnZXQgKG9yIChnZXQgc3ltYm9sICdjdXN0b20tZ2V0KSAnZGVm YXVsdC12YWx1ZSkpCisgICAgICAgICAgICh2YWx1ZSAoaWYgKGRlZmF1bHQtYm91bmRwIHN5bWJv bCkKKyAgICAgICAgICAgICAgICAgICAgICAoY29uZGl0aW9uLWNhc2UgbmlsCisgICAgICAgICAg ICAgICAgICAgICAgICAgIChmdW5jYWxsIGdldCBzeW1ib2wpCisgICAgICAgICAgICAgICAgICAg ICAgICAoZXJyb3IgKHRocm93ICdnZXQtZXJyb3IgdCkpKQorICAgICAgICAgICAgICAgICAgICAo c3ltYm9sLXZhbHVlIHN5bWJvbCkpKSkKKyAgICAgIChub3QgKGVxdWFsIHZhbHVlICh3aWRnZXQt dmFsdWUgKGNhciAod2lkZ2V0LWdldCB3aWRnZXQgOmNoaWxkcmVuKSkpKSkpKSkKKwogKGRlZnVu IGN1c3RvbS12YXJpYWJsZS1zdGF0ZS1zZXQgKHdpZGdldCAmb3B0aW9uYWwgc3RhdGUpCiAgICJT ZXQgdGhlIHN0YXRlIG9mIFdJREdFVCB0byBTVEFURS4KLUlmIFNUQVRFIGlzIG5pbCwgdGhlIHZh bHVlIGlzIGNvbXB1dGVkIGJ5IGBjdXN0b20tdmFyaWFibGUtc3RhdGUnLiIKK0lmIFNUQVRFIGlz IG5pbCwgdGhlIG5ldyBzdGF0ZSBpcyBjb21wdXRlZCBieSBgY3VzdG9tLXZhcmlhYmxlLW1vZGlm aWVkLXAnIGlmCitXSURHRVQgaGFzIGJlZW4gZWRpdGVkIGluIHRoZSBDdXN0b20gYnVmZmVyLCBv ciBieSBgY3VzdG9tLXZhcmlhYmxlLXN0YXRlJworb3RoZXJ3aXNlLiIKICAgKHdpZGdldC1wdXQg d2lkZ2V0IDpjdXN0b20tc3RhdGUKLQkgICAgICAob3Igc3RhdGUgKGN1c3RvbS12YXJpYWJsZS1z dGF0ZSAod2lkZ2V0LXZhbHVlIHdpZGdldCkKLQkJCQkJICAgICAgICh3aWRnZXQtZ2V0IHdpZGdl dCA6dmFsdWUpKSkpKQorCSAgICAgIChvciBzdGF0ZQorICAgICAgICAgICAgICAgICAgKGFuZCAo Y3VzdG9tLXZhcmlhYmxlLW1vZGlmaWVkLXAgd2lkZ2V0KSAnbW9kaWZpZWQpCisgICAgICAgICAg ICAgICAgICAoY3VzdG9tLXZhcmlhYmxlLXN0YXRlICh3aWRnZXQtdmFsdWUgd2lkZ2V0KQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAod2lkZ2V0LXZhbHVlCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2FyCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHdpZGdldC1nZXQgd2lkZ2V0IDpjaGlsZHJl bikpKSkpKSkKIAogKGRlZnVuIGN1c3RvbS12YXJpYWJsZS1zdGFuZGFyZC12YWx1ZSAod2lkZ2V0 KQogICAoZ2V0ICh3aWRnZXQtdmFsdWUgd2lkZ2V0KSAnc3RhbmRhcmQtdmFsdWUpKQpAQCAtMzYz NSw5ICszNjcwLDkgQEAgY3VzdG9tLWZhY2UtdmFsdWUtY3JlYXRlCiAJCSAgICAoaW5zZXJ0LWNo YXIgP1xzIGluZGVudCkpCiAJCSAgKHdpZGdldC1jcmVhdGUtY2hpbGQtYW5kLWNvbnZlcnQKIAkJ ICAgd2lkZ2V0ICdzZXhwIDp2YWx1ZSBzcGVjKSkpKQotCSAgKGN1c3RvbS1mYWNlLXN0YXRlLXNl dCB3aWRnZXQpCi0JICAocHVzaCBlZGl0b3IgY2hpbGRyZW4pCi0JICAod2lkZ2V0LXB1dCB3aWRn ZXQgOmNoaWxkcmVuIGNoaWxkcmVuKSkpKSkpCisgICAgICAgICAgKHB1c2ggZWRpdG9yIGNoaWxk cmVuKQorICAgICAgICAgICh3aWRnZXQtcHV0IHdpZGdldCA6Y2hpbGRyZW4gY2hpbGRyZW4pCisJ ICAoY3VzdG9tLWZhY2Utc3RhdGUtc2V0IHdpZGdldCkpKSkpKQogCiAoZGVmdmFyIGN1c3RvbS1m YWNlLW1lbnUKICAgYCgoIlNldCBmb3IgQ3VycmVudCBTZXNzaW9uIiBjdXN0b20tZmFjZS1zZXQp CkBAIC0zNzIzLDkgKzM3NTgsMTQgQEAgY3VzdG9tLWZhY2Utc3RhdGUKICAgICAgIHN0YXRlKSkp CiAKIChkZWZ1biBjdXN0b20tZmFjZS1zdGF0ZS1zZXQgKHdpZGdldCkKLSAgIlNldCB0aGUgc3Rh dGUgb2YgV0lER0VULiIKLSAgKHdpZGdldC1wdXQgd2lkZ2V0IDpjdXN0b20tc3RhdGUKLQkgICAg ICAoY3VzdG9tLWZhY2Utc3RhdGUgKHdpZGdldC12YWx1ZSB3aWRnZXQpKSkpCisgICJTZXQgdGhl IHN0YXRlIG9mIFdJREdFVCwgYSBjdXN0b20tZmFjZSB3aWRnZXQuCitJZiB0aGUgdXNlciBlZGl0 ZWQgdGhlIHdpZGdldCwgc2V0IHRoZSBzdGF0ZSB0byBtb2RpZmllZC4gIElmIG5vdCwgdGhlIG5l dworc3RhdGUgaXMgb25lIG9mIHRoZSByZXR1cm4gdmFsdWVzIG9mIGBjdXN0b20tZmFjZS1zdGF0 ZScuIgorICAobGV0ICgoZmFjZSAod2lkZ2V0LXZhbHVlIHdpZGdldCkpKQorICAgICh3aWRnZXQt cHV0IHdpZGdldCA6Y3VzdG9tLXN0YXRlCisgICAgICAgICAgICAgICAgKGlmIChmYWNlLXNwZWMt bWF0Y2gtcCBmYWNlIChjdXN0b20tZmFjZS13aWRnZXQtdG8tc3BlYyB3aWRnZXQpKQorICAgICAg ICAgICAgICAgICAgICAoY3VzdG9tLWZhY2Utc3RhdGUgZmFjZSkKKyAgICAgICAgICAgICAgICAg ICdtb2RpZmllZCkpKSkKIAogKGRlZnVuIGN1c3RvbS1mYWNlLWFjdGlvbiAod2lkZ2V0ICZvcHRp b25hbCBldmVudCkKICAgIlNob3cgdGhlIG1lbnUgZm9yIGBjdXN0b20tZmFjZScgV0lER0VULgpk aWZmIC0tZ2l0IGEvdGVzdC9saXNwL2N1c3RvbS10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9jdXN0b20t dGVzdHMuZWwKaW5kZXggMGM0OWRiNi4uMjcwYWNkYSAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2N1 c3RvbS10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvY3VzdG9tLXRlc3RzLmVsCkBAIC0yMSw2ICsy MSwxMCBAQAogCiAocmVxdWlyZSAnZXJ0KQogCisocmVxdWlyZSAnd2lkLWVkaXQpCisocmVxdWly ZSAnY3VzLWVkaXQpCisocmVxdWlyZSAnc2VxKSA7IEZvciBgc2VxLWZpbmQnLgorCiAoZXJ0LWRl ZnRlc3QgY3VzdG9tLXRoZW1lLS1sb2FkLXBhdGggKCkKICAgIlRlc3QgYGN1c3RvbS10aGVtZS0t bG9hZC1wYXRoJyBiZWhhdmlvci4iCiAgIChsZXQgKCh0bXBkaXIgKGZpbGUtbmFtZS1hcy1kaXJl Y3RvcnkgKG1ha2UtdGVtcC1maWxlICJjdXN0b20tdGVzdHMtIiB0KSkpKQpAQCAtMTIzLDQgKzEy NywyOCBAQCBjdXN0b20tLXRlc3QtdmFyaWFibGUKICAgICAoc2hvdWxkIChlcXVhbCBjdXN0b20t LXRlc3QtdXNlci1vcHRpb24gJ2JheikpCiAgICAgKHNob3VsZCAoZXF1YWwgY3VzdG9tLS10ZXN0 LXZhcmlhYmxlICdiYXopKSkpCiAKKzs7IFRoaXMgdGVzdHMgQnVnIzUzNTguCisoZXJ0LWRlZnRl c3QgY3VzdG9tLXRlc3Qtc2hvdy1jb21tZW50LXByZXNlcnZlcy1jaGFuZ2VzICgpCisgICJUZXN0 IHRoYXQgYWRkaW5nIGEgY29tbWVudCBkb2Vzbid0IGRpc2NhcmQgbW9kaWZpY2F0aW9ucyBpbiBw cm9ncmVzcy4iCisgIChjdXN0b21pemUtb3B0aW9uICdjdXN0b20tLXRlc3QtdXNlci1vcHRpb24p CisgIChsZXQqICgoZmllbGQgKHNlcS1maW5kIChsYW1iZGEgKHdpZGdldCkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoZXEgY3VzdG9tLS10ZXN0LXVzZXItb3B0aW9uICh3aWRnZXQtdmFs dWUgd2lkZ2V0KSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgIHdpZGdldC1maWVsZC1saXN0 KSkKKyAgICAgICAgIChwYXJlbnQgKHdpZGdldC1nZXQgZmllbGQgOnBhcmVudCkpCisJIChvcmln dmFsdWUgKHdpZGdldC12YWx1ZSBmaWVsZCkpKQorICAgIDs7IE1vdmUgdG8gdGhlIGVuZCBvZiB0 aGUgdGV4dCBvZiB0aGUgd2lkZ2V0LCBhbmQgbW9kaWZ5IGl0LiAgVGhpcworICAgIDs7IG1vZGlm aWNhdGlvbiBzaG91bGQgYmUgcHJlc2VydmVkIGFmdGVyIHNob3dpbmcgdGhlIGNvbW1lbnQgZmll bGQuCisgICAgKGdvdG8tY2hhciAod2lkZ2V0LWZpZWxkLXRleHQtZW5kIGZpZWxkKSkKKyAgICAo aW5zZXJ0ICJiYXIiKQorICAgIChjdXN0b20tY29tbWVudC1zaG93IHBhcmVudCkKKyAgICA7OyBG cm9tIG5vdyBvbiwgbXVzdCB1c2UgYHdpZGdldC1hdCcgdG8gZ2V0IHRoZSB2YWx1ZSBvZiB0aGUg d2lkZ2V0LgorICAgIChzaG91bGQtbm90IChlcSBvcmlndmFsdWUgKHdpZGdldC12YWx1ZSAod2lk Z2V0LWF0KSkpKQorICAgIChzaG91bGQgKGVxICh3aWRnZXQtZ2V0IHBhcmVudCA6Y3VzdG9tLXN0 YXRlKSAnbW9kaWZpZWQpKQorICAgIChzaG91bGQgKGVxICh3aWRnZXQtdmFsdWUgKHdpZGdldC1h dCkpCisgICAgICAgICAgICAgICAgKHdpZGdldC1hcHBseSBmaWVsZAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgOnZhbHVlLXRvLWV4dGVybmFsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAoY29uY2F0CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHdpZGdldC1h cHBseSBmaWVsZCA6dmFsdWUtdG8taW50ZXJuYWwgb3JpZ3ZhbHVlKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICJiYXIiKSkpKSkpCisKIDs7OyBjdXN0b20tdGVzdHMuZWwgZW5kcyBo ZXJlCi0tIAoyLjcuNAoK --0000000000002f629505938a3589--