From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#14635: 24.3.50; Regression in Customize: no revert changes Date: Fri, 30 Oct 2020 11:23:51 -0300 Message-ID: References: <329c5dbd-dfc7-406e-9957-71f3b94409b0@default> <83o8kjakxx.fsf@gnu.org> <83lffnajes.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000006dce705b2e42677" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10194"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 14635@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 30 15:27:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYVMz-0002Ui-B1 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 15:27:09 +0100 Original-Received: from localhost ([::1]:59108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYVMy-0003VB-7x for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 10:27:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYVKw-0001Na-3A for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 10:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47609) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYVKv-0000FJ-OI for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 10:25:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYVKv-0001VB-Kc for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 10:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 14:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 14635-submit@debbugs.gnu.org id=B14635.16040678515714 (code B ref 14635); Fri, 30 Oct 2020 14:25:01 +0000 Original-Received: (at 14635) by debbugs.gnu.org; 30 Oct 2020 14:24:11 +0000 Original-Received: from localhost ([127.0.0.1]:59155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYVK7-0001U5-3t for submit@debbugs.gnu.org; Fri, 30 Oct 2020 10:24:11 -0400 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:55840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYVK5-0001Tr-Iy for 14635@debbugs.gnu.org; Fri, 30 Oct 2020 10:24:09 -0400 Original-Received: by mail-wm1-f50.google.com with SMTP id c9so1476234wml.5 for <14635@debbugs.gnu.org>; Fri, 30 Oct 2020 07:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4ItccC530PkvKRAutMOK7ZEfzTV3mCc7JXsz8tUi8eg=; b=OLCQCB9LfZ+homzpOVdFRLr70ThAVhDQqwtmawblgV+NqJg6QTt/lIjcxMraWtc6Ff r/kCWVi3ob9MJjLRds31WoynP2R1uSnnRtiB0eEfrwfLaaI03flXi3L4HfcbLD+DFNiT D7ohom2h3+q3O4VlM5ceZUM/GaQAlCDDs9SCqCKLR0Zro6ZNpinMP94HSkh+88+/iaD7 fqQ/WUVR4XXoX67Uk8p8cAzwCNbkvOzNrFs5SC/IcVQvqfbhxnH53yaaeajA25nUyG8/ qm+LjEem8qSrbK4HIL8tqsDk6ZgpetykfAuQb8mt4U32PPiG6iBXDcFcJ3/UbmLiL+pQ YAiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4ItccC530PkvKRAutMOK7ZEfzTV3mCc7JXsz8tUi8eg=; b=gE0J+ggoo91w21wSENGqvmn2Dzrkg8tPCNAgEMc2Ogc3EkRgNPin7JayAFYBRxN1Mm g3a8+kOcRFwGnof700mcrP640PHS2UyrdVqTJcYdCqRiLMkilFHbi8rZE9rzAwmGKIkk z6mBzXmQ4Dxhkk/EnOcYvK1qj2+5x1MFIyio0a2D+OhG1uainZksbGP1OOuAUWRV8tqh 2azzacW0tYg78BwOPzXttfoZgZRAkGD/QjNrGdUFf2ddeJTi8Fz1vOw2+DgL62ti0e80 clPTkBMNp1+0Q+tow01frT7gfYylMpXSs4pL7c9ECUZIhidMzYffAfwr7vI0p8/c3SFx F8zQ== X-Gm-Message-State: AOAM531OVGNtobsQzNjpxgqJDoY8eFVaa3Bvv3R5M2domdHxIN+3O6Zi uf0k7hMzBjHyk6xV1RWqWcrH2VfAX576zj3jq2o= X-Google-Smtp-Source: ABdhPJwCg2v9bbGKQTY3dNVaZfDRS5gbbvpiG8syDMIIqXpVB5CJtzHEvudOZb0fIeGuSwvrClwnW0N7Qvg4N/mDx+Q= X-Received: by 2002:a1c:f311:: with SMTP id q17mr2910524wmq.28.1604067843823; Fri, 30 Oct 2020 07:24:03 -0700 (PDT) In-Reply-To: <83lffnajes.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192113 Archived-At: --00000000000006dce705b2e42677 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: >> From: Mauro Aranda >> Date: Fri, 30 Oct 2020 11:03:39 -0300 >> Cc: Drew Adams , 14635@debbugs.gnu.org >> >> > Doesn't customizing a face record the original value in some property >> > of the face symbol? If so, reverting the customizations should use >> > those recorded values, I think. >> >> AFAICT, it doesn't right now. I followed the recipe I gave, and then: >> (symbol-plist 'default) >> The relevant properties I see are: >> * face-defface-spec ==> ((t nil)) >> which won't take us anywhere. >> * theme-face, which has the customized value for the user theme, and >> * customized-face, which again, has the customized value. >> >> But I see no immediate reason why we shouldn't start doing it, if you >> think it is OK to use that to solve this issue. My only questions are >> if it would be best to do it in Customize or in faces.el, and if we >> should only special case the default face. > > I'd begin with doing this in Customize, since it is the only user of > this property. I'll try to do it. Thank you. --00000000000006dce705b2e42677 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@gnu= .org> writes:

>> From: Mauro Aranda <maurooaranda@gmail.com>
>> Date:= Fri, 30 Oct 2020 11:03:39 -0300
>> Cc: Drew Adams <drew.adams@oracle.com>, 14635@debbugs.gnu.org
>>
>&g= t; > Doesn't customizing a face record the original value in some pr= operty
>> > of the face symbol?=C2=A0 If so, reverting the cust= omizations should use
>> > those recorded values, I think.
&= gt;>
>> AFAICT, it doesn't right now.=C2=A0 I followed the= recipe I gave, and then:
>> (symbol-plist 'default)
>&g= t; The relevant properties I see are:
>> * face-defface-spec =3D= =3D> ((t nil))
>> which won't take us anywhere.
>>= * theme-face, which has the customized value for the user theme, and
&g= t;> * customized-face, which again, has the customized value.
>>= ;
>> But I see no immediate reason why we shouldn't start doi= ng it, if you
>> think it is OK to use that to solve this issue.= =C2=A0 My only questions are
>> if it would be best to do it in Cu= stomize or in faces.el, and if we
>> should only special case the = default face.
>
> I'd begin with doing this in Customize, s= ince it is the only user of
> this property.

I'll try to d= o it.=C2=A0 Thank you.
--00000000000006dce705b2e42677--