unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Don March <don@ohspite.net>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: 7541@debbugs.gnu.org
Subject: bug#7541: 24.0.50; define-key error message for non-prefix M-[char]
Date: Sun, 3 Jul 2011 12:24:03 -0400	[thread overview]
Message-ID: <CABSfPEqrc-Hg4B6exFy9mQ0aEnnrXx+3Oem7ETnFRB7VRk=oGQ@mail.gmail.com> (raw)
In-Reply-To: <m38vsfmqji.fsf@quimbies.gnus.org>

I just sent an email to assign@gnu.org.  I'll report back when the
process is complete.

On Sun, Jul 3, 2011 at 9:39 AM, Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:
> Don March <don@ohspite.net> writes:
>
>> Typing and evaluating the following code in the scratch
>> buffer results in an (appropriate) error, but with an incorrect
>> message:
>>
>> (setq new-kmap (make-sparse-keymap))
>> (define-key new-kmap [?a 27] 'command)
>> (define-key new-kmap [?a ?\M-x] 'command)
>> ;; Debugger entered--Lisp error:
>> ;;   (error "Key sequence a M-x starts with non-prefix key a")
>> ;; (should be:
>> ;;          "Key sequence a M-x starts with non-prefix key a ESC")
>>
>> The code in keymap.c loops over the characters in the key sequence and
>> says to report everything before the current character as the
>> non-prefix key.  But that misses the case when M-x is converted into
>> [27 ?x] and it's the `27' part that causes the error.
>
> Your patch for this bug looks correct, but it's more than 10 lines long,
> so the FSF needs copyright assignment papers for the code.
>
> Do you have such paperwork on file with the FSF?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>  bloggy blog http://lars.ingebrigtsen.no/
>





  reply	other threads:[~2011-07-03 16:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-03 16:35 bug#7541: 24.0.50; define-key error message for non-prefix M-[char] Don March
2011-07-03 13:39 ` Lars Magne Ingebrigtsen
2011-07-03 16:24   ` Don March [this message]
2011-07-03 16:30     ` Lars Magne Ingebrigtsen
2011-08-01 21:24       ` Don March
2011-08-02 15:28         ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABSfPEqrc-Hg4B6exFy9mQ0aEnnrXx+3Oem7ETnFRB7VRk=oGQ@mail.gmail.com' \
    --to=don@ohspite.net \
    --cc=7541@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).