unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lin Sun <sunlin7.mail@gmail.com>
To: 70578@debbugs.gnu.org
Subject: bug#70578: [PATCH] ; Fix python test case for testing completion with ipython
Date: Fri, 26 Apr 2024 03:27:34 +0000	[thread overview]
Message-ID: <CABCREdptK5LGo-+QVbpbehz9BEX8tJy=piPOiH=NSQv-Lm=8kA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

Hi,
There is an error when running python-tests.el, I pasted on the tail
of this mail.

The error is caused by the test case trying testing the functions with
ipython but its subroutine didn't use the ipython as interpreter.

Changing the test interpreter will fix the issue, I attached the patch.

Please help apply the change. Thanks.


Test case error message:

Test python-shell-completion-at-point-ipython backtrace:
  call-process("python" nil t nil "-m" "jedi" "repl")
  (eql 0 (call-process python-tests-shell-interpreter nil t nil "-m" "
  (if (eql 0 (call-process python-tests-shell-interpreter nil t nil "-
...
Test python-shell-completion-at-point-ipython condition:
    (file-missing "Searching for program" "No such file or directory"
                  "python")
   FAILED  1/1  python-shell-completion-at-point-ipython (0.829918
sec) at python-tests.el:4897

[-- Attachment #2: 0001-Fix-python-test-case-for-testing-completion-with-ipy.patch --]
[-- Type: text/x-patch, Size: 1105 bytes --]

From ca8d5fb6c8d8591c20ec99e00e7e63fd2c9d1151 Mon Sep 17 00:00:00 2001
From: Lin Sun <sunlin7@hotmail.com>
Date: Thu, 25 Apr 2024 06:54:27 +0000
Subject: [PATCH] ; Fix python test case for testing completion with ipython

* test/lisp/progmodes/python-tests.el
(python-shell-completion-at-point-ipython): Fix the python interpreter
is incorrect in the subroutine.
---
 test/lisp/progmodes/python-tests.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el
index e11440cdb5b..e6e6e05bbef 100644
--- a/test/lisp/progmodes/python-tests.el
+++ b/test/lisp/progmodes/python-tests.el
@@ -4896,7 +4896,8 @@ python-shell-completion-at-point-jedi-completer
 
 (ert-deftest python-shell-completion-at-point-ipython ()
   "Check if Python shell completion works for IPython."
-  (let ((python-shell-interpreter "ipython")
+  (let ((python-tests-shell-interpreter "ipython")
+        (python-shell-interpreter "ipython")
         (python-shell-interpreter-args "-i --simple-prompt"))
     (skip-unless
      (and
-- 
2.20.5


             reply	other threads:[~2024-04-26  3:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-26  3:27 Lin Sun [this message]
2024-04-27  9:53 ` bug#70578: [PATCH] ; Fix python test case for testing completion with ipython Eli Zaretskii
2024-04-27 12:09   ` kobarity
2024-04-29 15:36     ` Lin Sun
2024-05-02  9:06       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABCREdptK5LGo-+QVbpbehz9BEX8tJy=piPOiH=NSQv-Lm=8kA@mail.gmail.com' \
    --to=sunlin7.mail@gmail.com \
    --cc=70578@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).