From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lin Sun Newsgroups: gmane.emacs.bugs Subject: bug#70691: 30.0.50; [PATCH] Eshell's TERM env varible use eshell-term-name as default Date: Wed, 1 May 2024 15:51:54 +0000 Message-ID: References: <865xvxpw3c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5776"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70691@debbugs.gnu.org, Jim Porter To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 01 17:52:54 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2CGL-0001Ep-PX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 May 2024 17:52:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2CGB-0001kq-Do; Wed, 01 May 2024 11:52:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2CG8-0001jd-Sx for bug-gnu-emacs@gnu.org; Wed, 01 May 2024 11:52:40 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2CG8-0001mX-Jr for bug-gnu-emacs@gnu.org; Wed, 01 May 2024 11:52:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s2CGT-0000GR-KN for bug-gnu-emacs@gnu.org; Wed, 01 May 2024 11:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lin Sun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 May 2024 15:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70691 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70691-submit@debbugs.gnu.org id=B70691.1714578762987 (code B ref 70691); Wed, 01 May 2024 15:53:01 +0000 Original-Received: (at 70691) by debbugs.gnu.org; 1 May 2024 15:52:42 +0000 Original-Received: from localhost ([127.0.0.1]:38069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2CG6-0000Fr-C8 for submit@debbugs.gnu.org; Wed, 01 May 2024 11:52:42 -0400 Original-Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:52600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2CG0-0000Fj-Po for 70691@debbugs.gnu.org; Wed, 01 May 2024 11:52:36 -0400 Original-Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-571c2055cb1so1767379a12.1 for <70691@debbugs.gnu.org>; Wed, 01 May 2024 08:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714578725; x=1715183525; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9bhygbNR/3dBQ/QJ8eDS+NV9wsTkMuu1FCSbD8liA4A=; b=Xab0OaQHnx/B6QGEQod8tUNN3oD8drtvpUvQ24ENycATVJzRFTxWwmvDV8U8f7/DXx Zl2RZk0QYh6qWXEe46JnwHwe1aK6lQkjJQsrk/G9+IgcjHD8AHY7ct9RAAkpxyNOuXvq G4E3MyJ3ZODENmm8zJF/9XroYlLu2s2EJHksZNQKrzTpTC3fIyRBlEfJsPbkVUzoLcu0 Zj8qgzilVyvacXYUeeoF1fcwtNMbMuzKvtQG4qxP+0cOYyc8UjOxf4YDCnF8sq5A4dNr OZpHaDkPl+8YdnGsVX8eY2jEUT7XbsNgIZAppEVbKJ53JDSyT92OZd17VNkvFpvigb1w 96nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714578726; x=1715183526; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9bhygbNR/3dBQ/QJ8eDS+NV9wsTkMuu1FCSbD8liA4A=; b=qTWn8C9IjWopKK24MRoVwDsItOR8oPW2HH0IagK0Uk04yBaeRL0FxHxy8LY2nOq2Xh hvA6+GxQM8S+QkutWAiDUKyCxA940NP1LA8xBuILid+UNuNkvroll69k+PfJhZ7WNT0m vKMGylH2BX6jbi5Gkh324sYQdecmEIimrCl0gOXTmDfXjQKDDcY6FR1BUQ047ZayqBGT 0WrT45MgPBWLuNBBLgcWGvEHPfKYPGL9qDPxUjN83DDP5aanCCcsSVPwCqAQScnCfGaz AHs8z2PYMrWz6/l3QXEkmOx3JE9+aw6JC1H4fSCQhXW8Qle83FW6U1Kq3tCnzjNaA+KA tTWA== X-Forwarded-Encrypted: i=1; AJvYcCV0ipSCR0p/+OLNbbSR8CEuwtrsigAu9AQ22qDKMSL5BM/vkyj9jN2m/kD8cVL4/HaMtQWkStEFO/CDwJRxsEllWmNqSh8= X-Gm-Message-State: AOJu0YzUVT38fdgjMeHBCpxsUsrsFiNQwASTCOPh1veOnh6HiXyglJS4 z/4DI2fj7xM1pxvfDA15UJ+iABdXafN2nXOoZHpDhx1B4tYlSIRqY3jZwkOr/rnKrAYrqn+OB7q p9P9liivSSJCpnW7fC1jcWE3YCxw= X-Google-Smtp-Source: AGHT+IGTMo48xQprT+ijlIVoZVBAIGRZoHXMv7wi4WDdaBX7EjoW40sfj/Q/0ZveFKuz53KNklsXAH3qOD1DenjzDig= X-Received: by 2002:a50:9fca:0:b0:572:a089:75cc with SMTP id c68-20020a509fca000000b00572a08975ccmr2298533edf.5.1714578725448; Wed, 01 May 2024 08:52:05 -0700 (PDT) In-Reply-To: <865xvxpw3c.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284256 Archived-At: On Wed, May 1, 2024 at 12:15=E2=80=AFPM Eli Zaretskii wrote: > > > From: Lin Sun > > Date: Wed, 1 May 2024 06:40:25 +0000 > > > > Since emacs-29 the Eshell has been enhanced for the ansi-color a lot. > > And the function `eshell-exec-visual` can support the executables with > > colors, eg VIM, tmux... > > I have tested the "/bin/ls --color=3Dtty", "/bin/grep --color=3Dtty" ..= . > > and other executables in Eshell with "export TERM=3Deshell-color", they > > all work great. > > > > So we can safely export eshell's "TERM" with `eshell-term-name` to > > support executables with colors. > > I attached the patch, please help review it. Thanks. > > Thanks. > > The fact that we can safely do that does not yet mean we _should_ do > it. In my book, setting TERM is a user preference, more or less. > IOW, this is a change in the default behavior. > > Jim, WDYT? The patch tries to uniform the behavior of "eshell" and "eshell-exec-visual= ". When I tried the eshell visual commands, I noticed its experience is better than eshell, and I figured out the eshell exec visual gives TERM with "eshell-term-name", but eshell didn't do that. And this patch will not affect the users who customized their TERM environment in eshell profile or eshell hook functions.