From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lin Sun Newsgroups: gmane.emacs.bugs Subject: bug#70271: 30.0.50; [PATCH] * lisp/ls-lisp.el (ls-lisp--sanitize-switches): support more Date: Mon, 8 Apr 2024 20:43:54 +0000 Message-ID: References: <86bk6kyu41.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000ce764506159bdd4f" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14507"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70271@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 08 22:45:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rtvro-0003Yr-VJ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Apr 2024 22:45:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtvrM-000511-Uw; Mon, 08 Apr 2024 16:44:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtvrL-00050W-7s for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 16:44:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rtvrK-0007do-Vy for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 16:44:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rtvrS-0001ZR-Ht for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 16:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lin Sun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Apr 2024 20:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70271 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70271-submit@debbugs.gnu.org id=B70271.17126090685822 (code B ref 70271); Mon, 08 Apr 2024 20:45:02 +0000 Original-Received: (at 70271) by debbugs.gnu.org; 8 Apr 2024 20:44:28 +0000 Original-Received: from localhost ([127.0.0.1]:47780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtvqp-0001VI-4g for submit@debbugs.gnu.org; Mon, 08 Apr 2024 16:44:28 -0400 Original-Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:61634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtvql-0001UF-FV for 70271@debbugs.gnu.org; Mon, 08 Apr 2024 16:44:20 -0400 Original-Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a51b5633c9cso325164766b.2 for <70271@debbugs.gnu.org>; Mon, 08 Apr 2024 13:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712609046; x=1713213846; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Vw+iFYRCKbcXNdv/gsNqoqIjevVcSKPWvD8Gd+aFTnE=; b=R1o8mObO1pXQKvzHkNcJvnux8whnzrYAQ1v8jq6eFKT5wuv+Ry8yEX5R1OAETTj266 fH+mXRT5C+j+9n7zBz5WZla591wpm8W3eXVZJygao6waBowYQsjPlXhO1bINkkQD7iZa xzY/RlJEhQaexV5frurrqUDhkq4XmQ4qKDNdL2Z0qMDqCWuQagmssi9r0R9VPonDVolp RuW1qNSmieUEvXNg+lAyCSTAtlY9NJl0w2uy01e5KtDDv6mkgblEkIaGrI4ON1/CqGy4 +3Ns0SmlxXTx0JanJ+gk1C8vY/WZnn8pNUIEhtHPCyR6Y+I4sgYJKGnvxNGqfeqYsAlX EisQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712609046; x=1713213846; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Vw+iFYRCKbcXNdv/gsNqoqIjevVcSKPWvD8Gd+aFTnE=; b=ZY7xJkk6NzCZt991VLDUqJl71qkbWgUI43rL7FukYiLzDlYEZJynPK9veEh9usJ6Q6 sVuTrqXWvDH8r1Tb+oooSANpnf5niXQ3r6vzcNJwsIfEDGGInzxZXuswO3DvA7HQaU0i efyLvd/BRQBEw81YTNqGAg6gWQqBj+QI6XX96V5mXd3tQ4+VG6/4MMn3qIJv9LhaPP6s 7Y/0rDyrJjfsX7liz1xkKzIwko4JYiAJajLveTAO6vfVW06Fh1FEbByEPzT13kx278sW bkW9wOuDnVZCB3np50pverJ/l1F3i4JR/Gg3VCleSyT7Jkadncq7EvOVyPprbmX2NLpe DlOQ== X-Gm-Message-State: AOJu0YxA/wigy8YNHT9mPe7zHd4rtitbebRtvnXZtCTnDN73p9Nhbufo OKODZHdn79GYyotz7Zm7Pt5m+GVSyRgXtltTkU073qve8kdIHy+Gu8fYb6m3ae3lGySJczkqChn voadZxqDm25iDB/7gpN1WlGJ9ce8= X-Google-Smtp-Source: AGHT+IHFJYyXAdc4ej5E0HhLrRoB6uhPP8QNB0+T/8QkiHSa+Lxd9zXtSLs84aQgoNXqsOdeorEZWCSWHFlZLGejkqw= X-Received: by 2002:a17:907:25c8:b0:a51:ddc6:f9c0 with SMTP id ae8-20020a17090725c800b00a51ddc6f9c0mr2321305ejc.45.1712609045666; Mon, 08 Apr 2024 13:44:05 -0700 (PDT) In-Reply-To: <86bk6kyu41.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282953 Archived-At: --000000000000ce764506159bdd4f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Apr 8, 2024 at 11:25=E2=80=AFAM Eli Zaretskii wrote: > > > From: Lin Sun > > Date: Mon, 8 Apr 2024 05:10:22 +0000 > > > > The dired ignored the options like "--time=3Dctime" in the variable > > `dired-listing-switches' on Windows OS. > > > > I traced the code and found dired will use the functions in the > > `ls-lisp.el' instead of calling the real command "/usr/bin/ls", and > > the "ls-lisp.el" didn't process the "--time=3Dctime" option. > > > > The attached PATCH will convert the "--time=3Dctime" to "-c"... in the > > "ls-lisp.el", and then the dired will display the desired time in its > > time column. > > > > Here is the verification code (on Windows OS), try it one line and > > close the dired buffer then try next line. > > > > (dired "/tmp/aa" "-al --sort=3Dtime") ; as "-al -t" > > > > (dired "/tmp/aa" "-al --time=3Dctime") ; as "al -c" > > > > (dired "/tmp/aa" "-al --time=3Datime") ; as "al -u" > > > > Please help review the changes and approve them. Thanks > > Thanks, but how about adding some tests for this? Sure, I had added the test case for this ticket. Changes are attached in the PATCH. Please help review again. Thanks. --000000000000ce764506159bdd4f Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Support-more-time-options-for-ls-lisp-sanitize-switc.patch" Content-Disposition: attachment; filename="0001-Support-more-time-options-for-ls-lisp-sanitize-switc.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lurf75if0 RnJvbSA5NDQxMGNlMWQ1ZmY5M2RhNGZiMWRmOTZhYmRiNzBjNjUxNDFmZjdkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBN b24sIDggQXByIDIwMjQgMDY6NTk6MjEgKzAwMDAKU3ViamVjdDogW1BBVENIXSBTdXBwb3J0IG1v cmUgdGltZSBvcHRpb25zIGZvciBgbHMtbGlzcC0tc2FuaXRpemUtc3dpdGNoZXMnCiAoYnVnIzcw MjcxKQoKKiBsaXNwL2xzLWxpc3AuZWwgKGxzLWxpc3AtLXNhbml0aXplLXN3aXRjaGVzKTogbW9y ZSB0aW1lIG9wdGlvbnMKKiB0ZXN0L2xpc3AvbHMtbGlzcC10ZXN0cy5lbDogdGVzdCBjYXNlIGZv ciBidWcjNzAyNzEKLS0tCiBsaXNwL2xzLWxpc3AuZWwgICAgICAgICAgICB8ICAzICsrKwogdGVz dC9saXNwL2xzLWxpc3AtdGVzdHMuZWwgfCAzNiArKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBh L2xpc3AvbHMtbGlzcC5lbCBiL2xpc3AvbHMtbGlzcC5lbAppbmRleCBkMDliNTNiMWNjLi5hZTRh NDM3OTdmIDEwMDY0NAotLS0gYS9saXNwL2xzLWxpc3AuZWwKKysrIGIvbGlzcC9scy1saXNwLmVs CkBAIC04NzMsNiArODczLDcgQEAgbHMtbGlzcC0tc2FuaXRpemUtc3dpdGNoZXMKICAgKGxldCAo KGxzZmxhZ3MgJygoIi1hIiAuICItLWFsbCIpCiAgICAgICAgICAgICAgICAgICAgKCItQSIgLiAi LS1hbG1vc3QtYWxsIikKICAgICAgICAgICAgICAgICAgICAoIi1CIiAuICItLWlnbm9yZS1iYWNr dXBzIikKKyAgICAgICAgICAgICAgICAgICAoIi1jIiAuICItLXRpbWU9Y3RpbWUiKQogICAgICAg ICAgICAgICAgICAgICgiLUMiIC4gIi0tY29sb3IiKQogICAgICAgICAgICAgICAgICAgICgiLUYi IC4gIi0tY2xhc3NpZnkiKQogICAgICAgICAgICAgICAgICAgICgiLUciIC4gIi0tbm8tZ3JvdXAi KQpAQCAtODgzLDcgKzg4NCw5IEBAIGxzLWxpc3AtLXNhbml0aXplLXN3aXRjaGVzCiAgICAgICAg ICAgICAgICAgICAgKCItciIgLiAiLS1yZXZlcnNlIikKICAgICAgICAgICAgICAgICAgICAoIi1S IiAuICItLXJlY3Vyc2l2ZSIpCiAgICAgICAgICAgICAgICAgICAgKCItcyIgLiAiLS1zaXplIikK KyAgICAgICAgICAgICAgICAgICAoIi10IiAuICItLXNvcnQ9dGltZSIpCiAgICAgICAgICAgICAg ICAgICAgKCItUyIgLiAiLS1zb3J0LipbIFxcXHRdIikKKyAgICAgICAgICAgICAgICAgICAoIi11 IiAuICItLXRpbWU9YXRpbWUiKQogICAgICAgICAgICAgICAgICAgICgiIiAgIC4gIi0tZ3JvdXAt ZGlyZWN0b3JpZXMtZmlyc3QiKQogICAgICAgICAgICAgICAgICAgICgiIiAgIC4gIi0tYXV0aG9y IikKICAgICAgICAgICAgICAgICAgICAoIiIgICAuICItLWVzY2FwZSIpCmRpZmYgLS1naXQgYS90 ZXN0L2xpc3AvbHMtbGlzcC10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9scy1saXNwLXRlc3RzLmVsCmlu ZGV4IDc3MDQ2ODcxZWEuLjgxZTNlMTYzYzkgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9scy1saXNw LXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9scy1saXNwLXRlc3RzLmVsCkBAIC0yOSw2ICsyOSw0 MiBAQAogKHJlcXVpcmUgJ2xzLWxpc3ApCiAocmVxdWlyZSAnZGlyZWQpCiAKKyhlcnQtZGVmdGVz dCBscy1saXNwLXRlc3QtYnVnNzAyNzEgKCkKKyAgIlRlc3QgZm9yIGh0dHBzOi8vZGViYnVncy5n bnUub3JnLzcwMjcxIC4iCisgIChlcnQtd2l0aC10ZW1wLWZpbGUKKyAgIGZwYXRoCisgICA6c3Vm Zml4ICJidWc3MDI3MSIKKyAgIChsZXQqICgoZGlyIChmaWxlLW5hbWUtZGlyZWN0b3J5IGZwYXRo KSkKKyAgICAgICAgICAoYXR0cmlidXRlcyAoZmlsZS1hdHRyaWJ1dGVzIGZwYXRoKSkKKyAgICAg ICAgICAoZGlyZWQtZmluZC1zdWJkaXIgdCkKKyAgICAgICAgICBscy1saXNwLXVzZS1pbnNlcnQt ZGlyZWN0b3J5LXByb2dyYW0gYnVmIHRzKQorICAgICAodW53aW5kLXByb3RlY3QKKyAgICAgICAg IChwcm9nbgorICAgICAgICAgICAoc2V0cSB0cyAoZmlsZS1hdHRyaWJ1dGUtYWNjZXNzLXRpbWUg YXR0cmlidXRlcykpCisgICAgICAgICAgICh3aXRoLWN1cnJlbnQtYnVmZmVyCisgICAgICAgICAg ICAgICAoZGlyZWQtaW50ZXJuYWwtbm9zZWxlY3QgZGlyICItbGEgLS10aW1lPWN0aW1lIikKKyAg ICAgICAgICAgICAoc2V0cSBidWYgKGN1cnJlbnQtYnVmZmVyKQorICAgICAgICAgICAgICAgICAg IHN0ciAoZm9ybWF0LXRpbWUtc3RyaW5nICIlSDolTSIgdHMpKQorICAgICAgICAgICAgIChzaG91 bGQgKHNlYXJjaC1mb3J3YXJkLXJlZ2V4cCBzdHIgbmlsIHQpKQorICAgICAgICAgICAgIChraWxs LWJ1ZmZlcikpCisgICAgICAgICAgIChzZXRxIHRzICgtIChmbG9hdC10aW1lKSA2MCkpCisgICAg ICAgICAgIChzZXQtZmlsZS10aW1lcyBmcGF0aCB0cykKKyAgICAgICAgICAgKHdpdGgtY3VycmVu dC1idWZmZXIKKyAgICAgICAgICAgICAgIChkaXJlZC1pbnRlcm5hbC1ub3NlbGVjdCBkaXIgIi1s YSAtLXNvcnQ9dGltZSIpCisgICAgICAgICAgICAgKHNldHEgYnVmIChjdXJyZW50LWJ1ZmZlcikK KyAgICAgICAgICAgICAgICAgICBzdHIgKGZvcm1hdC10aW1lLXN0cmluZyAiJUg6JU0iIHRzKSkK KyAgICAgICAgICAgICAoc2hvdWxkIChzZWFyY2gtZm9yd2FyZC1yZWdleHAgc3RyIG5pbCB0KSkK KyAgICAgICAgICAgICAoa2lsbC1idWZmZXIpKQorICAgICAgICAgICAoc2V0cSB0cyAoLSAoZmxv YXQtdGltZSkgMTIwKSkKKyAgICAgICAgICAgKHNldC1maWxlLXRpbWVzIGZwYXRoIHRzKQorICAg ICAgICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlcgorICAgICAgICAgICAgICAgKGRpcmVkLWludGVy bmFsLW5vc2VsZWN0IGRpciAiLWxhIC0tdGltZT1hdGltZSIpCisgICAgICAgICAgICAgKHNldHEg YnVmIChjdXJyZW50LWJ1ZmZlcikKKyAgICAgICAgICAgICAgICAgICBzdHIgKGZvcm1hdC10aW1l LXN0cmluZyAiJUg6JU0iIHRzKSkKKyAgICAgICAgICAgICAoc2hvdWxkIChzZWFyY2gtZm9yd2Fy ZC1yZWdleHAgc3RyIG5pbCB0KSkKKyAgICAgICAgICAgICAoa2lsbC1idWZmZXIpKSkKKyAgICAg ICAod2hlbiAoYnVmZmVyLWxpdmUtcCBidWYpIChraWxsLWJ1ZmZlciBidWYpKSkpKSkKKwogKGVy dC1kZWZ0ZXN0IGxzLWxpc3AtdGVzdC1idWcyNzc2MiAoKQogICAiVGVzdCBmb3IgaHR0cHM6Ly9k ZWJidWdzLmdudS5vcmcvMjc3NjIgLiIKICAgKGxldCogKChkaXIgc291cmNlLWRpcmVjdG9yeSkK LS0gCjIuMjAuNQoK --000000000000ce764506159bdd4f--