From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lin Sun Newsgroups: gmane.emacs.bugs Subject: bug#70610: 30.0.50; [PATCH] * lisp/eshell/esh-mode.el (eshell-first-time-mode-hook): Run the hook for once Date: Sat, 27 Apr 2024 16:32:24 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000531ae0061716914c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9759"; mail-complaints-to="usenet@ciao.gmane.io" To: 70610@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 27 18:34:04 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0l00-0002Ni-EB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Apr 2024 18:34:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0kzh-0002aq-Fa; Sat, 27 Apr 2024 12:33:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0kzg-0002aa-Bz for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2024 12:33:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s0kzg-0002r6-3v for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2024 12:33:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s0kzy-0000LP-FG for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2024 12:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lin Sun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2024 16:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 70610 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17142355841304 (code B ref -1); Sat, 27 Apr 2024 16:34:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Apr 2024 16:33:04 +0000 Original-Received: from localhost ([127.0.0.1]:49572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0kz2-0000Ky-DB for submit@debbugs.gnu.org; Sat, 27 Apr 2024 12:33:04 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:40626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0kz0-0000Kb-Uu for submit@debbugs.gnu.org; Sat, 27 Apr 2024 12:33:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0kyc-0002U3-Da for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2024 12:32:38 -0400 Original-Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s0kya-0002lt-Us for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2024 12:32:38 -0400 Original-Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-571be483ccaso3758910a12.2 for ; Sat, 27 Apr 2024 09:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714235555; x=1714840355; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=DqhWzOoTbs48V7xMemELlno05SlI8ehQV0mzBBu1g80=; b=HN9EbEFMdjKMEAUEEDR6pnJNXYp7dLVYPxGs7Dksh9wVo+78i6tlmHtOMgLYIZPfCB 6hAw4Jt9cgWHmf11pJhDp8WAXPaQB148/3gXxFUk/qG7q3TvuHF9Lt894774KmX4s+O+ DsWOyBbk2O2cQEhxsWDhZDc1Li4ADab8heVxI2o1iIkT75Q3F+/wSuGAMlHroOLL+c3o N72xwVnwvktSAziaRBTzRjmxkFYVuQVuNPlVPwujIMLRoAhEajY9pUkeS4yjy7aoWBMl B00O3Hq2opVTnTJiuarzRVEL/p5042sOtbkEAwgLpEACMhUwB0+pFiD8A3C+qRRIsu/F Rkfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714235555; x=1714840355; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DqhWzOoTbs48V7xMemELlno05SlI8ehQV0mzBBu1g80=; b=CYVhqHK3YBM/JNr0D3vIhnfFoIlijf2Nydrf4++ZfUVvifjYVUx/diyB/x8JKIV0sz 1eOA8A2zN9FBbPev64lRFifaxewofromNlBGB0+yU02UW+hMROWKsy1rQUXfXY2rWFXg AUtI2wDX8xl/4jp96MpWUAepM6vNJHUtoCs1lTHcqb+XJxd470DlKza3w75AT6b/pq2q Y80GzyJ/MAX/kw+mZuHi8wXUMWV3rvg+b8snC+M56umh7js+EqnzPmlbNMAdZGgXkpVz 2A9CAWU1dg5FtjNFHsAEOtBKeCvC+TtIvv1kEjb9DCI9K9Md80/8xIfEjTM7vDL/MGJ+ wLyQ== X-Gm-Message-State: AOJu0YwZ7GPYwQdewalVW1QcZLlwYCXPc6mka4jULlXQgoWPWflkdrg9 H4ExuK44DwjWcwtJIiNV3VlSqeCTcGQLxwSUZvGFVJiiKLj5IB4VyfrlT+xmkFODxSTFtEwm/km pwZAW0sCYkRYn+OSRIlmsuNPw000A+iYZ X-Google-Smtp-Source: AGHT+IEnE+wNb6lFopWxxJhg0eOr22+QXnSMsgQX329ykKhUT7nCq2XkIcvAloqTcFnUSa8eLrEtG9/w4nExJ6VgUGI= X-Received: by 2002:a50:9b5b:0:b0:56b:ed78:f58 with SMTP id a27-20020a509b5b000000b0056bed780f58mr3644426edj.33.1714235555082; Sat, 27 Apr 2024 09:32:35 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=sunlin7.mail@gmail.com; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284057 Archived-At: --000000000000531ae0061716914c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, The document of `eshell-first-time-mode-hook' says it would be run the first time eshell started. > A hook that gets run the first time =E2=80=98eshell-mode=E2=80=99 is ente= red. > That is to say, the first time during an Emacs session. But it actually runs every time for an eshell buffer(start an eshell, exit it, start an eshell again). Here is the one line code to show that: (add-hook 'eshell-first-time-mode-hook '(lambda () (message "test"))) The patch will make the `eshell-first-time-mode-hook' only run once as its document described. Please help review the patch. Thanks Best Regards Lin --000000000000531ae0061716914c Content-Type: text/x-patch; charset="US-ASCII"; name="0001-lisp-eshell-esh-mode.el-eshell-first-time-mode-hook-.patch" Content-Disposition: attachment; filename="0001-lisp-eshell-esh-mode.el-eshell-first-time-mode-hook-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lvibkwb50 RnJvbSAwOTRiZTg0MWJmMjI2MWZiNWVmYzBjYWNkMGE0MGQzNDY5NTkwNmQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBT YXQsIDI3IEFwciAyMDI0IDA2OjU1OjQ5ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gKiBsaXNwL2Vz aGVsbC9lc2gtbW9kZS5lbCAoZXNoZWxsLWZpcnN0LXRpbWUtbW9kZS1ob29rKTogUnVuCiB0aGUg aG9vayBmb3Igb25jZQoKLS0tCiBsaXNwL2VzaGVsbC9lc2gtbW9kZS5lbCB8IDYgKysrKy0tCiAx IGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL2xpc3AvZXNoZWxsL2VzaC1tb2RlLmVsIGIvbGlzcC9lc2hlbGwvZXNoLW1vZGUuZWwKaW5k ZXggYjE1Zjk5YTAzNS4uNWRlMjAwY2U0YiAxMDA2NDQKLS0tIGEvbGlzcC9lc2hlbGwvZXNoLW1v ZGUuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLW1vZGUuZWwKQEAgLTQxOCw4ICs0MTgsMTAgQEAg ZXNoZWxsLW1vZGUKIAogICAoYWRkLWhvb2sgJ2tpbGwtYnVmZmVyLWhvb2sgIydlc2hlbGwta2ls bC1idWZmZXItZnVuY3Rpb24gdCB0KQogCi0gIChpZiBlc2hlbGwtZmlyc3QtdGltZS1wCi0gICAg ICAocnVuLWhvb2tzICdlc2hlbGwtZmlyc3QtdGltZS1tb2RlLWhvb2spKQorICAod2hlbiBlc2hl bGwtZmlyc3QtdGltZS1wCisgICAgKHNldHEgZXNoZWxsLWZpcnN0LXRpbWUtcCBuaWwpCisgICAg KHJ1bi1ob29rcyAnZXNoZWxsLWZpcnN0LXRpbWUtbW9kZS1ob29rKSkKKwogICAocnVuLWhvb2tz ICdlc2hlbGwtcG9zdC1jb21tYW5kLWhvb2spKQogCiAocHV0ICdlc2hlbGwtbW9kZSAnbW9kZS1j bGFzcyAnc3BlY2lhbCkKLS0gCjIuMjAuNQoK --000000000000531ae0061716914c--