From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: lin Sun via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58708: 29.0.50; [PATCH] Fix build error that gflags.will_dump_ not surround by the directives as its definition Date: Sat, 22 Oct 2022 05:16:45 +0000 Message-ID: References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> Reply-To: lin Sun Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000d6822105eb98aa27" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25392"; mail-complaints-to="usenet@ciao.gmane.io" To: 58708@debbugs.gnu.org, eliz@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 22 07:40:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1om7FL-0006S4-QZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Oct 2022 07:40:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1om6tY-0006TR-Lu; Sat, 22 Oct 2022 01:18:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om6tW-0006Sz-HZ for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 01:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1om6tW-00061H-4G for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 01:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1om6tV-0004Vf-Qz for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 01:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: lin Sun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Oct 2022 05:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58708 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" , eliz@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166641582817266 (code B ref -1); Sat, 22 Oct 2022 05:18:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Oct 2022 05:17:08 +0000 Original-Received: from localhost ([127.0.0.1]:39525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1om6se-0004UQ-Gh for submit@debbugs.gnu.org; Sat, 22 Oct 2022 01:17:08 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:38804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1om6sc-0004UI-8R for submit@debbugs.gnu.org; Sat, 22 Oct 2022 01:17:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om6sb-0005zs-3J for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 01:17:06 -0400 Original-Received: from sonic304-20.consmr.mail.ne1.yahoo.com ([66.163.191.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1om6sZ-0005qZ-Kw for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 01:17:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1666415820; bh=mqo4P5jSkqJ6UkRF5tPqlxZ6vAB3eGfv57e1JwBN9ZY=; h=References:In-Reply-To:From:Date:Subject:To:From:Subject:Reply-To; b=BsWzSPEQfORQ9KN9ByC5dljh2hri4hWFNUqR3dVCBGJhuxS3QwuXAhhmDMkpZCnHQjW/Wkbf7a0Jc+qrNg0eHzIhO5sYVOd2qx4yIPMtKp7zvrPDJjfDHjLXzswj0eqIyG/3r8w2TjpxfaUh337+pGy2T6kOkR+nPPmfyJFETvbR6CZUUq2gmhxwawMcxOKtqXm+D+uflR0L4QWSTIipIVbY1y4N/Mj5YxkJaIfcPMNZt+FIT88rJBcjAsOnEGTvaMGEleD7McA+gngJ07TNHOc0k9No1WAAcN4ExygcJJiecK3S3oGMDaMVQeFRUx37izMe6cvnVXY0kX70CU5BRg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1666415820; bh=MN7eqOX6Et6HYuaJe6RSBoQi690VNDVxcZBkB27FO5C=; h=X-Sonic-MF:From:Date:Subject:To:From:Subject; b=ozCVYdXIW0LrYMbe2on38Rh18Ckwr9+YFe5CoxiExgeTxCikOlWmhhFen0IrDUJUqP522vIZQAYxJded7iWl8uAknF6NPhaysc9IT8vBASlywe8C2f9XhWs4DhShGBRWiPSqldrIUz/4S+Rsc+5Ig1sIVRFe+W1mj3hBYnUGmJ6deZAu1nevSbD4Fxw8uQV8WU83rEHLw/DONmJsQ5oLaSY/Lgz8G7/mbVuQomSv4IKz0IfWBPyQlU20+UHTSM+NzVQkFwxRJTG1/74mAZWpg4ivWSzLq5rxJMbOZHEfBlsy9bVj2XRX/wAQUE+okOQ0wyMe481tSliF8bXGrCJx9A== X-YMail-OSG: GDj9YL4VM1lunwfoYgckah2AW7WCUqhAWxNIdMDW1M9ouqwhAOnBqHujBXMtejY dA6CyAareSFCd3y8zez4HePJs2H5vNJ9mf9PmT3uKRP09oN7kA_NvH0l84egMJf2xDeLVSFb1nTb gfJH6uPRhTgDyevH8.MCOzcDI0NQUA16ZZyxlcJ2YQHisiucyHifbuNV0OWjFlvd._4YFP2h53gv XuAVt1hKANKbeHgM1T_JWPdY0aWpzhuYjthRkCemIpVVeoR.ihIBLsMRSBwr4rmciU6bXJAtwFA. V48.R0CU1qEaEFFTETrLoecUCnc.I8yI3vXPADtoxPp0Fm1LT2TFMYuLdZjlf43WZL9Lk4lk_FQd rgCLqGM3NPG.2TTA2CaClNN5wil1P_zPEGDnaNHRWvbhde_z3CpPUjP5c936iWanEk98.ZyY9GA0 0fN7Esw3DlDakqJ6sYjyiX6IfyJBF2RWDyHju1E3coAQlNJB0JwFwVByZDezyDAeMf09FJYnufth VLu1m9GVyNU08GmTcqJnm5MlKV_BM6qZYpGPBcQAWVloPyBxPtZXP_5meHtikbZ74MsQA4g4OtEZ 3NP0_VFBWbrJI_H5SsjOZMTp_QrhmgNBOCBuPFdGpP__OdnkvRzQ56kl22Py9QIEeY.sPHwzF5mC 3GsZUk2LqRbspfKh9pLs7npnozNUNHeLdhaFUznw3xPklF7quykgh.Vkea6m3_tc6JHtk0o_3RfP 43IRGE3c75pO.FKs.ZhIPgPN5w16rzBHx_zVJWrPLziUJPmu26PaQuHQd3cIiLRSxTgy0n37A8ik Zf8WCXhWICZzDtQYbpFrWLoaJHB7aiWY6uVZynfS9u X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Sat, 22 Oct 2022 05:17:00 +0000 Original-Received: by hermes--production-ir2-96dfb7869-6ppkz (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 8649faccb11f3537f48cb820664f3d86; Sat, 22 Oct 2022 05:16:58 +0000 (UTC) Original-Received: by mail-ed1-f43.google.com with SMTP id u21so12987347edi.9; Fri, 21 Oct 2022 22:16:58 -0700 (PDT) X-Gm-Message-State: ACrzQf3wN673yEn8tMMBptVb8nPnXM/NRI9bERNAeHjr8FmSmBLwokPp hOuVtMGYqCZc2Z7Eu6n+5n3prxMb3bnF6AGK02s= X-Google-Smtp-Source: AMsMyM7eV/0cIn4w1f1zrggnjAU/tBhuBge2JBgzCSkVBNWwowHSs0CJ/cuqDmMZgGdPzVNeaz27TSyaPu2T9x3f2JQ= X-Received: by 2002:a05:6402:1cc5:b0:453:ed3f:6a38 with SMTP id ds5-20020a0564021cc500b00453ed3f6a38mr20803521edb.346.1666415817277; Fri, 21 Oct 2022 22:16:57 -0700 (PDT) In-Reply-To: X-Gmail-Original-Message-ID: X-Mailer: WebService/1.1.20754 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.191.146; envelope-from=sunlin7@yahoo.com; helo=sonic304-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246022 Archived-At: --000000000000d6822105eb98aa27 Content-Type: text/plain; charset="UTF-8" Hi, The "gflags.will_dump_" is defined in the lisp.h and surround by these directives, #if defined HAVE_PDUMPER || defined HAVE_UNEXEC bool will_dump_ : 1; #endif But its references weren't surrounded with the same directives, so emacs will fail to build without any dumper. This patch will fix the build errors. Please review and merge this patch. Thanks Best Regards Lin --000000000000d6822105eb98aa27 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-lisp.h-suround-the-gflags.will_dump_-with-same-direc.patch" Content-Disposition: attachment; filename="0001-lisp.h-suround-the-gflags.will_dump_-with-same-direc.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l9jgxrqn0 RnJvbSA1YjViYzE1NDczMmQxZjUzMjgwM2FhZThmYTIwNDVkZWNkMzhiYmVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBT YXQsIDIyIE9jdCAyMDIyIDAwOjAwOjA2ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gbGlzcC5oOiBz dXJvdW5kIHRoZSBnZmxhZ3Mud2lsbF9kdW1wXyB3aXRoIHNhbWUgZGlyZWN0aXZlcyBhcwogaXRz IGRlZmluaXRpb24KCi0tLQogc3JjL2V2YWwuYyB8IDIgKysKIHNyYy9mbnMuYyAgfCAyICsrCiAy IGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9ldmFsLmMg Yi9zcmMvZXZhbC5jCmluZGV4IDg4MTAxMzYuLjdlMGM3M2IgMTAwNjQ0Ci0tLSBhL3NyYy9ldmFs LmMKKysrIGIvc3JjL2V2YWwuYwpAQCAtMjMwMCw5ICsyMzAwLDExIEBAIERFRlVOICgiYXV0b2xv YWQtZG8tbG9hZCIsIEZhdXRvbG9hZF9kb19sb2FkLCBTYXV0b2xvYWRfZG9fbG9hZCwgMSwgMywg MCwKICAgICAgb2Ygd2hhdCBmaWxlcyBhcmUgcHJlbG9hZGVkIGFuZCB3aGVuLiAgKi8KICAgaWYg KHdpbGxfZHVtcF9wICgpICYmICF3aWxsX2Jvb3RzdHJhcF9wICgpKQogICAgIHsKKyNpZiBkZWZp bmVkIEhBVkVfUERVTVBFUiB8fCBkZWZpbmVkIEhBVkVfVU5FWEVDCiAgICAgICAvKiBBdm9pZCBs YW5kaW5nIGhlcmUgcmVjdXJzaXZlbHkgd2hpbGUgb3V0cHV0dGluZyB0aGUKIAkgYmFja3RyYWNl IGZyb20gdGhlIGVycm9yLiAgKi8KICAgICAgIGdmbGFncy53aWxsX2R1bXBfID0gZmFsc2U7Cisj ZW5kaWYKICAgICAgIGVycm9yICgiQXR0ZW1wdCB0byBhdXRvbG9hZCAlcyB3aGlsZSBwcmVwYXJp bmcgdG8gZHVtcCIsCiAJICAgICBTREFUQSAoU1lNQk9MX05BTUUgKGZ1bm5hbWUpKSk7CiAgICAg fQpkaWZmIC0tZ2l0IGEvc3JjL2Zucy5jIGIvc3JjL2Zucy5jCmluZGV4IDQwNTU3OTIuLjliZTY1 ZGUgMTAwNjQ0Ci0tLSBhL3NyYy9mbnMuYworKysgYi9zcmMvZm5zLmMKQEAgLTMzMjksNyArMzMy OSw5IEBAIERFRlVOICgicmVxdWlyZSIsIEZyZXF1aXJlLCBTcmVxdWlyZSwgMSwgMywgMCwKIAl7 CiAJICAvKiBBdm9pZCBsYW5kaW5nIGhlcmUgcmVjdXJzaXZlbHkgd2hpbGUgb3V0cHV0dGluZyB0 aGUKIAkgICAgIGJhY2t0cmFjZSBmcm9tIHRoZSBlcnJvci4gICovCisjaWYgZGVmaW5lZCBIQVZF X1BEVU1QRVIgfHwgZGVmaW5lZCBIQVZFX1VORVhFQwogCSAgZ2ZsYWdzLndpbGxfZHVtcF8gPSBm YWxzZTsKKyNlbmRpZgogCSAgZXJyb3IgKCIocmVxdWlyZSAlcykgd2hpbGUgcHJlcGFyaW5nIHRv IGR1bXAiLAogCQkgU0RBVEEgKFNZTUJPTF9OQU1FIChmZWF0dXJlKSkpOwogCX0KLS0gCjIuNy4w Cgo= --000000000000d6822105eb98aa27--